check-style.sh 2.25 KB
Newer Older
1
2
3
#!/bin/bash
# 
# Script to check include/test code for common pybind11 code style errors.
Wenzel Jakob's avatar
Wenzel Jakob committed
4
5
6
7
# 
# This script currently checks for
#
# 1. use of tabs instead of spaces
8
9
10
# 2. MSDOS-style CRLF endings
# 3. trailing spaces
# 4. missing space between keyword and parenthesis, e.g.: for(, if(, while(
Wenzel Jakob's avatar
Wenzel Jakob committed
11
# 5. Missing space between right parenthesis and brace, e.g. 'for (...){'
12
13
# 6. opening brace on its own line. It should always be on the same line as the
#    if/while/for/do statment.
14
15
16
17
# 
# Invoke as: tools/check-style.sh
#

18
19
20
errors=0
IFS=$'\n'
found=
21
# The mt=41 sets a red background for matched tabs:
22
23
GREP_COLORS='mt=41' GREP_COLOR='41' grep $'\t' include tests/*.{cpp,py,h} docs/*.rst -rn --color=always |
        while read f; do
24
    if [ -z "$found" ]; then
25
        echo -e '\033[31m\033[01mError: found tabs instead of spaces in the following files:\033[0m'
26
        found=1
27
        errors=1
28
29
30
31
32
    fi

    echo "    $f"
done

Wenzel Jakob's avatar
Wenzel Jakob committed
33
found=
34
35
grep -IUlr $'\r' include tests/*.{cpp,py,h} docs/*.rst --color=always |
        while read f; do
Wenzel Jakob's avatar
Wenzel Jakob committed
36
    if [ -z "$found" ]; then
37
        echo -e '\033[31m\033[01mError: found CRLF characters in the following files:\033[0m'
Wenzel Jakob's avatar
Wenzel Jakob committed
38
39
40
41
42
43
44
        found=1
        errors=1
    fi

    echo "    $f"
done

45
found=
46
# The mt=41 sets a red background for matched trailing spaces
47
48
GREP_COLORS='mt=41' GREP_COLOR='41' grep '[[:blank:]]\+$' include tests/*.{cpp,py,h} docs/*.rst -rn --color=always |
        while read f; do
49
    if [ -z "$found" ]; then
50
        echo -e '\033[31m\033[01mError: found trailing spaces in the following files:\033[0m'
51
52
53
54
55
56
57
        found=1
        errors=1
    fi

    echo "    $f"
done

58
found=
59
60
grep '\<\(if\|for\|while\|catch\)(\|){' include tests/*.{cpp,py,h} -rn --color=always |
        while read line; do
61
    if [ -z "$found" ]; then
62
        echo -e '\033[31m\033[01mError: found the following coding style problems:\033[0m'
63
64
65
66
67
68
69
        found=1
        errors=1
    fi

    echo "    $line"
done

70
found=
71
72
GREP_COLORS='mt=41' GREP_COLOR='41' grep '^\s*{\s*$' include docs/*.rst -rn --color=always |
        while read f; do
73
    if [ -z "$found" ]; then
74
        echo -e '\033[31m\033[01mError: braces should occur on the same line as the if/while/.. statement. Found issues in the following files: \033[0m'
75
76
77
78
79
80
81
        found=1
        errors=1
    fi

    echo "    $f"
done

82
exit $errors