check-style.sh 1.88 KB
Newer Older
1
2
3
#!/bin/bash
# 
# Script to check include/test code for common pybind11 code style errors.
Wenzel Jakob's avatar
Wenzel Jakob committed
4
5
6
7
8
9
# 
# This script currently checks for
#
# 1. use of tabs instead of spaces
# 2. trailing spaces
# 3. missing space between keyword and parenthesis, e.g.: for(, if(, while(
Wenzel Jakob's avatar
Wenzel Jakob committed
10
11
12
# 4. opening brace on its own line. It should always be on the same line as the
#    if/while/for/do statment.
# 5. Missing space between right parenthesis and brace, e.g. 'for (...){'
13
14
15
16
# 
# Invoke as: tools/check-style.sh
#

17
18
19
errors=0
IFS=$'\n'
found=
20
# The mt=41 sets a red background for matched tabs:
Wenzel Jakob's avatar
Wenzel Jakob committed
21
exec 3< <(GREP_COLORS='mt=41' grep $'\t' include/ tests/*.{cpp,py,h} docs/*.rst -rn --color=always)
22
while read -u 3 f; do
23
    if [ -z "$found" ]; then
24
25
        echo -e '\e[31m\e[01mError: found tabs instead of spaces in the following files:\e[0m'
        found=1
26
        errors=1
27
28
29
30
31
    fi

    echo "    $f"
done

Wenzel Jakob's avatar
Wenzel Jakob committed
32
33
34
35
36
37
38
39
40
41
42
43
44
found=
# The mt=41 sets a red background for matched trailing spaces
exec 3< <(GREP_COLORS='mt=41' grep '\s\+$' include/ tests/*.{cpp,py,h} docs/*.rst -rn --color=always)
while read -u 3 f; do
    if [ -z "$found" ]; then
        echo -e '\e[31m\e[01mError: found trailing spaces in the following files:\e[0m'
        found=1
        errors=1
    fi

    echo "    $f"
done

45
46
47
48
49
50
51
52
53
54
55
56
found=
exec 3< <(GREP_COLORS='mt=41' grep '^\s*{\s*$' include/ docs/*.rst -rn --color=always)
while read -u 3 f; do
    if [ -z "$found" ]; then
        echo -e '\e[31m\e[01mError: braces should occur on the same line as the if/while/.. statement. Found issues in the following files: \e[0m'
        found=1
        errors=1
    fi

    echo "    $f"
done

57
found=
Wenzel Jakob's avatar
Wenzel Jakob committed
58
exec 3< <(grep '\<\(if\|for\|while\)(\|){' include/ tests/*.{cpp,py,h} -rn --color=always)
59
while read -u 3 line; do
60
61
62
63
64
65
66
67
68
69
    if [ -z "$found" ]; then
        echo -e '\e[31m\e[01mError: found the following coding style problems:\e[0m'
        found=1
        errors=1
    fi

    echo "    $line"
done

exit $errors