test_virtual_functions.cpp 19.7 KB
Newer Older
1
/*
Dean Moldovan's avatar
Dean Moldovan committed
2
    tests/test_virtual_functions.cpp -- overriding virtual functions from Python
3

4
    Copyright (c) 2016 Wenzel Jakob <wenzel.jakob@epfl.ch>
5
6
7
8
9

    All rights reserved. Use of this source code is governed by a
    BSD-style license that can be found in the LICENSE file.
*/

Dean Moldovan's avatar
Dean Moldovan committed
10
11
#include "pybind11_tests.h"
#include "constructor_stats.h"
12
#include <pybind11/functional.h>
13
#include <thread>
14
15

/* This is an example class that we'll want to be able to extend from Python */
16
class ExampleVirt  {
17
public:
18
    explicit ExampleVirt(int state) : state(state) { print_created(this, state); }
19
    ExampleVirt(const ExampleVirt &e) : state(e.state) { print_copy_created(this); }
20
21
22
23
    ExampleVirt(ExampleVirt &&e) noexcept : state(e.state) {
        print_move_created(this);
        e.state = 0;
    }
24
    virtual ~ExampleVirt() { print_destroyed(this); }
25
26

    virtual int run(int value) {
27
        py::print("Original implementation of "
28
                  "ExampleVirt::run(state={}, value={}, str1={}, str2={})"_s.format(state, value, get_string1(), *get_string2()));
29
30
31
        return state + value;
    }

32
    virtual bool run_bool() = 0;
33
    virtual void pure_virtual() = 0;
34
35
36
37
38
39
40

    // Returning a reference/pointer to a type converted from python (numbers, strings, etc.) is a
    // bit trickier, because the actual int& or std::string& or whatever only exists temporarily, so
    // we have to handle it specially in the trampoline class (see below).
    virtual const std::string &get_string1() { return str1; }
    virtual const std::string *get_string2() { return &str2; }

41
42
private:
    int state;
43
    const std::string str1{"default1"}, str2{"default2"};
44
45
46
};

/* This is a wrapper class that must be generated */
47
class PyExampleVirt : public ExampleVirt {
48
public:
49
    using ExampleVirt::ExampleVirt; /* Inherit constructors */
50

51
    int run(int value) override {
52
        /* Generate wrapping code that enables native function overloading */
53
        PYBIND11_OVERRIDE(
54
55
56
57
            int,         /* Return type */
            ExampleVirt, /* Parent class */
            run,         /* Name of function */
            value        /* Argument(s) */
58
59
60
        );
    }

61
    bool run_bool() override {
62
        PYBIND11_OVERRIDE_PURE(
63
            bool,         /* Return type */
64
            ExampleVirt,  /* Parent class */
65
66
67
            run_bool,     /* Name of function */
                          /* This function has no arguments. The trailing comma
                             in the previous line is needed for some compilers */
68
69
70
        );
    }

71
    void pure_virtual() override {
72
        PYBIND11_OVERRIDE_PURE(
73
            void,         /* Return type */
74
            ExampleVirt,  /* Parent class */
75
76
77
            pure_virtual, /* Name of function */
                          /* This function has no arguments. The trailing comma
                             in the previous line is needed for some compilers */
78
79
        );
    }
80
81
82
83

    // We can return reference types for compatibility with C++ virtual interfaces that do so, but
    // note they have some significant limitations (see the documentation).
    const std::string &get_string1() override {
84
        PYBIND11_OVERRIDE(
85
86
87
88
89
90
91
92
            const std::string &, /* Return type */
            ExampleVirt,         /* Parent class */
            get_string1,         /* Name of function */
                                 /* (no arguments) */
        );
    }

    const std::string *get_string2() override {
93
        PYBIND11_OVERRIDE(
94
95
96
97
98
99
100
            const std::string *, /* Return type */
            ExampleVirt,         /* Parent class */
            get_string2,         /* Name of function */
                                 /* (no arguments) */
        );
    }

101
102
};

103
104
class NonCopyable {
public:
105
    NonCopyable(int a, int b) : value{new int(a*b)} { print_created(this, a, b); }
106
107
108
109
    NonCopyable(NonCopyable &&o) noexcept {
        value = std::move(o.value);
        print_move_created(this);
    }
110
111
112
113
114
    NonCopyable(const NonCopyable &) = delete;
    NonCopyable() = delete;
    void operator=(const NonCopyable &) = delete;
    void operator=(NonCopyable &&) = delete;
    std::string get_value() const {
115
116
117
        if (value)
            return std::to_string(*value);
        return "(null)";
118
    }
119
    ~NonCopyable() { print_destroyed(this); }
120
121
122
123
124
125
126
127
128

private:
    std::unique_ptr<int> value;
};

// This is like the above, but is both copy and movable.  In effect this means it should get moved
// when it is not referenced elsewhere, but copied if it is still referenced.
class Movable {
public:
129
130
    Movable(int a, int b) : value{a+b} { print_created(this, a, b); }
    Movable(const Movable &m) { value = m.value; print_copy_created(this); }
131
132
133
134
    Movable(Movable &&m) noexcept {
        value = m.value;
        print_move_created(this);
    }
135
    std::string get_value() const { return std::to_string(value); }
136
    ~Movable() { print_destroyed(this); }
137
138
139
140
141
142
private:
    int value;
};

class NCVirt {
public:
143
    virtual ~NCVirt() = default;
Henry Schreiner's avatar
Henry Schreiner committed
144
145
    NCVirt() = default;
    NCVirt(const NCVirt&) = delete;
146
147
148
    virtual NonCopyable get_noncopyable(int a, int b) { return NonCopyable(a, b); }
    virtual Movable get_movable(int a, int b) = 0;

149
150
    std::string print_nc(int a, int b) { return get_noncopyable(a, b).get_value(); }
    std::string print_movable(int a, int b) { return get_movable(a, b).get_value(); }
151
152
};
class NCVirtTrampoline : public NCVirt {
153
#if !defined(__INTEL_COMPILER) && !defined(__CUDACC__) && !defined(__PGIC__)
154
    NonCopyable get_noncopyable(int a, int b) override {
155
        PYBIND11_OVERRIDE(NonCopyable, NCVirt, get_noncopyable, a, b);
156
    }
157
#endif
158
    Movable get_movable(int a, int b) override {
159
        PYBIND11_OVERRIDE_PURE(Movable, NCVirt, get_movable, a, b);
160
161
162
    }
};

163
164
165
struct Base {
    /* for some reason MSVC2015 can't compile this if the function is pure virtual */
    virtual std::string dispatch() const { return {}; };
166
    virtual ~Base() = default;
Henry Schreiner's avatar
Henry Schreiner committed
167
168
    Base() = default;
    Base(const Base&) = delete;
169
};
170

171
struct DispatchIssue : Base {
172
    std::string dispatch() const override {
173
        PYBIND11_OVERRIDE_PURE(std::string, Base, dispatch, /* no arguments */);
174
175
176
    }
};

177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
// An abstract adder class that uses visitor pattern to add two data
// objects and send the result to the visitor functor
struct AdderBase {
    struct Data {};
    using DataVisitor = std::function<void (const Data&)>;

    virtual void operator()(const Data& first, const Data& second, const DataVisitor& visitor) const = 0;
    virtual ~AdderBase() = default;
    AdderBase() = default;
    AdderBase(const AdderBase&) = delete;
};

struct Adder : AdderBase {
    void operator()(const Data& first, const Data& second, const DataVisitor& visitor) const override {
        PYBIND11_OVERRIDE_PURE_NAME(void, AdderBase, "__call__", operator(), first, second, visitor);
    }
};


196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
static void test_gil() {
    {
        py::gil_scoped_acquire lock;
        py::print("1st lock acquired");

    }

    {
        py::gil_scoped_acquire lock;
        py::print("2nd lock acquired");
    }

}

static void test_gil_from_thread() {
    py::gil_scoped_release release;

    std::thread t(test_gil);
    t.join();
}


218
219
// Forward declaration (so that we can put the main tests here; the inherited virtual approaches are
// rather long).
220
void initialize_inherited_virtuals(py::module_ &m);
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237

TEST_SUBMODULE(virtual_functions, m) {
    // test_override
    py::class_<ExampleVirt, PyExampleVirt>(m, "ExampleVirt")
        .def(py::init<int>())
        /* Reference original class in function definitions */
        .def("run", &ExampleVirt::run)
        .def("run_bool", &ExampleVirt::run_bool)
        .def("pure_virtual", &ExampleVirt::pure_virtual);

    py::class_<NonCopyable>(m, "NonCopyable")
        .def(py::init<int, int>());

    py::class_<Movable>(m, "Movable")
        .def(py::init<int, int>());

    // test_move_support
238
#if !defined(__INTEL_COMPILER) && !defined(__CUDACC__) && !defined(__PGIC__)
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
    py::class_<NCVirt, NCVirtTrampoline>(m, "NCVirt")
        .def(py::init<>())
        .def("get_noncopyable", &NCVirt::get_noncopyable)
        .def("get_movable", &NCVirt::get_movable)
        .def("print_nc", &NCVirt::print_nc)
        .def("print_movable", &NCVirt::print_movable);
#endif

    m.def("runExampleVirt", [](ExampleVirt *ex, int value) { return ex->run(value); });
    m.def("runExampleVirtBool", [](ExampleVirt* ex) { return ex->run_bool(); });
    m.def("runExampleVirtVirtual", [](ExampleVirt *ex) { ex->pure_virtual(); });

    m.def("cstats_debug", &ConstructorStats::get<ExampleVirt>);
    initialize_inherited_virtuals(m);

    // test_alias_delay_initialization1
    // don't invoke Python dispatch classes by default when instantiating C++ classes
    // that were not extended on the Python side
    struct A {
Henry Schreiner's avatar
Henry Schreiner committed
258
259
        A() = default;
        A(const A&) = delete;
260
        virtual ~A() = default;
261
262
263
264
265
        virtual void f() { py::print("A.f()"); }
    };

    struct PyA : A {
        PyA() { py::print("PyA.PyA()"); }
Henry Schreiner's avatar
Henry Schreiner committed
266
        PyA(const PyA&) = delete;
267
        ~PyA() override { py::print("PyA.~PyA()"); }
268
269
270

        void f() override {
            py::print("PyA.f()");
271
272
            // This convolution just gives a `void`, but tests that PYBIND11_TYPE() works to protect
            // a type containing a ,
273
            PYBIND11_OVERRIDE(PYBIND11_TYPE(typename std::enable_if<true, void>::type), A, f);
274
275
276
277
278
279
280
281
282
283
284
285
        }
    };

    py::class_<A, PyA>(m, "A")
        .def(py::init<>())
        .def("f", &A::f);

    m.def("call_f", [](A *a) { a->f(); });

    // test_alias_delay_initialization2
    // ... unless we explicitly request it, as in this example:
    struct A2 {
Henry Schreiner's avatar
Henry Schreiner committed
286
287
        A2() = default;
        A2(const A2&) = delete;
288
        virtual ~A2() = default;
289
290
291
292
293
        virtual void f() { py::print("A2.f()"); }
    };

    struct PyA2 : A2 {
        PyA2() { py::print("PyA2.PyA2()"); }
Henry Schreiner's avatar
Henry Schreiner committed
294
        PyA2(const PyA2&) = delete;
295
        ~PyA2() override { py::print("PyA2.~PyA2()"); }
296
297
        void f() override {
            py::print("PyA2.f()");
298
            PYBIND11_OVERRIDE(void, A2, f);
299
300
301
302
303
        }
    };

    py::class_<A2, PyA2>(m, "A2")
        .def(py::init_alias<>())
304
        .def(py::init([](int) { return new PyA2(); }))
305
306
307
308
309
310
311
312
313
314
315
316
        .def("f", &A2::f);

    m.def("call_f", [](A2 *a2) { a2->f(); });

    // test_dispatch_issue
    // #159: virtual function dispatch has problems with similar-named functions
    py::class_<Base, DispatchIssue>(m, "DispatchIssue")
        .def(py::init<>())
        .def("dispatch", &Base::dispatch);

    m.def("dispatch_issue_go", [](const Base * b) { return b->dispatch(); });

317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
    // test_recursive_dispatch_issue
    // #3357: Recursive dispatch fails to find python function override
    pybind11::class_<AdderBase, Adder>(m, "Adder")
        .def(pybind11::init<>())
        .def("__call__", &AdderBase::operator());

    pybind11::class_<AdderBase::Data>(m, "Data")
        .def(pybind11::init<>());

    m.def("add2", [](const AdderBase::Data& first, const AdderBase::Data& second,
                     const AdderBase& adder, const AdderBase::DataVisitor& visitor) {
        adder(first, second, visitor);
    });

    m.def("add3", [](const AdderBase::Data& first, const AdderBase::Data& second, const AdderBase::Data& third,
                     const AdderBase& adder, const AdderBase::DataVisitor& visitor) {
        adder(first, second, [&] (const AdderBase::Data& first_plus_second) {
            adder(first_plus_second, third, visitor);
        });
    });

338
    // test_override_ref
Unknown's avatar
Unknown committed
339
    // #392/397: overriding reference-returning functions
340
341
342
343
344
345
    class OverrideTest {
    public:
        struct A { std::string value = "hi"; };
        std::string v;
        A a;
        explicit OverrideTest(const std::string &v) : v{v} {}
Henry Schreiner's avatar
Henry Schreiner committed
346
347
        OverrideTest() = default;
        OverrideTest(const OverrideTest&) = delete;
348
349
350
351
        virtual std::string str_value() { return v; }
        virtual std::string &str_ref() { return v; }
        virtual A A_value() { return a; }
        virtual A &A_ref() { return a; }
352
        virtual ~OverrideTest() = default;
353
    };
354

355
356
357
    class PyOverrideTest : public OverrideTest {
    public:
        using OverrideTest::OverrideTest;
358
        std::string str_value() override { PYBIND11_OVERRIDE(std::string, OverrideTest, str_value); }
359
360
        // Not allowed (uncommenting should hit a static_assert failure): we can't get a reference
        // to a python numeric value, since we only copy values in the numeric type caster:
361
//      std::string &str_ref() override { PYBIND11_OVERRIDE(std::string &, OverrideTest, str_ref); }
362
363
364
        // But we can work around it like this:
    private:
        std::string _tmp;
365
        std::string str_ref_helper() { PYBIND11_OVERRIDE(std::string, OverrideTest, str_ref); }
366
367
368
    public:
        std::string &str_ref() override { return _tmp = str_ref_helper(); }

369
370
        A A_value() override { PYBIND11_OVERRIDE(A, OverrideTest, A_value); }
        A &A_ref() override { PYBIND11_OVERRIDE(A &, OverrideTest, A_ref); }
371
372
373
374
375
376
377
378
379
380
    };

    py::class_<OverrideTest::A>(m, "OverrideTest_A")
        .def_readwrite("value", &OverrideTest::A::value);
    py::class_<OverrideTest, PyOverrideTest>(m, "OverrideTest")
        .def(py::init<const std::string &>())
        .def("str_value", &OverrideTest::str_value)
//      .def("str_ref", &OverrideTest::str_ref)
        .def("A_value", &OverrideTest::A_value)
        .def("A_ref", &OverrideTest::A_ref);
381
382
}

383

384
385
// Inheriting virtual methods.  We do two versions here: the repeat-everything version and the
// templated trampoline versions mentioned in docs/advanced.rst.
386
//
387
388
389
// These base classes are exactly the same, but we technically need distinct
// classes for this example code because we need to be able to bind them
// properly (pybind11, sensibly, doesn't allow us to bind the same C++ class to
390
391
392
393
394
// multiple python classes).
class A_Repeat {
#define A_METHODS \
public: \
    virtual int unlucky_number() = 0; \
395
396
397
398
399
    virtual std::string say_something(unsigned times) { \
        std::string s = ""; \
        for (unsigned i = 0; i < times; ++i) \
            s += "hi"; \
        return s; \
400
401
402
    } \
    std::string say_everything() { \
        return say_something(1) + " " + std::to_string(unlucky_number()); \
403
404
    }
A_METHODS
Henry Schreiner's avatar
Henry Schreiner committed
405
406
    A_Repeat() = default;
    A_Repeat(const A_Repeat&) = delete;
407
    virtual ~A_Repeat() = default;
408
409
410
411
412
};
class B_Repeat : public A_Repeat {
#define B_METHODS \
public: \
    int unlucky_number() override { return 13; } \
413
414
    std::string say_something(unsigned times) override { \
        return "B says hi " + std::to_string(times) + " times"; \
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
    } \
    virtual double lucky_number() { return 7.0; }
B_METHODS
};
class C_Repeat : public B_Repeat {
#define C_METHODS \
public: \
    int unlucky_number() override { return 4444; } \
    double lucky_number() override { return 888; }
C_METHODS
};
class D_Repeat : public C_Repeat {
#define D_METHODS // Nothing overridden.
D_METHODS
};

// Base classes for templated inheritance trampolines.  Identical to the repeat-everything version:
Henry Schreiner's avatar
Henry Schreiner committed
432
433
434
435
436
437
class A_Tpl {
    A_METHODS;
    A_Tpl() = default;
    A_Tpl(const A_Tpl&) = delete;
    virtual ~A_Tpl() = default;
};
438
439
440
441
442
443
444
445
446
class B_Tpl : public A_Tpl { B_METHODS };
class C_Tpl : public B_Tpl { C_METHODS };
class D_Tpl : public C_Tpl { D_METHODS };


// Inheritance approach 1: each trampoline gets every virtual method (11 in total)
class PyA_Repeat : public A_Repeat {
public:
    using A_Repeat::A_Repeat;
447
448
    int unlucky_number() override { PYBIND11_OVERRIDE_PURE(int, A_Repeat, unlucky_number, ); }
    std::string say_something(unsigned times) override { PYBIND11_OVERRIDE(std::string, A_Repeat, say_something, times); }
449
450
451
452
};
class PyB_Repeat : public B_Repeat {
public:
    using B_Repeat::B_Repeat;
453
454
455
    int unlucky_number() override { PYBIND11_OVERRIDE(int, B_Repeat, unlucky_number, ); }
    std::string say_something(unsigned times) override { PYBIND11_OVERRIDE(std::string, B_Repeat, say_something, times); }
    double lucky_number() override { PYBIND11_OVERRIDE(double, B_Repeat, lucky_number, ); }
456
457
458
459
};
class PyC_Repeat : public C_Repeat {
public:
    using C_Repeat::C_Repeat;
460
461
462
    int unlucky_number() override { PYBIND11_OVERRIDE(int, C_Repeat, unlucky_number, ); }
    std::string say_something(unsigned times) override { PYBIND11_OVERRIDE(std::string, C_Repeat, say_something, times); }
    double lucky_number() override { PYBIND11_OVERRIDE(double, C_Repeat, lucky_number, ); }
463
464
465
466
};
class PyD_Repeat : public D_Repeat {
public:
    using D_Repeat::D_Repeat;
467
468
469
    int unlucky_number() override { PYBIND11_OVERRIDE(int, D_Repeat, unlucky_number, ); }
    std::string say_something(unsigned times) override { PYBIND11_OVERRIDE(std::string, D_Repeat, say_something, times); }
    double lucky_number() override { PYBIND11_OVERRIDE(double, D_Repeat, lucky_number, ); }
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
};

// Inheritance approach 2: templated trampoline classes.
//
// Advantages:
// - we have only 2 (template) class and 4 method declarations (one per virtual method, plus one for
//   any override of a pure virtual method), versus 4 classes and 6 methods (MI) or 4 classes and 11
//   methods (repeat).
// - Compared to MI, we also don't have to change the non-trampoline inheritance to virtual, and can
//   properly inherit constructors.
//
// Disadvantage:
// - the compiler must still generate and compile 14 different methods (more, even, than the 11
//   required for the repeat approach) instead of the 6 required for MI.  (If there was no pure
//   method (or no pure method override), the number would drop down to the same 11 as the repeat
//   approach).
template <class Base = A_Tpl>
class PyA_Tpl : public Base {
public:
    using Base::Base; // Inherit constructors
490
491
    int unlucky_number() override { PYBIND11_OVERRIDE_PURE(int, Base, unlucky_number, ); }
    std::string say_something(unsigned times) override { PYBIND11_OVERRIDE(std::string, Base, say_something, times); }
492
493
494
495
496
};
template <class Base = B_Tpl>
class PyB_Tpl : public PyA_Tpl<Base> {
public:
    using PyA_Tpl<Base>::PyA_Tpl; // Inherit constructors (via PyA_Tpl's inherited constructors)
497
    // NOLINTNEXTLINE(bugprone-parent-virtual-call)
498
499
    int unlucky_number() override { PYBIND11_OVERRIDE(int, Base, unlucky_number, ); }
    double lucky_number() override { PYBIND11_OVERRIDE(double, Base, lucky_number, ); }
500
501
502
503
504
505
506
507
508
509
510
511
512
513
};
// Since C_Tpl and D_Tpl don't declare any new virtual methods, we don't actually need these (we can
// use PyB_Tpl<C_Tpl> and PyB_Tpl<D_Tpl> for the trampoline classes instead):
/*
template <class Base = C_Tpl> class PyC_Tpl : public PyB_Tpl<Base> {
public:
    using PyB_Tpl<Base>::PyB_Tpl;
};
template <class Base = D_Tpl> class PyD_Tpl : public PyC_Tpl<Base> {
public:
    using PyC_Tpl<Base>::PyC_Tpl;
};
*/

514
void initialize_inherited_virtuals(py::module_ &m) {
515
516
    // test_inherited_virtuals

517
    // Method 1: repeat
518
    py::class_<A_Repeat, PyA_Repeat>(m, "A_Repeat")
519
520
        .def(py::init<>())
        .def("unlucky_number", &A_Repeat::unlucky_number)
521
522
        .def("say_something", &A_Repeat::say_something)
        .def("say_everything", &A_Repeat::say_everything);
523
    py::class_<B_Repeat, A_Repeat, PyB_Repeat>(m, "B_Repeat")
524
525
        .def(py::init<>())
        .def("lucky_number", &B_Repeat::lucky_number);
526
    py::class_<C_Repeat, B_Repeat, PyC_Repeat>(m, "C_Repeat")
527
        .def(py::init<>());
528
    py::class_<D_Repeat, C_Repeat, PyD_Repeat>(m, "D_Repeat")
529
530
        .def(py::init<>());

531
    // test_
532
    // Method 2: Templated trampolines
533
    py::class_<A_Tpl, PyA_Tpl<>>(m, "A_Tpl")
534
535
        .def(py::init<>())
        .def("unlucky_number", &A_Tpl::unlucky_number)
536
537
        .def("say_something", &A_Tpl::say_something)
        .def("say_everything", &A_Tpl::say_everything);
538
    py::class_<B_Tpl, A_Tpl, PyB_Tpl<>>(m, "B_Tpl")
539
540
        .def(py::init<>())
        .def("lucky_number", &B_Tpl::lucky_number);
541
    py::class_<C_Tpl, B_Tpl, PyB_Tpl<C_Tpl>>(m, "C_Tpl")
542
        .def(py::init<>());
543
    py::class_<D_Tpl, C_Tpl, PyB_Tpl<D_Tpl>>(m, "D_Tpl")
544
545
        .def(py::init<>());

546
547
548
549

    // Fix issue #1454 (crash when acquiring/releasing GIL on another thread in Python 2.7)
    m.def("test_gil", &test_gil);
    m.def("test_gil_from_thread", &test_gil_from_thread);
550
};