check-style.sh 2.47 KB
Newer Older
1
#!/bin/bash
2
#
3
# Script to check include/test code for common pybind11 code style errors.
4
#
Wenzel Jakob's avatar
Wenzel Jakob committed
5
6
7
# This script currently checks for
#
# 1. use of tabs instead of spaces
8
9
10
# 2. MSDOS-style CRLF endings
# 3. trailing spaces
# 4. missing space between keyword and parenthesis, e.g.: for(, if(, while(
Wenzel Jakob's avatar
Wenzel Jakob committed
11
# 5. Missing space between right parenthesis and brace, e.g. 'for (...){'
12
# 6. opening brace on its own line. It should always be on the same line as the
Unknown's avatar
Unknown committed
13
#    if/while/for/do statement.
14
#
15
16
17
# Invoke as: tools/check-style.sh
#

18
check_style_errors=0
19
IFS=$'\n'
Wenzel Jakob's avatar
Wenzel Jakob committed
20

21
22
23
24
25
26
27
found="$( GREP_COLORS='mt=41' GREP_COLOR='41' grep $'\t' include tests/*.{cpp,py,h} docs/*.rst -rn --color=always )"
if [ -n "$found" ]; then
    # The mt=41 sets a red background for matched tabs:
    echo -e '\033[31;01mError: found tab characters in the following files:\033[0m'
    check_style_errors=1
    echo "$found" | sed -e 's/^/    /'
fi
28
29


30
31
32
33
34
35
found="$( grep -IUlr $'\r' include tests/*.{cpp,py,h} docs/*.rst --color=always )"
if [ -n "$found" ]; then
    echo -e '\033[31;01mError: found CRLF characters in the following files:\033[0m'
    check_style_errors=1
    echo "$found" | sed -e 's/^/    /'
fi
36

37
38
39
40
41
42
43
found="$(GREP_COLORS='mt=41' GREP_COLOR='41' grep '[[:blank:]]\+$' include tests/*.{cpp,py,h} docs/*.rst -rn --color=always )"
if [ -n "$found" ]; then
    # The mt=41 sets a red background for matched trailing spaces
    echo -e '\033[31;01mError: found trailing spaces in the following files:\033[0m'
    check_style_errors=1
    echo "$found" | sed -e 's/^/    /'
fi
44

45
46
47
48
49
50
found="$(grep '\<\(if\|for\|while\|catch\)(\|){' include tests/*.{cpp,h} -rn --color=always)"
if [ -n "$found" ]; then
    echo -e '\033[31;01mError: found the following coding style problems:\033[0m'
    check_style_errors=1
    echo "$found" | sed -e 's/^/    /'
fi
51

52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
found="$(awk '
function prefix(filename, lineno) {
    return "    \033[35m" filename "\033[36m:\033[32m" lineno "\033[36m:\033[0m"
}
function mark(pattern, string) { sub(pattern, "\033[01;31m&\033[0m", string); return string }
last && /^\s*{/ {
    print prefix(FILENAME, FNR-1) mark("\\)\\s*$", last)
    print prefix(FILENAME, FNR)   mark("^\\s*{", $0)
    last=""
}
{ last = /(if|for|while|catch|switch)\s*\(.*\)\s*$/ ? $0 : "" }
' $(find include -type f) tests/*.{cpp,h} docs/*.rst)"
if [ -n "$found" ]; then
    check_style_errors=1
    echo -e '\033[31;01mError: braces should occur on the same line as the if/while/.. statement. Found issues in the following files:\033[0m'
    echo "$found"
fi
69

70
exit $check_style_errors