GitLab

Remove contiguous from simplify algebra passes for reshape op
Remove contiguous from fuse_pointwise for reshape op

This resolves an edge case found in multiple huggingface models  in some cases the find_split_reshape matcher will match with reshape2, but vec_rsp will consist of reshape1 dims causing a shape mismatch error. Solution is to include rsp when checking all reshapes are the same.

* add quant_dot fusion, clip literal opt

* Add trace for SIMPLIFY_ALGEBRA matches

* Fix format

* handle review comments from Umang

-int to size_t for trace
-move env arg to top of simplify_algebra.cpp
-handle overload beter for find_matches

* Rename trace_mod param to trace_pass

More representative naming for what this trace flag does

* Allow quantizing for both int8 and fp16

When multiplying either the input or output across the K dimensions then the multiple can be applied to the constant which can then be folded with propagate_const.

Improves the constant propagation for bert models. Larger batch size no longer use as large of constants.  Also improves the speed of model compilation 

This will replace conv(x+a, w) with conv(x, w) + conv(a, w) where a is a constant so conv(a, w) can be replaced with a constant.

Using add_instruction for the neg op was causing issues on replace_instruction. Changed to use insert_instruction.  Tests and added a new one that is failing without the change.

* Fuse layernorm with different patterns
* Only match when using the last axis
Co-authored-by: kahmed10 <15948690+kahmed10@users.noreply.github.com>
Co-authored-by: kahmed10 <15948690+kahmed10@users.noreply.github.com>

This PR resolves the bug addressed in #1496. 

Upgraded Dockerfiles and fixed tidy issues to make Ubuntu 20.04 and ROCm 5.3.0 the default 

Simplified algebraic operations (x*1), x*(-1), x/1, 0+x & x+0,  x-0, 0-x, 0*x, x*0, and 0/x operations

* Fix invalid program from find_splits

Change find_mul_conv to work with multibroadcast also. Checks the strides instead of the broadcast axis.

* fix slice_dim1 for case

Using not and or improves readability. The cppcheck rule will help ensure we are doing it consistently.

reshape op requires standard shape. During simplify_algebra, it inserts reshapes without checking for this requirement.

This will rewrite dot operators like X(Y + b) to XY + Xb when b is constant as we can fold the add away.
This improves handling pointwise with broadcasted operators, this helps improves const propagation.
Improve gemm fusion with a mul_add
Improve support for broadcast shapes in gemm

Updated each source file in the repo with the existing license.

Updated variable names according to #1193

Fuse layernorm and added triadd_layernorm fusion.  This is a prep performance booster

Fixes the #error when using cppcheck. This no longer suppresses cppcheck errors when including those errors. This fixes the cppcheck errors that was there already.

Update the base version of clang-format from 5.0 to 10.0

In migraphx, DepthToSpace (d2s) is implemented as reshape --> transpose --> contiguous --> reshape.

This PR adds matcher to find d2s + unary pointwise ops.

Application of the matcher moves the pointwise unary operation before the contiguous and reshape of the d2s.
So it becomes
reshape --> transpose --> unary --> contiguous --> reshape.

Motivation is that, later pointwise module would be created out of unary --> contiguous --> reshape. Codegen for this pointwise module can write out buffer such that explicit contiguous and reshape wouldn't be required.

This transformation is not always guaranteed to improve performance, since unary op will operate on non-standard shape. So, we would need some tuning mechanism to make decision.

#905 pending PR for binary operations.

Adds a pass to fuse pointwise operators into one "pointwsie" op that has a submodule which does the calculation.

* rename broadcast and multibroadcast output_lens attribute to out_lens attribute, and change tests and source code to reflect the same

* change the reshape attribute from dims to out_lens

* change transpose attribute's name from dims to perm to reflect better meaning

* use permutation instead of perm for transpose

clang formaating

* use dims instead of out_lens for reshape

clang formatting

* Enable libstdc++ debug mode

* Add is_end function

* Compare addresses in a map or set

* Formatting

* Check end

* Fix comparision of instruction_ref

* Formatting

* Some more iterator fixes

* Formatting

* Fix assert

* Fix invalid iterators

* Fix debug print in program

* Remove debug flag for now

* Set correct bool type
Co-authored-by: mvermeulen <5479696+mvermeulen@users.noreply.github.com>

* add the operator step

* clang formatJ

* add unit tests

* clang format

* add more unit test for step op

* clang format

* add more unit tests

* clang format

* fix review comments

* clang format

* rename two unit tests
Co-authored-by: Paul Fultz II <pfultz2@yahoo.com>

* backup implementation of resize enhancement

* clang format

* code backup for the resize

* clang format

* fix build error for resize operator

* clang format

* tmp code backup

* clang format

* remove changes in parse_resize

* remove unnecessary changes

* clang format

* add unit test for the bug

* clang format

* remove print code

* remove a semi-colon

* clang format

* fix a tidy error

* fix review comments

* clang format
Co-authored-by: Paul Fultz II <pfultz2@yahoo.com>
Co-authored-by: mvermeulen <5479696+mvermeulen@users.noreply.github.com>