"...serve/git@developer.sourcefind.cn:guobj/qwen_lmdeploy.git" did not exist on "6904053f1b40842a214a4704863c12ecc3957430"
Adjust HIP_COMPILER_FLAGS to support <$:$<>:> and SHELL: tags (#933) (#956)
In ROCm 4.5.0 hip compile flags are coming in differently. This has
caused some parsing issues for the HIP_COMPILER_FLAGS variable. As an example
ROCm 4.3.0: --offload-arch=gfx900
ROCm 4.5.0: <$<COMPILE_LANGUAGE:CXX>:SHELL:--offload-arch=gfx900>
Using existing code...
$<$<COMPILE_LANGUAGE:CXX>:SHELL:--offload-arch=gfx900>
Becomes...
$<$<COMPILE_LANGUAGE:CXX>:SHELL:
There are two problems with that.
1) The "<" is not balanced with a "> due to the regex consuming the ">"
2) There is still a `SHELL:` label.
This commit repairs both. I took the regex parsing code from ROCmSoftwarePlatform/MIOpen/blame/develop/CMakeLists.txt
but improved it to support handling of target features like
<$<COMPILE_LANGUAGE:CXX>:SHELL:--offload-arch=gfx900:xxx+>
Co-authored-by:
Paul Fultz II <pfultz2@yahoo.com>
Co-authored-by:
Paul Fultz II <pfultz2@yahoo.com>
Showing
Please register or sign in to comment