Tidy fixes

src/include/migraphx/pass_manager.hpp

@@ -21,8 +21,6 @@ struct module_pass_manager
     virtual ~module_pass_manager() {}
 };
 
-module& get_module(module_pass_manager& mpm);
-
 void run_passes(module& mod, const std::vector<pass>& passes, tracer trace = tracer{});
 void run_passes(program& prog, const std::vector<pass>& passes, tracer trace = tracer{});
 

src/targets/gpu/fuse_ops.cpp

@@ -812,15 +812,6 @@ inline auto precompile_name(std::string s) // NOLINT
     });
 }
 
-template <class... Ms>
-auto conv_bias_pointwise(Ms... ms)
-{
-    return precompile_name("pointwise")(
-        match::either_arg(0, 1)(bias_shape(match::used_once()).bind("bias"),
-                                fusable_conv(match::used_once()).bind("conv")),
-        ms...);
-}
-
 struct find_conv_bias
 {
     context* ctx = nullptr;

src/targets/gpu/include/migraphx/gpu/code_object_op.hpp

@@ -15,12 +15,12 @@ struct context;
 
 struct code_object_op
 {
-    value::binary code_object;
-    std::string symbol_name;
-    std::size_t global;
-    std::size_t local;
-    std::vector<shape> expected_inputs;
-    shape output;
+    value::binary code_object{};
+    std::string symbol_name = "";
+    std::size_t global = 0;
+    std::size_t local = 0;
+    std::vector<shape> expected_inputs{};
+    shape output{};
     std::int64_t output_arg = -1;
     kernel k{};
 

src/targets/gpu/include/migraphx/gpu/fuse_mlir.hpp

@@ -15,7 +15,7 @@ struct fuse_mlir
 {
     context* ctx = nullptr;
     std::string name() const { return "gpu::fuse_mlir"; }
-    void apply(module_pass_manager& m) const;
+    void apply(module_pass_manager& mpm) const;
 };
 
 } // namespace gpu

src/targets/gpu/jit/mlir.cpp

@@ -23,7 +23,7 @@ struct mlir_compiler : compiler<mlir_compiler>
 
     compiler_replace insert(code_object_op co) const
     {
-        return [=](module& m, instruction_ref ins) {
+        return [co=std::move(co)](module& m, instruction_ref ins) {
             auto mlir = insert_mlir(m, ins, co, ins->inputs());
             m.replace_instruction(ins, mlir);
         };

src/targets/gpu/mlir.cpp

@@ -495,7 +495,7 @@ struct mlir_program
         mlirMIGraphXAddBackendPipeline(pm.get(), hacked_tname.c_str(), "amdgcn-amd-amdhsa", "");
         mlirPassManagerRun(pm.get(), mmodule.get());
 
-        code_object_op op;
+        code_object_op op{};
         op.symbol_name                = "main";
         op.code_object                = get_binary();
         std::tie(op.global, op.local) = get_launch_params();
@@ -605,6 +605,7 @@ std::string dump_mlir(const module&) { return {}; }
 code_object_op compile_mlir(const context&, const module&) { return {}; }
 
 instruction_ref
+// cppcheck-suppress funcArgNamesDifferent
 insert_mlir(module& m, instruction_ref, code_object_op, const std::vector<instruction_ref>&)
 {
     return m.end();