Addressing review feedbacks

src/cpp_generator.cpp

@@ -177,10 +177,9 @@ std::string cpp_generator::generate_point_op(const operation& op,
             // For an optional argument where i >= args.size(), treat
             // the optional argument as a straight zero. This will
             // cacel out the optional bias, if it exists.
-            if(i < args.size())
-                return args.at(i);
-            else
-                return "0";
+            if(i >= args.size())
+                MIGRAPHX_THROW("Invalid argument index: " + key);
+            return args.at(i);
         }
         else if(v.contains(key))
         {

src/include/migraphx/op/dequantizelinear.hpp

@@ -39,8 +39,10 @@ struct dequantizelinear
 {
 
     value attributes() const {
-        return {{"pointwise", true}, {"point_op", 
-        "${1} * (${function:convert}<float>(${0}) - ${function:convert}<float>(${2}))"}};
+        // Note: point_op attribute is not used in this op. Instead, in
+        // gpu compilation pipeline, rewrite_quantization will be invoked
+        // from generate_pointwise() to rewrite this op.
+        return {{"pointwise", true}, {"point_op", ""}};
     }
 
     std::string name() const { return "dequantizelinear"; }

src/include/migraphx/op/quantizelinear.hpp

@@ -39,8 +39,12 @@ struct quantizelinear
 {
     std::string name() const { return "quantizelinear"; }
 
-    value attributes() const { return {{"pointwise", true}, {"point_op", 
-        "${function:max}(${function:min}(${function:round}(${function:convert}<float>(${0}) / ${1}) + ${function:convert}<float>(${2}), 127.0), -128.0)"}}; }
+    value attributes() const {
+        // Note: point_op attribute is not used in this op. Instead, in
+        // gpu compilation pipeline, rewrite_quantization will be invoked
+        // from generate_pointwise() to rewrite this op.
+        return {{"pointwise", true}, {"point_op", ""}};
+    }
 
     shape compute_shape(std::vector<shape> inputs) const
     {

src/targets/gpu/compile_gen.cpp

@@ -29,6 +29,7 @@
 #include <migraphx/module.hpp>
 #include <migraphx/dead_code_elimination.hpp>
 #include <migraphx/eliminate_common_subexpression.hpp>
+#include <migraphx/rewrite_quantization.hpp>
 #include <migraphx/cpp_generator.hpp>
 #include <migraphx/pass_manager.hpp>
 #include <migraphx/instruction.hpp>
@@ -171,7 +172,8 @@ std::string make_transformer_args(std::vector<std::string> transformers)
 void generate_pointwise(cpp_generator& gg, const module& pm, const std::string& name)
 {
     module m = pm;
-    run_passes(m, {eliminate_common_subexpression{}, dead_code_elimination{}});
+    run_passes(m,
+               {rewrite_quantization{}, eliminate_common_subexpression{}, dead_code_elimination{}});
     cpp_generator g;
     g.fmap([](const std::string& fname) { return "migraphx::" + fname; });
     g.add_point_op("where", "${function:where}(${0}, ${1}, ${2})");