Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
gaoqiong
MIGraphX
Commits
d2c25a07
Commit
d2c25a07
authored
Nov 17, 2023
by
Umang Yadav
Browse files
Remove FP8_Lowest/Max
parent
3411649c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
14 deletions
+3
-14
src/targets/gpu/kernels/include/migraphx/kernels/float8.hpp
src/targets/gpu/kernels/include/migraphx/kernels/float8.hpp
+0
-12
src/targets/gpu/kernels/include/migraphx/kernels/type_traits.hpp
...gets/gpu/kernels/include/migraphx/kernels/type_traits.hpp
+3
-2
No files found.
src/targets/gpu/kernels/include/migraphx/kernels/float8.hpp
View file @
d2c25a07
...
...
@@ -373,18 +373,6 @@ inline MIGRAPHX_HIP_DEVICE fp8e5m2 fabs(fp8e5m2 v)
return
v
;
}
template
<
class
T
>
MIGRAPHX_HIP_DEVICE
constexpr
T
F8_Max
()
{
return
T
{
0x7F
,
T
::
from_bits
()};
}
template
<
class
T
>
MIGRAPHX_HIP_DEVICE
constexpr
T
F8_Lowest
()
{
return
T
{
0xFF
,
T
::
from_bits
()};
}
template
<
>
class
numeric_limits
<
fp8e4m3fnuz
>
{
...
...
src/targets/gpu/kernels/include/migraphx/kernels/type_traits.hpp
View file @
d2c25a07
...
...
@@ -248,8 +248,9 @@ constexpr T numeric_max()
return
__FLT_MAX__
;
else
if
constexpr
(
is_same
<
T
,
migraphx
::
half
>
{})
return
__FLT16_MAX__
;
// TODO: Do it generically for all fp8 types
else
if
constexpr
(
is_same
<
T
,
migraphx
::
fp8
::
fp8e4m3fnuz
>
{})
return
migraphx
::
fp8
::
F8_Max
<
T
>
();
return
migraphx
::
fp8
::
numeric_limits
<
T
>::
max
();
else
return
0
;
}
...
...
@@ -265,7 +266,7 @@ constexpr T numeric_lowest()
return
-
numeric_max
<
T
>
()
-
1
;
}
else
if
constexpr
(
is_same
<
T
,
migraphx
::
fp8
::
fp8e4m3fnuz
>
{})
return
migraphx
::
fp8
::
F8_L
owest
<
T
>
();
return
migraphx
::
fp8
::
numeric_limits
<
T
>::
l
owest
();
else
{
return
-
numeric_max
<
T
>
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment