fix tidy cppcheck

src/include/migraphx/tracer.hpp

@@ -26,21 +26,23 @@ struct tracer
         }
         fs::create_directories(dir_path);
     }
-    // file_stream
+    // file_stream 
     bool fs_enabled() const { return !dump_dir.empty() && !os_enabled(); }
-    // output_stream
-    bool os_enabled() const { return os && !fs_enabled(); }
-    bool enabled() const { return fs_enabled() or os_enabled(); };
+    // output_stream 
+    bool os_enabled() const { return (os != nullptr) && !fs_enabled();}
+    bool enabled() const {return fs_enabled() or os_enabled();};
 
     /*
-    Dump any string to ostream, used for debug build or debugging purposes.
+    Dump any string to ostream, used for debug build or debugging purposes. 
     */
-    void operator()(const std::string& s = "") const { std::cout << s << std::endl; }
+    void operator()(const std::string& s="") const {
+        std::cout << s << std::endl; 
+    }
 
     /*
-    Based on user's envrionment flags, either dump IR passes' output to a file or ostream i.e. cout
-    or cerr, :param pass_file_name : file_name to be used when dumping IR pass to a file, this param
-    is not used when IR is dumped to ostream.
+    Based on user's envrionment flags, either dump IR passes' output to a file or ostream i.e. cout or cerr, 
+    :param pass_file_name : file_name to be used when dumping IR pass to a file, this param is not used when IR is 
+                            dumped to ostream. 
     */
     template <class... Ts, MIGRAPHX_REQUIRES((sizeof...(Ts) > 0))>
     void operator()(const std::string& pass_file_name, const Ts&... xs)
@@ -53,9 +55,7 @@ struct tracer
             swallow{ofs << xs...};
             ofs << std::endl;
             ofs.close();
-        }
-        else if(os_enabled())
-        {
+        } else if (os_enabled()) {
             swallow{*os << xs...};
             *os << std::endl;
         }
@@ -64,8 +64,8 @@ struct tracer
     std::string dump_dir = "";
 
     private:
-    uint counter      = 0;
-    std::ostream* os  = nullptr;
+    uint counter = 0;
+    std::ostream* os = nullptr;
     fs::path dir_path = "";
 };
 

src/pass_manager.cpp

@@ -18,7 +18,7 @@ inline namespace MIGRAPHX_INLINE_NS {
 
 MIGRAPHX_DECLARE_ENV_VAR(MIGRAPHX_TRACE_PASSES);
 
-void validate_pass(module& mod, const pass& p, tracer trace)
+void validate_pass(module& mod, const pass& p, const tracer& trace)
 {
     (void)mod;
     (void)p;
@@ -129,9 +129,9 @@ void run_passes(program& prog, const std::vector<pass>& passes, tracer trace)
             // the individual passes' file dumps.
             if(module_tracer_map.find(mod->name()) == module_tracer_map.end())
             {
-                // cppcheck-suppress stlFindInsert
                 module_tracer_map[mod->name()] =
-                    trace.fs_enabled() ? tracer{trace.dump_dir + "/" + mod->name()} : trace;
+                    // cppcheck-suppress stlFindInsert
+                    trace.fs_enabled() ? tracer{trace.dump_dir + "/" + mod->name()} : trace; 
             }
             if(mod->bypass())
                 continue;