Commit c4ee1296 authored by Shucai Xiao's avatar Shucai Xiao
Browse files

fixed review comments.

parent cd045c48
...@@ -127,7 +127,7 @@ struct program ...@@ -127,7 +127,7 @@ struct program
friend bool operator!=(const program& x, const program& y) { return !(x == y); } friend bool operator!=(const program& x, const program& y) { return !(x == y); }
private: private:
void copy(const program& p); void assign(const program& p);
private: private:
std::unique_ptr<program_impl> impl; std::unique_ptr<program_impl> impl;
......
...@@ -89,7 +89,7 @@ program::program(program&&) noexcept = default; ...@@ -89,7 +89,7 @@ program::program(program&&) noexcept = default;
program::~program() noexcept = default; program::~program() noexcept = default;
// copy constructor // copy constructor
program::program(const program& p) { copy(p); } program::program(const program& p) { assign(p); }
// copy assignment operator // copy assignment operator
program& program::operator=(program p) program& program::operator=(program p)
...@@ -98,7 +98,7 @@ program& program::operator=(program p) ...@@ -98,7 +98,7 @@ program& program::operator=(program p)
return *this; return *this;
} }
void program::copy(const program& p) void program::assign(const program& p)
{ {
// clean the current program // clean the current program
if(!impl) if(!impl)
...@@ -107,7 +107,7 @@ void program::copy(const program& p) ...@@ -107,7 +107,7 @@ void program::copy(const program& p)
} }
else if(!impl->instructions.empty()) else if(!impl->instructions.empty())
{ {
remove_instructions(begin(), end()); impl->instructions.clear();
} }
impl->ctx = p.impl->ctx; impl->ctx = p.impl->ctx;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment