Fix tidy

src/generate_root_modules.cpp

@@ -166,13 +166,9 @@ struct auto_gen_root_modules
             return false;
         }
         return std::any_of(inputs.begin(), inputs.end(), [&](auto input_ins) {
-            if((skip_ins.find(input_ins) != skip_ins.end()) or
-               (tass.find(input_ins) != tass.end() and
-                tass.at(ins) != tid.value_or(std::numeric_limits<std::size_t>::max())))
-            {
-                return true;
-            }
-            return false;
+            return ((skip_ins.find(input_ins) != skip_ins.end()) or
+                    (tass.find(input_ins) != tass.end() and
+                     tass.at(ins) != tid.value_or(std::numeric_limits<std::size_t>::max())));
         });
     }
 
@@ -184,13 +180,9 @@ struct auto_gen_root_modules
             return false;
         }
         return std::any_of(outputs.begin(), outputs.end(), [&](auto output_ins) {
-            if(tass.find(output_ins) != tass.end() and
-               tass.at(output_ins) != tid.value_or(std::numeric_limits<std::size_t>::max()) and
-               output_ins->name() != "@return")
-            {
-                return true;
-            }
-            return false;
+            return (tass.find(output_ins) != tass.end() and
+                    tass.at(output_ins) != tid.value_or(std::numeric_limits<std::size_t>::max()) and
+                    output_ins->name() != "@return");
         });
     }
 

src/targets/gpu/compile_hip.cpp

@@ -194,7 +194,7 @@ struct hiprtc_program
 };
 
 std::vector<std::vector<char>> compile_hip_src_with_hiprtc(std::vector<hiprtc_src_file> srcs,
-                                                           std::string params,
+                                                           const std::string& params,
                                                            const std::string& arch)
 {
     hiprtc_program prog(std::move(srcs));
@@ -276,7 +276,7 @@ compile_hip_src(const std::vector<src_file>& srcs, std::string params, const std
 #else // MIGRAPHX_USE_HIPRTC
 
 std::vector<std::vector<char>> compile_hip_src_with_hiprtc(std::vector<hiprtc_src_file>, // NOLINT
-                                                           std::string,                  // NOLINT
+                                                           const std::string&,           // NOLINT
                                                            const std::string&)
 {
     MIGRAPHX_THROW("Not using hiprtc");

src/targets/gpu/include/migraphx/gpu/compile_hip.hpp

@@ -58,7 +58,7 @@ struct hiprtc_src_file
 MIGRAPHX_GPU_EXPORT bool hip_has_flags(const std::vector<std::string>& flags);
 
 MIGRAPHX_GPU_EXPORT std::vector<std::vector<char>> compile_hip_src_with_hiprtc(
-    std::vector<hiprtc_src_file> srcs, std::string params, const std::string& arch);
+    std::vector<hiprtc_src_file> srcs, const std::string& params, const std::string& arch);
 
 MIGRAPHX_GPU_EXPORT std::vector<std::vector<char>>
 compile_hip_src(const std::vector<src_file>& srcs, std::string params, const std::string& arch);

test/generate_root_modules.cpp

@@ -608,7 +608,7 @@ TEST_CASE(nested_if_then_else_program)
         auto z                  = mm->add_parameter("z", ds);
         auto create_test_module = [&](migraphx::program& prog,
                                       std::size_t tid,
-                                      std::string param_prefix) {
+                                      const std::string& param_prefix) {
             std::string mod_name =
                 "target_" + std::to_string(tid) + "_" + std::to_string(counter_map[tid]++);
             auto* test_mod        = prog.create_module(mod_name);