staging

src/include/migraph/target.hpp

@@ -125,7 +125,7 @@ struct target
     context get_context(parameter_map params = parameter_map()) const
     {
         assert((*this).private_detail_te_handle_mem_var);
-        return (*this).private_detail_te_get_handle().get_context(params);
+        return (*this).private_detail_te_get_handle().get_context(std::move(params));
     }
 
     private:
@@ -137,7 +137,7 @@ struct target
 
         virtual std::string name() const                         = 0;
         virtual std::vector<pass> get_passes(context& ctx) const = 0;
-        virtual context get_context(parameter_map params = parameter_map()) const                      = 0;
+        virtual context get_context(parameter_map params) const                      = 0;
     };
 
     template <typename PrivateDetailTypeErasedT>
@@ -176,7 +176,7 @@ struct target
             return private_detail_te_value.get_passes(ctx);
         }
 
-        context get_context(parameter_map params = parameter_map()) const override { return private_detail_te_value.get_context(params); }
+        context get_context(parameter_map params) const override { return private_detail_te_value.get_context(params); }
 
         PrivateDetailTypeErasedT private_detail_te_value;
     };

src/opt/memory_coloring_impl.cpp

@@ -223,7 +223,7 @@ void memory_coloring_impl::rewrite()
             else if(is_literal(ins))
             {
                 auto pre   = p_program->add_literal(ins->lit);
-                bool pre_copy = (interval->get_begin() < earliest_end_point) ? true : false;
+                bool pre_copy = (interval->get_begin() < earliest_end_point);
                 p_program->replace_instruction(ins, write_literal{offset, pre_copy}, scratch_param, pre);
             }
         }
@@ -236,7 +236,7 @@ void memory_coloring_impl::rewrite()
 // map liveness tracking point to instruction enum.    
 #define GET_INS_ENUM(x) (((x) > 0) ? (((x) >> 1) - 1) : InvalidOffset)
     
-void memory_coloring_impl::dump(const std::string str) { std::cout << str << std::endl; }
+void memory_coloring_impl::dump(const std::string& str) { std::cout << str << std::endl; }
 
 void memory_coloring_impl::dump_program() { std::cout << *p_program << std::endl; }
 

src/opt/memory_coloring_impl.hpp

@@ -119,7 +119,7 @@ struct memory_coloring_impl
         long long end2 = range2.offset + range2.size - 1;
         return ((end1 < range2.offset) || (end2 < range1.offset));
     }
-    void dump(const std::string);
+    void dump(const std::string&);
     void dump_program();
     void dump_intervals();
     void verify();