Merge branch 'develop' into stream_execution_checkin

src/onnx/onnx.cpp

@@ -157,7 +157,7 @@ struct onnx_parser
     template <class T>
     instruction_ref add_broadcastable_binary_op(instruction_ref arg0, instruction_ref arg1, T x)
     {
-        if(arg0->get_shape() != arg1->get_shape())
+        if(arg0->get_shape().lens() != arg1->get_shape().lens())
         {
             // Example:
             // s0 = (3,2,4,5) and s1 = (2,1,1)
@@ -638,6 +638,11 @@ struct onnx_parser
             auto&& pad_vals = attributes["pads"].ints();
             pads            = std::vector<int64_t>(pad_vals.begin(), pad_vals.end());
         }
+        // check if padding is actually being done (at least one value is nonzero)
+        if(std::all_of(pads.begin(), pads.end(), [](const int& i) { return i == 0; }))
+        {
+            return prog.add_instruction(migraphx::op::identity{}, args.front());
+        }
         if(contains(attributes, "value"))
         {
             value = parse_value(attributes.at("value")).at<float>();

src/tf/tf.cpp

@@ -167,7 +167,7 @@ struct tf_parser
     template <class T>
     instruction_ref add_broadcastable_binary_op(instruction_ref arg0, instruction_ref arg1, T x)
     {
-        if(arg0->get_shape() != arg1->get_shape())
+        if(arg0->get_shape().lens() != arg1->get_shape().lens())
         {
             // Example:
             // s0 = (3,2,4,5) and s1 = (2,1,1)

test/onnx/onnx_test.cpp

@@ -683,4 +683,14 @@ TEST_CASE(logsoftmax)
     EXPECT(p == prog);
 }
 
+TEST_CASE(no_pad_test)
+{
+    migraphx::program p;
+    auto l0 = p.add_parameter("0", migraphx::shape{migraphx::shape::float_type, {2, 2}});
+    p.add_instruction(migraphx::op::identity{}, l0);
+    auto prog = migraphx::parse_onnx("no_pad_test.onnx");
+
+    EXPECT(p == prog);
+}
+
 int main(int argc, const char* argv[]) { test::run(argc, argv); }