Fix warnings and tidy checks

CMakeLists.txt

@@ -53,6 +53,8 @@ rocm_enable_clang_tidy(
         -hicpp-no-array-decay
         -hicpp-special-member-functions
         -hicpp-use-override
+        # This check is broken
+        -hicpp-use-auto
         -llvm-header-guard
         -llvm-include-order
         -misc-macro-parentheses

src/include/rtg/manage_ptr.hpp

@@ -27,7 +27,7 @@ struct null_deleter
     }
 };
 
-template <class T, class F, F f>
+template <class T, class F, F f> // NOLINT
 using manage_ptr = std::unique_ptr<T, manage_deleter<F, f>>;
 
 template <class T>

src/targets/cpu/cpu_target.cpp

@@ -17,8 +17,6 @@ struct cpu_convolution
     {
         argument result{output_shape};
         visit_all(result, args[0], args[1])([&](auto output, auto input, auto weights) {
-            auto in_n = input.get_shape().lens()[0];
-            auto in_c = input.get_shape().lens()[1];
             auto in_h = input.get_shape().lens()[2];
             auto in_w = input.get_shape().lens()[3];
 

src/targets/miopen/miopen_target.cpp

@@ -33,7 +33,7 @@ struct hip_free
         check_shapes{inputs}.has(1);
         return {};
     }
-    argument compute(shape output_shape, std::vector<argument> args) const
+    argument compute(shape, std::vector<argument> args) const
     {
         // TODO: Check return status
         hipFree(args.front().data());
@@ -176,8 +176,8 @@ struct miopen_relu
 
 struct miopen_apply
 {
-    program* prog;
-    instruction_ref handle;
+    program* prog = nullptr;
+    instruction_ref handle{};
 
     void apply()
     {

test/miopen.cpp

@@ -116,8 +116,9 @@ void test1()
 {
     auto x = cpu();
     auto y = gpu();
+    // TODO: Use expect
     if(x == y)
-        printf("FAILED\n");
+        std::cout << "FAILED" << std::endl;
 }
 
 int main() { test1(); }