fixed review comments.

src/quantization.cpp

@@ -23,18 +23,7 @@ instruction_ref insert_fp16(program& prog,
     assert(ins->get_shape().type() == shape::float_type ||
            ins->get_shape().type() == shape::double_type);
     instruction_ref ins_fp16{};
-    if(ins->name() == "@literal" && ins->outputs().size() == 1)
-    {
-        auto l = ins->get_literal();
-        auto s = ins->get_shape();
-        l.visit([&](auto val) {
-            ins_fp16 = prog.add_literal(literal({type, s.lens()}, val.begin(), val.end()));
-        });
-    }
-    else
-    {
-        ins_fp16 = prog.insert_instruction(std::next(ins), op::convert{type}, ins);
-    }
+    ins_fp16 = prog.insert_instruction(std::next(ins), op::convert{type}, ins);
     map_fp16[ins] = ins_fp16;
 
     return ins_fp16;

src/targets/gpu/include/migraphx/gpu/convert.hpp

@@ -16,8 +16,7 @@ struct hip_convert : unary_device<hip_convert, device::convert>
 {
     op::convert op;
 
-    hip_convert(const op::convert& oper) : op(oper) {}
-    hip_convert(const op::convert&& oper) : op(oper) {}
+    hip_convert(const op::convert oper) : op(std::move(oper)) {}
 
     shape compute_shape(std::vector<shape> inputs) const
     {

test/gpu/miopen.cpp

@@ -3333,37 +3333,37 @@ struct test_logsoftmax_1 : verify_program<test_logsoftmax_1<Axis>>
 template struct test_logsoftmax_1<0>;
 template struct test_logsoftmax_1<1>;
 
-// struct test_fp32_fp16_lall : verify_program<test_fp32_fp16_lall>
-// {
-//     migraphx::program create_program() const
-//     {
-//         migraphx::program p;
-//         migraphx::shape s{migraphx::shape::float_type, {2, 3}};
-//         std::vector<float> data(2 * 3);
-//         std::iota(data.begin(), data.end(), 1.0f);
-//         auto l1 = p.add_literal(migraphx::literal(s, data));
-//         auto l2 = p.add_literal(migraphx::literal(s, data));
-//         p.add_instruction(migraphx::op::add{}, l1, l2);
-//         //migraphx::quantize(p, {"all"});
-//         return p;
-//     };
-// };
-
-// struct test_fp32_fp16_ladd : verify_program<test_fp32_fp16_ladd>
-// {
-//     migraphx::program create_program() const
-//     {
-//         migraphx::program p;
-//         migraphx::shape s{migraphx::shape::float_type, {2, 3}};
-//         std::vector<float> data(2 * 3);
-//         std::iota(data.begin(), data.end(), 1.0f);
-//         auto l1 = p.add_literal(migraphx::literal(s, data));
-//         auto l2 = p.add_literal(migraphx::literal(s, data));
-//         p.add_instruction(migraphx::op::add{}, l1, l2);
-//         migraphx::quantize(p, {"all"});
-//         return p;
-//     };
-// };
+struct test_fp32_fp16_lall : verify_program<test_fp32_fp16_lall>
+{
+    migraphx::program create_program() const
+    {
+        migraphx::program p;
+        migraphx::shape s{migraphx::shape::float_type, {2, 3}};
+        std::vector<float> data(2 * 3);
+        std::iota(data.begin(), data.end(), 1.0f);
+        auto l1 = p.add_literal(migraphx::literal(s, data));
+        auto l2 = p.add_parameter("p2", s);
+        p.add_instruction(migraphx::op::add{}, l1, l2);
+        migraphx::quantize(p, {"all"});
+        return p;
+    };
+};
+
+struct test_fp32_fp16_ladd : verify_program<test_fp32_fp16_ladd>
+{
+    migraphx::program create_program() const
+    {
+        migraphx::program p;
+        migraphx::shape s{migraphx::shape::float_type, {2, 3}};
+        std::vector<float> data(2 * 3);
+        std::iota(data.begin(), data.end(), 1.0f);
+        auto l1 = p.add_literal(migraphx::literal(s, data));
+        auto l2 = p.add_parameter("p2", s);
+        p.add_instruction(migraphx::op::add{}, l1, l2);
+        migraphx::quantize(p, {"add"});
+        return p;
+    };
+};
 
 struct test_fp32_fp16_add : verify_program<test_fp32_fp16_add>
 {

test/type_conversion.cpp

@@ -7,6 +7,7 @@
 #include <migraphx/verify.hpp>
 #include <migraphx/quantization.hpp>
 #include <migraphx/dead_code_elimination.hpp>
+#include <migraphx/propagate_constant.hpp>
 #include <migraphx/pass_manager.hpp>
 #include <migraphx/onnx.hpp>
 #include "test.hpp"
@@ -180,7 +181,8 @@ TEST_CASE(literal_add)
         auto p2 = create_program_half();
 
         migraphx::quantize(p1, {"all"});
-        migraphx::run_passes(p1, {migraphx::dead_code_elimination{}});
+        migraphx::run_passes(p1, {migraphx::propagate_constant{}, migraphx::dead_code_elimination{}});
+        migraphx::run_passes(p2, {migraphx::propagate_constant{}, migraphx::dead_code_elimination{}});
 
         EXPECT(p1 == p2);
     }
@@ -190,7 +192,8 @@ TEST_CASE(literal_add)
         auto p2 = create_program_half();
 
         migraphx::quantize(p1, {"add"});
-        migraphx::run_passes(p1, {migraphx::dead_code_elimination{}});
+        migraphx::run_passes(p1, {migraphx::propagate_constant{}, migraphx::dead_code_elimination{}});
+        migraphx::run_passes(p2, {migraphx::propagate_constant{}, migraphx::dead_code_elimination{}});
         EXPECT(p1 == p2);
     }
 }