Rename verify_args

src/driver/verify.cpp

@@ -84,7 +84,7 @@ void verify_program(const std::string& name,
     std::size_t output_num = ref_outs.size();
     for(std::size_t i = 0; i < output_num; ++i)
     {
-        verify_args_with_threshold(name, target_outs[i], verify::expected{ref_outs[i]}, tols);
+        verify_args(name, target_outs[i], verify::expected{ref_outs[i]}, tols);
     }
 }
 

src/include/migraphx/verify_args.hpp

@@ -31,15 +31,15 @@
 namespace migraphx {
 inline namespace MIGRAPHX_INLINE_NS {
 
-MIGRAPHX_EXPORT bool verify_args_with_threshold(const std::string& name,
-                                                const argument& target_arg,
-                                                const verify::expected<argument>& ref_arg,
-                                                verify::tolerance);
-
 MIGRAPHX_EXPORT bool verify_args(const std::string& name,
                                  const argument& target_arg,
                                  const verify::expected<argument>& ref_arg,
-                                 std::size_t tolerance = 80);
+                                 verify::tolerance);
+
+MIGRAPHX_EXPORT bool verify_args_with_tolerance(const std::string& name,
+                                                const argument& target_arg,
+                                                const verify::expected<argument>& ref_arg,
+                                                std::size_t tolerance = 80);
 
 } // namespace MIGRAPHX_INLINE_NS
 } // namespace migraphx

src/verify_args.cpp

@@ -27,10 +27,10 @@
 namespace migraphx {
 inline namespace MIGRAPHX_INLINE_NS {
 
-bool verify_args_with_threshold(const std::string& name,
-                                const argument& target_arg,
-                                const verify::expected<argument>& ref_arg,
-                                verify::tolerance tols)
+bool verify_args(const std::string& name,
+                 const argument& target_arg,
+                 const verify::expected<argument>& ref_arg,
+                 verify::tolerance tols)
 {
     bool passed = true;
     visit_all(ref_arg.data(), target_arg)([&](auto ref, auto target) {
@@ -94,15 +94,15 @@ bool verify_args_with_threshold(const std::string& name,
     return passed;
 }
 
-bool verify_args(const std::string& name,
-                 const argument& target_arg,
-                 const verify::expected<argument>& ref_arg,
-                 std::size_t tolerance)
+bool verify_args_with_tolerance(const std::string& name,
+                                const argument& target_arg,
+                                const verify::expected<argument>& ref_arg,
+                                std::size_t tolerance)
 {
     double rms_tol = 0.001;
     target_arg.visit([&](auto ta) { rms_tol = verify::get_rms_tol(ta, tolerance); });
     verify::tolerance tols{rms_tol};
-    return verify_args_with_threshold(name, target_arg, ref_arg, tols);
+    return verify_args(name, target_arg, ref_arg, tols);
 }
 
 } // namespace MIGRAPHX_INLINE_NS

test/gpu/mlir.cpp

@@ -133,7 +133,7 @@ bool verify_mlir(const migraphx::module& mmlir)
     auto inputs = generate_params(ref);
 
     auto mlir = create_program_from_mlir(mmlir);
-    return migraphx::verify_args(
+    return migraphx::verify_args_with_tolerance(
         "mlir", run_gpu(mlir, inputs), migraphx::verify::expected{run_ref(ref, inputs)});
 }
 

test/verify/run_verify.cpp

@@ -252,7 +252,7 @@ void run_verify::verify(const std::string& name,
             for(std::size_t i = 0; ((i < num) and passed); ++i)
             {
                 passed &=
-                    migraphx::verify_args(tname, result[i], migraphx::verify::expected{gold[i]});
+                    migraphx::verify_args_with_tolerance(tname, result[i], migraphx::verify::expected{gold[i]});
             }
 
             if(not passed or migraphx::enabled(MIGRAPHX_TRACE_TEST{}))