fix review comments

27e34ff2 · Shucai Xiao · 5fb6c7db · 27e34ff2 · 27e34ff2
Commit 27e34ff2 authored Jul 01, 2019 by Shucai Xiao
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

src/include/migraphx/op/argmax.hpp src/include/migraphx/op/argmax.hpp +3 -2

src/include/migraphx/op/argmin.hpp src/include/migraphx/op/argmin.hpp +3 -2

No files found.
--- a/src/include/migraphx/op/argmax.hpp
+++ b/src/include/migraphx/op/argmax.hpp
@@ -45,9 +45,10 @@ struct argmax
        for(std::size_t i = 1; i < item_num; ++i)
        {
            indices[axis] = i;
-            if(max_val < input(indices.begin(), indices.end()))
+            auto cur_val = input(indices.begin(), indices.end());
+            if(max_val < cur_val)
            {
-                max_val   = input(indices.begin(), indices.end());
+                max_val   = cur_val;
                max_index = i;
            }
        }

--- a/src/include/migraphx/op/argmin.hpp
+++ b/src/include/migraphx/op/argmin.hpp
@@ -50,9 +50,10 @@ struct argmin
        for(std::size_t i = 1; i < item_num; ++i)
        {
            indices[axis] = i;
-            if(min_val > input(indices.begin(), indices.end()))
+            auto cur_val = input(indices.begin(), indices.end());
+            if(min_val > cur_val)
            {
-                min_val   = input(indices.begin(), indices.end());
+                min_val   = cur_val;
                min_index = i;
            }
        }