Commit 0ef0d0bb authored by charlie's avatar charlie
Browse files

fixes

parent b72ad090
...@@ -169,7 +169,7 @@ insert_common_args(module& m, instruction_ref ins, std::vector<instruction_ref> ...@@ -169,7 +169,7 @@ insert_common_args(module& m, instruction_ref ins, std::vector<instruction_ref>
auto c_dyn_dims = compute_common_dyn_dims(input_shapes); auto c_dyn_dims = compute_common_dyn_dims(input_shapes);
auto s0 = inputs[0]->get_shape(); auto s0 = inputs[0]->get_shape();
// changed to always add the multibroadcast to handle the cases from split_single_dyn_dim // always add both multibroadcast instructions for dynamic shapes
inputs[0] = m.insert_instruction( inputs[0] = m.insert_instruction(
ins, make_op("multibroadcast", {{"out_dyn_dims", to_value(c_dyn_dims)}}), inputs); ins, make_op("multibroadcast", {{"out_dyn_dims", to_value(c_dyn_dims)}}), inputs);
std::transform(inputs.begin() + 1, inputs.end(), inputs.begin() + 1, [&](auto input) { std::transform(inputs.begin() + 1, inputs.end(), inputs.begin() + 1, [&](auto input) {
......
...@@ -73,8 +73,8 @@ struct dot ...@@ -73,8 +73,8 @@ struct dot
} }
std::size_t dim_0 = s0.ndim() - 2; std::size_t dim_0 = s0.ndim() - 2;
std::size_t dim_1 = s0.ndim() - 1; std::size_t dim_1 = s0.ndim() - 1;
auto x = s0.dyn_dims()[dim_1]; auto x = s0.dyn_dims()[dim_1];
auto y = s1.dyn_dims()[dim_0]; auto y = s1.dyn_dims()[dim_0];
if(not dd_within_range(x, y) and not dd_within_range(y, x)) if(not dd_within_range(x, y) and not dd_within_range(y, x))
{ {
MIGRAPHX_THROW("DOT: dynamic inner dimensions do not match: {" + MIGRAPHX_THROW("DOT: dynamic inner dimensions do not match: {" +
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment