Unverified Commit 144a1e58 authored by Baber Abbasi's avatar Baber Abbasi Committed by GitHub
Browse files

fix early return for multuple dict (#2673)

parent 0bb8406f
...@@ -1621,13 +1621,13 @@ class ConfigurableTask(Task): ...@@ -1621,13 +1621,13 @@ class ConfigurableTask(Task):
) )
except TypeError: # needed for now in order to use a different interface between our own metrics and HF Evaluate metrics except TypeError: # needed for now in order to use a different interface between our own metrics and HF Evaluate metrics
result_score = self._metric_fn_list[metric]([gold, result]) result_score = self._metric_fn_list[metric]([gold, result])
if isinstance(result_score, dict): if isinstance(result_score, dict):
# TODO: this handles the case where HF evaluate returns a dict. # TODO: this handles the case where HF evaluate returns a dict.
# This allows for multiple metrics to be returned from the same function # This allows for multiple metrics to be returned from the same function
for k, v in result_score.items(): for k, v in result_score.items():
result_dict[k] = v result_dict[k] = v
return result_dict else:
result_dict[metric] = result_score result_dict[metric] = result_score
else: else:
raise ValueError( raise ValueError(
f"Passed invalid output_type '{self.OUTPUT_TYPE}' ! Please use one of ", f"Passed invalid output_type '{self.OUTPUT_TYPE}' ! Please use one of ",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment