Unverified Commit 0bafcef0 authored by Lintang Sutawika's avatar Lintang Sutawika Committed by GitHub
Browse files

Fix Parameter Propagation for Tasks that have `include` (#1749)

* Update task.py

* Update __init__.py
parent 594015b6
...@@ -99,7 +99,7 @@ class TaskConfig(dict): ...@@ -99,7 +99,7 @@ class TaskConfig(dict):
def __post_init__(self) -> None: def __post_init__(self) -> None:
if self.generation_kwargs is not None: if self.generation_kwargs is not None:
if self.output_type != "generate_until": if self.output_type != "generate_until":
raise ValueError( eval_logger.warning(
f"[{self.task}] passed `generation_kwargs`, but not using `output_type: generate_until`!" f"[{self.task}] passed `generation_kwargs`, but not using `output_type: generate_until`!"
) )
......
...@@ -136,13 +136,14 @@ class TaskManager: ...@@ -136,13 +136,14 @@ class TaskManager:
if "include" in config: if "include" in config:
if yaml_path is None: if yaml_path is None:
raise ValueError raise ValueError
config.update( config = {
utils.load_yaml_config( **utils.load_yaml_config(
yaml_path, yaml_path,
yaml_config={"include": config.pop("include")}, yaml_config={"include": config.pop("include")},
mode="full", mode="full",
) ),
) **config,
}
if self._config_is_python_task(config): if self._config_is_python_task(config):
task_object = config["class"]() task_object = config["class"]()
else: else:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment