"INSTALL/vscode:/vscode.git/clone" did not exist on "594e735b91ce534829d46ebfe1d2d990cda9f175"
  1. 06 Apr, 2022 1 commit
  2. 01 Apr, 2022 1 commit
  3. 30 Mar, 2022 2 commits
  4. 29 Mar, 2022 2 commits
  5. 26 Mar, 2022 1 commit
    • Celine Lee's avatar
      Modify casting in protection against underflow (#1514) · 9789069c
      Celine Lee authored
      Dear Ventoy community –
       
      Our team is working with your code and we noticed this if logical expression:
       
                      if (len - 1 - (int)(long)(pos - pwdstr) != 32)
       
      We studied the surrounding code. We believe we understand the intention of the type casts in the above if statement. It seems they were meant to ensure an underflow doesn’t occur by the subtraction between to char pointers, which is a great catch (!). However, we believe the way the type casts are structured, the code is not actually protecting against such underflow because pwdstr isn’t cast into a signed long until after the subtraction occurs. To properly protect this code against underflow, we believe it should be changed to something like the following:
      
      if (len - 1 - ((long)pos – (long)pwdstr) != 32)
      
      Or, to enhance readability for junior engineers who may not know that the “long” type cast is implicitly of a signed integer type, we could include the `signed` keyword for added verbosity:
       
      if (len - 1 - ((signed long)pos – (signed long)pwdstr) != 32)
       
      Thank you!
      9789069c
  6. 08 Mar, 2022 2 commits
  7. 06 Mar, 2022 1 commit
  8. 22 Feb, 2022 1 commit
  9. 15 Feb, 2022 5 commits
  10. 14 Feb, 2022 2 commits
  11. 13 Feb, 2022 1 commit
  12. 05 Feb, 2022 1 commit
  13. 08 Jan, 2022 1 commit
  14. 24 Nov, 2021 1 commit
  15. 16 Nov, 2021 2 commits
  16. 15 Nov, 2021 1 commit
  17. 13 Nov, 2021 1 commit
  18. 08 Nov, 2021 1 commit
  19. 02 Nov, 2021 1 commit
  20. 01 Nov, 2021 1 commit
  21. 29 Oct, 2021 1 commit
  22. 27 Oct, 2021 1 commit
  23. 25 Oct, 2021 1 commit
  24. 24 Oct, 2021 1 commit
    • longpanda's avatar
      Add .md5/.sha1/.sha256/.sha512 check file feature. · a93b0f66
      longpanda authored
      Hotkey m is for calculate checksum and print the result.
      If also exist a .md5/.sha1/.sha256/.sha512 file, then it will check the result with the value in the file.
      The .md5/.sha1/.sha256/.sha512 suffix is appended to the original file name not replace the original suffix.
      For example:
      /ISO/Ubuntu-20.04-amd64-desktop.iso
      /ISO/Ubuntu-20.04-amd64-desktop.iso.md5
      a93b0f66
  25. 23 Oct, 2021 2 commits
  26. 22 Oct, 2021 1 commit
  27. 20 Oct, 2021 1 commit
  28. 19 Oct, 2021 2 commits
  29. 17 Oct, 2021 1 commit