orchestration: fix overly broad exceptions being raised (#53)

This uses somewhat more specific exception types instead of just Exception()
everywhere. Makes pylint happy.

experiments/pyexps/log_parser.py

@@ -20,6 +20,7 @@
 # TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
 # SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+import errno
 import json
 import os
 import pathlib
@@ -43,7 +44,7 @@ with open(log_file, 'r', encoding='utf-8') as log:
     outdir = '/'.join(list(p.parts)[0:-1]) + tooutdir
 
     if not os.path.exists(outdir):
-        raise Exception('no such directory')
+        raise FileNotFoundError(errno.ENOENT, os.strerror(errno.ENOENT), outdir)
 
     start_end_path = os.path.join(outdir, 'start_end.txt')
 

experiments/simbricks/orchestration/exectools.py

@@ -212,7 +212,7 @@ class SimpleComponent(Component):
         if self.verbose:
             print(self.label, 'TERMINATED:', rc, flush=True)
         if not self.canfail and rc != 0:
-            raise Exception('Command Failed: ' + str(self.cmd_parts))
+            raise RuntimeError('Command Failed: ' + str(self.cmd_parts))
 
 
 class SimpleRemoteComponent(SimpleComponent):

experiments/simbricks/orchestration/experiments.py

@@ -69,7 +69,7 @@ class Experiment(object):
         """Add a host simulator to the experiment."""
         for h in self.hosts:
             if h.name == sim.name:
-                raise Exception('Duplicate host name')
+                raise ValueError('Duplicate host name')
         self.hosts.append(sim)
 
     def add_nic(self, sim: tp.Union[NICSim, I40eMultiNIC]):
@@ -80,14 +80,14 @@ class Experiment(object):
         """Add a PCIe device simulator to the experiment."""
         for d in self.pcidevs:
             if d.name == sim.name:
-                raise Exception('Duplicate pcidev name')
+                raise ValueError('Duplicate pcidev name')
         self.pcidevs.append(sim)
 
     def add_network(self, sim: NetSim):
         """Add a network simulator to the experiment."""
         for n in self.networks:
             if n.name == sim.name:
-                raise Exception('Duplicate net name')
+                raise ValueError('Duplicate net name')
         self.networks.append(sim)
 
     def all_simulators(self):

experiments/simbricks/orchestration/runtime/local.py

@@ -108,10 +108,10 @@ class LocalParallelRuntime(Runtime):
 
     def add_run(self, run: Run):
         if run.experiment.resreq_cores() > self.cores:
-            raise Exception('Not enough cores available for run')
+            raise RuntimeError('Not enough cores available for run')
 
         if self.mem is not None and run.experiment.resreq_mem() > self.mem:
-            raise Exception('Not enough memory available for run')
+            raise RuntimeError('Not enough memory available for run')
 
         if run.prereq is None:
             self.runs_noprereq.append(run)

experiments/simbricks/orchestration/runtime/slurm.py

@@ -110,7 +110,7 @@ class SlurmRuntime(Runtime):
             result = stream.close()
 
             if result is not None:
-                raise Exception('running sbatch failed')
+                raise RuntimeError('running sbatch failed')
 
             m = jid_re.search(output)
             run.job_id = int(m.group(1))

experiments/simbricks/orchestration/simulators.py

@@ -306,7 +306,7 @@ class QemuHost(HostSim):
             elif unit.lower() == 'mhz':
                 base = 3
             else:
-                raise Exception('cpu frequency specified in unsupported unit')
+                raise ValueError('cpu frequency specified in unsupported unit')
             num = float(self.cpu_freq[:-3])
             shift = base - int(math.ceil(math.log(num, 2)))
 
@@ -610,7 +610,7 @@ class NS3SequencerNet(NetSim):
             elif 'sequencer' in n.name:
                 ports += '--ServerPort=' + s + ' '
             else:
-                raise Exception('Wrong NIC type')
+                raise KeyError('Wrong NIC type')
         cmd = (
             f'{env.repodir}/sims/external/ns-3'
             f'/cosim-run.sh sequencer sequencer-single-switch-example'