system: minor fixes

experiments/simbricks/orchestration/system/eth.py

@@ -43,16 +43,16 @@ class EthChannel(base.Channel):
 class EthSimpleNIC(base.Component):
     def __init__(self, s: base.System) -> None:
         super().__init__(s)
-        self._ip = None
-        self._eth_if = EthInterface(self)
+        self._ip: str | None = None
+        self._eth_if: EthInterface | None = None
 
     def add_ipv4(self, ip: str) -> None:
         assert self._ip is None
-        self.ip = ip
+        self._ip = ip
 
     def add_if(self, interface: EthInterface) -> None:
         utils_base.has_expected_type(obj=interface, expected_type=EthInterface)
-        assert self._eth_if is not None
+        assert self._eth_if is None
         self._eth_if = interface
 
 class BaseEthNetComponent(base.Component):

experiments/simbricks/orchestration/system/mem.py

@@ -59,9 +59,9 @@ class MemSimpleDevice(base.Component):
         self._mem_if: MemDeviceInterface | None = None
 
     def interfaces(self) -> list[base.Interface]:
-        return [self.mem_if]
+        return [self._mem_if]
 
-    def add_if(interface: MemDeviceInterface) -> None:
+    def add_if(self, interface: MemDeviceInterface) -> None:
         utils_base.has_expected_type(obj=interface, expected_type=MemDeviceInterface)
         assert self._mem_if is None
         self._mem_if = interface
\ No newline at end of file

experiments/simbricks/orchestration/system/pcie.py

@@ -56,12 +56,12 @@ class PCIeChannel(base.Channel):
 class PCIeSimpleDevice(base.Component):
     def __init__(self, s: base.System):
         super().__init__(s)
-        self._pci_if = PCIeDeviceInterface(self)
+        self._pci_if: PCIeDeviceInterface | None = None
 
     def interfaces(self) -> list[base.Interface]:
-        return [self.pci_if]
+        return [self._pci_if]
 
-    def add_if(interface: PCIeDeviceInterface) -> None:
+    def add_if(self, interface: PCIeDeviceInterface) -> None:
         utils_base.has_expected_type(obj=interface, expected_type=PCIeDeviceInterface)
         assert self._pci_if is None
         self._pci_if = interface
\ No newline at end of file