1. 23 Nov, 2020 15 commits
    • Colin Brochtrup's avatar
      Add early stopping callback to pytorch trainer (#8581) · 8ffc01a7
      Colin Brochtrup authored
      * Add early stopping patience and minimum threshold metric must improve to prevent early stopping to pytorch trainer
      
      * Add early stopping test
      
      * Set patience counter to 0 if best metric not defined yet
      
      * Make early stopping a callback. Add callback event for updating the best metric for early stopping callback to trigger on.
      
      * Run make style
      
      * make funciton name sensible
      
      * Improve new argument docstring wording and hope that flakey CI test passes.
      
      * Use on_evaluation callback instead of custom. Remove some debug printing
      
      * Move early stopping arguments and state into early stopping callback
      
      * Run make style
      
      * Remove old code
      
      * Fix docs formatting. make style went rogue on me.
      
      * Remove copied attributes and fix variable
      
      * Add assertions on training arguments instead of mutating them. Move comment out of public docs.
      
      * Make separate test for early stopping callback. Add test of invalid arguments.
      
      * Run make style... I remembered before CI this time!
      
      * appease flake8
      
      * Add EarlyStoppingCallback to callback docs
      
      * Make docstring EarlyStoppingCallabck match other callbacks.
      
      * Fix typo in docs
      8ffc01a7
    • Sylvain Gugger's avatar
      Fix max length in run_plm script (#8738) · 367f497d
      Sylvain Gugger authored
      367f497d
    • Stas Bekman's avatar
      consistent ignore keys + make private (#8737) · e84786aa
      Stas Bekman authored
      * consistent ignore keys + make private
      
      * style
      
      * - authorized_missing_keys    => _keys_to_ignore_on_load_missing
        - authorized_unexpected_keys => _keys_to_ignore_on_load_unexpected
      
      * move public doc of private attributes to private comment
      e84786aa
    • Sylvain Gugger's avatar
      Document new training argument · 49759c0c
      Sylvain Gugger authored
      49759c0c
    • alexorona's avatar
      gpt2 and t5 parallel modeling (#8696) · 1cd9be2a
      alexorona authored
      
      
      * gpt2 and t5 parallel modeling
      
      * model_parallel utils update
      
      * adding missing model_parallel_utils
      
      Adds missing model_parallel_utils and reverses the changes to code in modeling_gpt2 and modeling_t5
      
      * training_args reformat
      
      Reformatted training_args
      
      * style formatting
      
      Style formatting doc string length on training_args and model_parallel_utils
      
      * style changes
      
      make style && make quality for training_args and model_parallel_utils.
      
      * adding tests
      
      * minor change in trainer
      
      reverts loss calculation
      
      * Update training_args.py
      
      * Update training_args.py
      
      added back docstring language for adam_beta1 and adam_beta2
      
      * Update trainer.py
      
      * Update src/transformers/trainer.py
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      
      * Fix style & rebase
      Co-authored-by: default avatarLysandre Debut <lysandre@huggingface.co>
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      Co-authored-by: default avatarLysandreJik <lysandre.debut@reseau.eseo.fr>
      1cd9be2a
    • Stas Bekman's avatar
      [trainer] make generate work with multigpu (#8716) · 1e45bef0
      Stas Bekman authored
      * make generate work with multigpu
      
      * better fix - thanks @sgugger
      1e45bef0
    • Sylvain Gugger's avatar
      Change default cache path (#8734) · 90002427
      Sylvain Gugger authored
      
      
      * Change default cache path
      
      * Document changes
      
      * Apply suggestions from code review
      Co-authored-by: default avatarLysandre Debut <lysandre@huggingface.co>
      Co-authored-by: default avatarLysandre Debut <lysandre@huggingface.co>
      90002427
    • Julien Chaumond's avatar
      Improve bert-japanese tokenizer handling (#8659) · 0cc5ab13
      Julien Chaumond authored
      
      
      * Make ci fail
      
      * Try to make tests actually run?
      
      * CI finally failing?
      
      * Fix CI
      
      * Revert "Fix CI"
      
      This reverts commit ca7923be7334d4e571b023478ebdd6b33dfd0ebb.
      
      * Ooops wrong one
      
      * one more try
      
      * Ok ok let's move this elsewhere
      
      * Alternative to globals() (#8667)
      
      * Alternative to globals()
      
      * Error is raised later so return None
      
      * Sentencepiece not installed make some tokenizers None
      
      * Apply Lysandre wisdom
      
      * Slightly clearer comment?
      
      cc @sgugger
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      0cc5ab13
    • Amine Abdaoui's avatar
      [model_cards]: control input examples of Geotrend models (#8727) · eec76615
      Amine Abdaoui authored
      * [model_cards]: control arabic model examples
      
      * [model_cards]: control input examples of Geotrend models
      
      * [model_cards]: add link to generatation script
      eec76615
    • Jessica Yung's avatar
      Add pip install update to resolve import error in transformers notebook (#8616) · 143b564e
      Jessica Yung authored
      
      
      * Add pip install update to resolve import error
      
      Add pip install upgrade tensorflow-gpu to remove error below:
      ```
      ---------------------------------------------------------------------------
      AttributeError                            Traceback (most recent call last)
      <ipython-input-2-094fadb93f3f> in <module>()
            1 import torch
      ----> 2 from transformers import AutoModel, AutoTokenizer, BertTokenizer
            3 
            4 torch.set_grad_enabled(False)
      
      4 frames
      /usr/local/lib/python3.6/dist-packages/transformers/__init__.py in <module>()
          133 
          134 # Pipelines
      --> 135 from .pipelines import (
          136     Conversation,
          137     ConversationalPipeline,
      
      /usr/local/lib/python3.6/dist-packages/transformers/pipelines.py in <module>()
           46     import tensorflow as tf
           47 
      ---> 48     from .modeling_tf_auto import (
           49         TF_MODEL_FOR_QUESTION_ANSWERING_MAPPING,
           50         TF_MODEL_FOR_SEQ_TO_SEQ_CAUSAL_LM_MAPPING,
      
      /usr/local/lib/python3.6/dist-packages/transformers/modeling_tf_auto.py in <module>()
           49 from .configuration_utils import PretrainedConfig
           50 from .file_utils import add_start_docstrings
      ---> 51 from .modeling_tf_albert import (
           52     TFAlbertForMaskedLM,
           53     TFAlbertForMultipleChoice,
      
      /usr/local/lib/python3.6/dist-packages/transformers/modeling_tf_albert.py in <module>()
           22 import tensorflow as tf
           23 
      ---> 24 from .activations_tf import get_tf_activation
           25 from .configuration_albert import AlbertConfig
           26 from .file_utils import (
      
      /usr/local/lib/python3.6/dist-packages/transformers/activations_tf.py in <module>()
           52     "gelu": tf.keras.layers.Activation(gelu),
           53     "relu": tf.keras.activations.relu,
      ---> 54     "swish": tf.keras.activations.swish,
           55     "silu": tf.keras.activations.swish,
           56     "gelu_new": tf.keras.layers.Activation(gelu_new),
      
      AttributeError: module 'tensorflow_core.python.keras.api._v2.keras.activations' has no attribute 'swish'
      ```
      I have tried running the colab after this change and it seems to work fine (all the cells run with no errors).
      
      * Update notebooks/02-transformers.ipynb
      
      only need to upgrade tensorflow, not tensorflow-gpu.
      Co-authored-by: default avatarLysandre Debut <lysandre@huggingface.co>
      Co-authored-by: default avatarLysandre Debut <lysandre@huggingface.co>
      143b564e
    • Yossi Synett's avatar
    • Tony's avatar
      [model_cards] Add card for gpt2-rnm (#8673) · 48cc2247
      Tony authored
      48cc2247
    • Nguyen Van Nha's avatar
      create README.md (#8682) · 52585e40
      Nguyen Van Nha authored
      
      
      * create README.md
      
      * Apply suggestions from code review
      Co-authored-by: default avatarJulien Chaumond <chaumond@gmail.com>
      52585e40
    • Sagor Sarker's avatar
      b5187e31
    • moniquebm's avatar
      Create README.md (#8630) · b6d864e2
      moniquebm authored
      
      
      * Create README.md
      
      * correct metrics id
      
      cc @lhoestq
      Co-authored-by: default avatarJulien Chaumond <chaumond@gmail.com>
      b6d864e2
  2. 22 Nov, 2020 1 commit
  3. 20 Nov, 2020 6 commits
  4. 19 Nov, 2020 18 commits