1. 23 Jun, 2022 1 commit
    • Matt's avatar
      Fix broken test for models with batchnorm (#17841) · 1a7ef334
      Matt authored
      * Fix tests that broke when models used batchnorm
      
      * Initializing the model twice does not actually...
      ...give you the same weights each time.
      I am good at machine learning.
      
      * Fix speed regression
      1a7ef334
  2. 21 Jun, 2022 2 commits
  3. 20 Jun, 2022 1 commit
  4. 09 Jun, 2022 2 commits
  5. 06 Jun, 2022 1 commit
  6. 17 May, 2022 1 commit
    • Matt's avatar
      Rewrite TensorFlow train_step and test_step (#17057) · 349f1c85
      Matt authored
      * Initial commit
      
      * Better label renaming
      
      * Remove breakpoint before pushing (this is your job)
      
      * Test a lot more in the Keras fit() test
      
      * make fixup
      
      * Clarify the case where we flatten y dicts into tensors
      
      * Clarify the case where we flatten y dicts into tensors
      
      * Extract label name remapping to a method
      349f1c85
  7. 12 May, 2022 2 commits
    • Sylvain Gugger's avatar
      Black preview (#17217) · afe5d42d
      Sylvain Gugger authored
      * Black preview
      
      * Fixup too!
      
      * Fix check copies
      
      * Use the same version as the CI
      
      * Bump black
      afe5d42d
    • Matt's avatar
      Add test to ensure models can take int64 inputs (#17210) · f04257fd
      Matt authored
      * Add test to ensure models can take int64 inputs
      
      * is_integer is an attribute, not a method
      
      * Fix test when some inputs aren't tensors
      
      * Add casts to blenderbot and blenderbot-small
      
      * Add casts to the other failing models
      f04257fd
  8. 25 Apr, 2022 1 commit
  9. 19 Apr, 2022 1 commit
  10. 11 Apr, 2022 1 commit
    • Yih-Dar's avatar
      Improve PT/TF equivalence test (#16557) · dce33f21
      Yih-Dar authored
      
      
      * add error message
      
      * Use names in the error message
      
      * allow ModelOutput
      
      * rename to check_pt_tf_outputs and move outside
      
      * fix style
      
      * skip past_key_values in a better way
      
      * Add comments
      
      * improve code for label/loss
      
      * make the logic clear by moving the ignore keys out
      
      * fix _postprocessing_to_ignore
      
      * fix _postprocessing_to_ignore: create new outputs from the remaining fields
      
      * ignore past_key_values in TFGPT2 models for now
      
      * make check_pt_tf_outputs better regarding names
      
      * move check_pt_tf_models outside
      
      * rename methods
      
      * remove test_pt_tf_model_equivalence in TFCLIPModelTest
      
      * Reduce TFViTMAEModelTest.test_pt_tf_model_equivalence
      
      * move prepare_pt_inputs_from_tf_inputs outside check_pt_tf_models
      
      * Fix quality
      
      * Clean-up TFLxmertModelTester.test_pt_tf_model_equivalence
      
      * Fix quality
      
      * fix
      
      * fix style
      
      * Clean-up TFLEDModelTest.test_pt_tf_model_equivalence
      
      * Fix quality
      
      * add docstring
      
      * improve comment
      Co-authored-by: default avatarydshieh <ydshieh@users.noreply.github.com>
      dce33f21
  11. 06 Apr, 2022 1 commit
  12. 05 Apr, 2022 1 commit
    • Matt's avatar
      Adding new train_step logic to make things less confusing for users (#15994) · 43540052
      Matt authored
      
      
      * Adding new train_step logic to make things less confusing for users
      
      * DO NOT ASK WHY WE NEED THAT SUBCLASS
      
      * Metrics now working, at least for single-output models with type annotations!
      
      * Updates and TODOs for the new train_step
      
      * Make fixup
      
      * Temporary test workaround until T5 has types
      
      * Temporary test workaround until T5 has types
      
      * I think this actually works! Needs a lot of tests though
      
      * MAke style/quality
      
      * Revert changes to T5 tests
      
      * Deleting the aforementioned unmentionable subclass
      
      * Deleting the aforementioned unmentionable subclass
      
      * Adding a Keras API test
      
      * Style fixes
      
      * Removing unneeded TODO and comments
      
      * Update test_step too
      
      * Stop trying to compute metrics with the dummy_loss, patch up test
      
      * Make style
      
      * make fixup
      
      * Docstring cleanup
      
      * make fixup
      
      * make fixup
      
      * Stop expanding 1D input tensors when using dummy loss
      
      * Adjust T5 test given the new compile()
      
      * make fixup
      
      * Skipping test for convnext
      
      * Removing old T5-specific Keras test now that we have a common one
      
      * make fixup
      
      * make fixup
      
      * Only skip convnext test on CPU
      
      * Update src/transformers/modeling_tf_utils.py
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      
      * Update src/transformers/modeling_tf_utils.py
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      
      * Avoiding TF import issues
      
      * make fixup
      
      * Update compile() to support TF 2.3
      
      * Skipping model.fit() on template classes for now
      
      * Skipping model.fit() on template class tests for now
      
      * Replace ad-hoc solution with find_labels
      
      * make fixup
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      43540052
  13. 04 Apr, 2022 1 commit
  14. 01 Apr, 2022 1 commit
  15. 23 Mar, 2022 2 commits
  16. 19 Mar, 2022 1 commit
  17. 17 Mar, 2022 1 commit
  18. 14 Mar, 2022 1 commit
    • Yih-Dar's avatar
      Make TF pt-tf equivalence test more aggressive (#15839) · 923c35b5
      Yih-Dar authored
      
      
      * Make TF pt-tf equivalence test more aggressive
      
      * Fix for TFConvNextModelTest and TFTransfoXLModelTest
      
      * fix kwargs for outputs
      
      * clean-up
      
      * Add docstring for check_outputs()
      
      * remove: need to rename encoder-decoder
      
      * clean-up
      
      * send PyTorch things to the correct device
      
      * Add back the accidentally removed test case in test_pt_tf_model_equivalence()
      
      * Fix: change to tuple before calling check_outputs()
      
      * Fix: tfo could be a list
      
      * use to_tuple()
      
      * allow tfo only to be tuple or tensor
      
      * allow tfo to be list or tuple for now + style change
      
      * minor fix
      
      * remove np.copy and update comments
      
      * tfo -> tf_output, same for pt
      
      * Add more detailed comment
      
      * remove the incorrect comment
      Co-authored-by: default avatarydshieh <ydshieh@users.noreply.github.com>
      923c35b5
  19. 02 Mar, 2022 1 commit
  20. 25 Feb, 2022 1 commit
    • Sayak Paul's avatar
      Add TFConvNextModel (#15750) · 84eaa6ac
      Sayak Paul authored
      
      
      * feat: initial implementation of convnext in tensorflow.
      
      * fix: sample code for the classification model.
      
      * chore: added checked for  from the classification model.
      
      * chore: set bias initializer in the classification head.
      
      * chore: updated license terms.
      
      * chore: removed ununsed imports
      
      * feat: enabled  argument during using drop_path.
      
      * chore: replaced tf.identity with layers.Activation(linear).
      
      * chore: edited default checkpoint.
      
      * fix: minor bugs in the initializations.
      
      * partial-fix: tf model errors for loading pretrained pt weights.
      
      * partial-fix: call method updated
      
      * partial-fix: cross loading of weights (4x3 variables to be matched)
      
      * chore: removed unneeded comment.
      
      * removed playground.py
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * fix: renaming TFConvNextStage conv and layer norm layers
      
      * chore: added initializers and other minor additions.
      
      * chore: added initializers and other minor additions.
      
      * add: tests for convnext.
      
      * fix: integration tester class.
      
      * fix: issues mentioned in pr feedback (round 1).
      
      * fix: how output_hidden_states arg is propoagated inside the network.
      
      * feat: handling of  arg for pure cnn models.
      
      * chore: added a note on equal contribution in model docs.
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * feat: encapsulation for the convnext trunk.
      
      * Fix variable naming; Test-related corrections; Run make fixup
      
      * chore: added Joao as a contributor to convnext.
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * chore: corrected copyright year and added comment on NHWC.
      
      * chore: fixed the black version and ran formatting.
      
      * chore: ran make style.
      
      * chore: removed from_pt argument from test, ran make style.
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * fix: tests in the convnext subclass, ran make style.
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * rebasing
      
      * rebasing and removing playground.py.
      
      * chore: moved convnext test to the correct location
      
      * fix: locations for the test file of convnext.
      
      * fix: convnext tests.
      
      * chore: applied  sgugger's suggestion for dealing w/ output_attentions.
      
      * chore: added comments.
      
      * chore: applied updated quality enviornment style.
      
      * chore: applied formatting with quality enviornment.
      
      * chore: revert to the previous tests/test_modeling_common.py.
      
      * chore: revert to the original test_modeling_common.py
      
      * chore: revert to previous states for test_modeling_tf_common.py and modeling_tf_utils.py
      
      * fix: tests for convnext.
      
      * chore: removed output_attentions argument from convnext config.
      
      * chore: revert to the earlier tf utils.
      
      * fix: output shapes of the hidden states
      
      * chore: removed unnecessary comment
      
      * chore: reverting to the right test_modeling_tf_common.py.
      
      * Styling nits
      Co-authored-by: default avatarariG23498 <aritra.born2fly@gmail.com>
      Co-authored-by: default avatarJoao Gante <joao@huggingface.co>
      Co-authored-by: default avatarSylvain Gugger <Sylvain.gugger@gmail.com>
      84eaa6ac
  21. 15 Feb, 2022 1 commit
    • Patrick von Platen's avatar
      TF generate refactor - Greedy Search (#15562) · 2e12b907
      Patrick von Platen authored
      
      
      * TF generate start refactor
      
      * Add tf tests for sample generate
      
      * re-organize
      
      * boom boom
      
      * Apply suggestions from code review
      
      * re-add
      
      * add all code
      
      * make random greedy pass
      
      * make encoder-decoder random work
      
      * further improvements
      
      * delete bogus file
      
      * make gpt2 and t5 tests work
      
      * finish logits tests
      
      * correct logits processors
      
      * correct past / encoder_outputs drama
      
      * refactor some methods
      
      * another fix
      
      * refactor shape_list
      
      * fix more shape list
      
      * import shape
      _list
      
      * finish docs
      
      * fix imports
      
      * make style
      
      * correct tf utils
      
      * Fix TFRag as well
      
      * Apply Lysandre's and Sylvais suggestions
      
      * Update tests/test_generation_tf_logits_process.py
      Co-authored-by: default avatarMatt <Rocketknight1@users.noreply.github.com>
      
      * Update src/transformers/tf_utils.py
      Co-authored-by: default avatarMatt <Rocketknight1@users.noreply.github.com>
      
      * remove cpu according to gante
      
      * correct logit processor
      Co-authored-by: default avatarMatt <Rocketknight1@users.noreply.github.com>
      2e12b907
  22. 08 Feb, 2022 1 commit
    • Joao Gante's avatar
      Add TFSpeech2Text (#15113) · 8406fa6d
      Joao Gante authored
      * Add wrapper classes
      
      * convert inner layers to tf
      
      * Add TF Encoder and Decoder layers
      
      * TFSpeech2Text models
      
      * Loadable model
      
      * TF model with same outputs as PT model
      
      * test skeleton
      
      * correct tests and run the fixup
      
      * correct attention expansion
      
      * TFSpeech2Text pask_key_values with TF format
      8406fa6d
  23. 01 Feb, 2022 1 commit
  24. 19 Jan, 2022 1 commit
    • Matt's avatar
      Rename compute_loss in TF models (#15207) · 2708bfa1
      Matt authored
      * Rename compute_loss to hf_compute_loss to avoid conflicts with the new Keras method
      
      * make style
      
      * Adding deprecation warning to `compute_loss`
      
      * Fix sneaky reference to compute_loss
      
      * Replace logger.warning with warnings.warn
      
      * Clarifying warning and deprecation timeline
      2708bfa1
  25. 18 Jan, 2022 2 commits
  26. 14 Jan, 2022 2 commits
  27. 23 Dec, 2021 1 commit
    • Yih-Dar's avatar
      Add TFCLIPModel (#13967) · 8f2cc1c3
      Yih-Dar authored
      
      
      * Start the work for TFCLIPModel
      
      * Convert to TF code (TODO: loss + doc)
      
      * Clean up
      
      * Fix pooled_output for TFCLIPTextTransformer - using tf.gather_nd
      
      * assert -> raise error
      
      * Expose TFCLIPModel
      
      * Deal with dummy_inputs
      
      * Add tests
      
      * Fix all tests. TODO: manual check weight loading + add more comments
      
      * Fix pt tf equivalence test
      
      * fixes
      
      * update TFCLIPVisionEmbeddings's Conv2D
      
      * Fix loss + overwrite test_pt_tf_model_equivalence from common
      
      * Add a comment about the change about MainLayer in test_keras_save_load
      
      * Set return_loss=True in TFCLIPModelTester + make tests pass
      
      * overwrite test_pt_tf_model_equivalence from tf common
      
      * fix base_model_prefix
      
      * Fix examples
      
      * remove unused
      
      * Apply suggestions from code review
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      
      * apply review suggestions
      
      * change self.pre_layrnorm to self.pre_layernorm
      
      * apply more review suggestions
      
      * return attention probs before dropout (to align with PT)
      
      * fix weight init
      
      * fix
      
      * build doc
      
      * fix missing doc
      
      * fix for test
      Co-authored-by: default avatarydshieh <ydshieh@users.noreply.github.com>
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      8f2cc1c3
  28. 20 Dec, 2021 1 commit
  29. 15 Dec, 2021 1 commit
    • Matt's avatar
      TF model cards (#14720) · 48d48276
      Matt authored
      * Initial commit for Keras model cards
      
      * Revert accidental change
      
      * make style
      
      * make style
      
      * make style
      
      * Fix PR comments
      
      * Move repo creation to __init__
      
      * Fixes to README.md creation
      
      * Partial progress for proper card creation on `push_to_hub`
      
      * Proper card creation from `push_to_hub` plus fixes for malformed model cards
      
      * Fixes for model card creation outside the callback
      
      * Adding a model card creation test
      
      * Putting the model card creation test in the right file.
      Good job, Matt.
      
      * make style
      
      * Fix model card test temp dir usage
      
      * Fix model card creation when no optimizer present
      
      * Fixes for when training history not present
      
      * Fix accidental edit to test_modeling_common
      48d48276
  30. 17 Nov, 2021 1 commit
    • N's avatar
      [WIP] Ensure TF model configs can be converted to proper JSON (#14415) · 1991da07
      N authored
      
      
      * test: make sure model configs are jsonifiable
      
      * fix: return python dict instead of config object
      
      * fix: accept pretrained config and use correct class
      
      * Re-enabling slow tests and applying them to core models only
      
      * Re-enabling slow tests and applying them to core models only
      
      * Add new test file to fetcher
      
      * Remove tooslow tests from test_modeling_tf_common.py
      
      * make style
      
      * Style fixes
      
      * Style fixes
      
      * Style fixes
      
      * Style fixes
      
      * Adding core tests to GPT2 and BART
      
      * Removing unused imports
      Co-authored-by: default avatarniklas.fruehauf <niklas.fruehauf@sovanta.com>
      Co-authored-by: default avatarmatt <rocketknight1@gmail.com>
      1991da07
  31. 11 Nov, 2021 1 commit
  32. 09 Nov, 2021 1 commit
    • Yih-Dar's avatar
      Add TFViTModel (#13778) · be4a6c64
      Yih-Dar authored
      
      
      * Start the work for TFViTModel
      
      * Convert to TF code - need to check in the follow up commits
      
      * Clean up model code
      
      * Expose TFViTModel
      
      * make style
      
      * make quality
      
      * Add test
      
      * make style & quality
      
      * Fix some imports
      
      * fix wrong usage - *kwargs => ** kwargs
      
      * Fix Conv2D weight loading (PT->TF) issue
      
      * Add tests for images with different sizes + fix model
      
      * Fix some common tests for TFViTModel
      
      * Use inputs instead of input_ids in test_compile_tf_model
      
      * Add a comment about transpose and Conv2D in convert_tf_weight_name_to_pt_weight_name
      
      * Avoid transpose in TFViT call
      
      * Fix Conv2D issue in load_tf2_weights_in_pytorch_model
      
      * Use tf.keras.layers.Conv2D instead of tf.nn.conv2d
      
      * Using simpler heuristic to detect Conv2D layer
      
      * Change convert_tf_weight_name_to_pt_weight_name to return TransposeType
      
      * Check tf_weight_shape is not None before using it
      
      * Apply suggestions from code review
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      
      * fix missing comma
      
      * fix input dtype
      Co-authored-by: default avatarydshieh <ydshieh@users.noreply.github.com>
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      be4a6c64
  33. 02 Nov, 2021 1 commit
  34. 25 Oct, 2021 1 commit