1. 28 Sep, 2020 1 commit
  2. 23 Sep, 2020 1 commit
    • Stas Bekman's avatar
      [code quality] fix confused flake8 (#7309) · df536438
      Stas Bekman authored
      * fix confused flake
      
      We run `black  --target-version py35 ...` but flake8 doesn't know that, so currently with py38 flake8 fails suggesting that black should have reformatted 63 files. Indeed if I run:
      
      ```
      black --line-length 119 --target-version py38 examples templates tests src utils
      ```
      it indeed reformats 63 files.
      
      The only solution I found is to create a black config file as explained at https://github.com/psf/black#configuration-format, which is what this PR adds.
      
      Now flake8 knows that py35 is the standard and no longer gets confused regardless of the user's python version.
      
      * adjust the other files that will now rely on black's config file
      df536438
  3. 22 Sep, 2020 2 commits
  4. 17 Sep, 2020 1 commit
    • Stas Bekman's avatar
      remove deprecated flag (#7171) · 79111b77
      Stas Bekman authored
      ```
      /home/circleci/.local/lib/python3.6/site-packages/isort/main.py:915: UserWarning: W0501: The following deprecated CLI flags were used and ignored: --recursive!
        "W0501: The following deprecated CLI flags were used and ignored: "
      ```
      79111b77
  5. 10 Sep, 2020 1 commit
  6. 01 Sep, 2020 2 commits
  7. 25 Aug, 2020 1 commit
  8. 24 Aug, 2020 1 commit
  9. 17 Aug, 2020 1 commit
  10. 12 Aug, 2020 2 commits
  11. 11 Aug, 2020 2 commits
  12. 10 Aug, 2020 1 commit
  13. 07 Aug, 2020 2 commits
  14. 04 Aug, 2020 2 commits
  15. 31 Jul, 2020 1 commit
    • Paul O'Leary McCann's avatar
      Replace mecab-python3 with fugashi for Japanese tokenization (#6086) · cf3cf304
      Paul O'Leary McCann authored
      
      
      * Replace mecab-python3 with fugashi
      
      This replaces mecab-python3 with fugashi for Japanese tokenization. I am
      the maintainer of both projects.
      
      Both projects are MeCab wrappers, so the underlying C++ code is the
      same. fugashi is the newer wrapper and doesn't use SWIG, so for basic
      use of the MeCab API it's easier to use.
      
      This code insures the use of a version of ipadic installed via pip,
      which should make versioning and tracking down issues easier.
      
      fugashi has wheels for Windows, OSX, and Linux, which will help with
      issues with installing old versions of mecab-python3 on Windows.
      Compared to mecab-python3, because fugashi doesn't use SWIG, it doesn't
      require a C++ runtime to be installed on Windows.
      
      In adding this change I removed some code dealing with `cursor`,
      `token_start`, and `token_end` variables. These variables didn't seem to
      be used for anything, it is unclear to me why they were there.
      
      I ran the tests and they passed, though I couldn't figure out how to run
      the slow tests (`--runslow` gave an error) and didn't try testing with
      Tensorflow.
      
      * Style fix
      
      * Remove unused variable
      
      Forgot to delete this...
      
      * Adapt doc with install instructions
      
      * Fix typo
      Co-authored-by: default avatarsgugger <sylvain.gugger@gmail.com>
      Co-authored-by: default avatarSylvain Gugger <35901082+sgugger@users.noreply.github.com>
      cf3cf304
  16. 26 Jul, 2020 1 commit
    • Stas Bekman's avatar
      add a summary report flag for run_examples on CI (#6035) · daa5dd12
      Stas Bekman authored
      Currently, it's hard to derive which example tests were run on CI, and which weren't. Adding `-rA` flag to `pytest`, will now include a summary like:
      
      ```
      ==================================================================== short test summary info =====================================================================
      PASSED examples/test_examples.py::ExamplesTests::test_generation
      PASSED examples/test_examples.py::ExamplesTests::test_run_glue
      PASSED examples/test_examples.py::ExamplesTests::test_run_language_modeling
      PASSED examples/test_examples.py::ExamplesTests::test_run_squad
      FAILED examples/test_examples.py::ExamplesTests::test_run_pl_glue - AttributeError: 'Namespace' object has no attribute 'gpus'
      ============================================================ 1 failed, 4 passed, 8 warnings in 42.96s ============================================================
      ```
      which makes it easier to validate whether some example is being covered by CI or not.
      daa5dd12
  17. 24 Jul, 2020 1 commit
  18. 09 Jul, 2020 2 commits
  19. 06 Jul, 2020 1 commit
  20. 30 Jun, 2020 1 commit
  21. 29 Jun, 2020 1 commit
  22. 26 Jun, 2020 1 commit
  23. 24 Jun, 2020 5 commits
  24. 22 Jun, 2020 2 commits
  25. 17 Apr, 2020 1 commit
  26. 24 Mar, 2020 1 commit
  27. 23 Mar, 2020 1 commit
  28. 17 Mar, 2020 1 commit