Skip to content

GitLab

Unverified Commit e3a97163 authored by Zach Mueller's avatar Zach Mueller Committed by GitHub
Browse files

Fix err with FSDP (#25991) 

* Fix err

* Use version check
parent fa6107c9
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 8 deletions
src/transformers/trainer.py
View file @ e3a97163
...@@ -3910,15 +3910,16 @@ class Trainer: ...@@ -3910,15 +3910,16 @@ class Trainer:
fsdp_plugin.limit_all_gathers = self.args.fsdp_config.get( fsdp_plugin.limit_all_gathers = self.args.fsdp_config.get(
"limit_all_gathers", fsdp_plugin.limit_all_gathers "limit_all_gathers", fsdp_plugin.limit_all_gathers
) )
fsdp_plugin.activation_checkpointing = self.args.fsdp_config.get( if is_accelerate_available("0.23.0"):
"activation_checkpointing", fsdp_plugin.activation_checkpointing fsdp_plugin.activation_checkpointing = self.args.fsdp_config.get(
) "activation_checkpointing", fsdp_plugin.activation_checkpointing
if fsdp_plugin.activation_checkpointing and self.args.gradient_checkpointing:
raise ValueError(
"The activation_checkpointing in FSDP config and the gradient_checkpointing in training arg "
"can't be set to True simultaneously. Please use FSDP's activation_checkpointing logic "
"when using FSDP."
) )
if fsdp_plugin.activation_checkpointing and self.args.gradient_checkpointing:
raise ValueError(
"The activation_checkpointing in FSDP config and the gradient_checkpointing in training arg "
"can't be set to True simultaneously. Please use FSDP's activation_checkpointing logic "
"when using FSDP."
)
if self.is_deepspeed_enabled: if self.is_deepspeed_enabled:
if getattr(self.args, "hf_deepspeed_config", None) is None: if getattr(self.args, "hf_deepspeed_config", None) is None:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment