Unverified Commit dfed4ec2 authored by Sylvain Gugger's avatar Sylvain Gugger Committed by GitHub
Browse files

Don't duplicate logs in TensorBoard and handle --use_env (#11141)

parent 9c9b8e70
...@@ -604,9 +604,11 @@ class TensorBoardCallback(TrainerCallback): ...@@ -604,9 +604,11 @@ class TensorBoardCallback(TrainerCallback):
self.tb_writer.add_hparams(args.to_sanitized_dict(), metric_dict={}) self.tb_writer.add_hparams(args.to_sanitized_dict(), metric_dict={})
def on_log(self, args, state, control, logs=None, **kwargs): def on_log(self, args, state, control, logs=None, **kwargs):
if state.is_world_process_zero: if not state.is_world_process_zero:
if self.tb_writer is None: return
self._init_summary_writer(args)
if self.tb_writer is None:
self._init_summary_writer(args)
if self.tb_writer is not None: if self.tb_writer is not None:
logs = rewrite_logs(logs) logs = rewrite_logs(logs)
......
...@@ -531,6 +531,12 @@ class TrainingArguments: ...@@ -531,6 +531,12 @@ class TrainingArguments:
) )
def __post_init__(self): def __post_init__(self):
# Handle --use_env option in torch.distributed.launch (local_rank not passed as an arg then).
# This needs to happen before any call to self.device or self.n_gpu.
env_local_rank = int(os.environ.get("LOCAL_RANK", -1))
if env_local_rank != -1 and env_local_rank != self.local_rank:
self.local_rank = env_local_rank
# expand paths, if not os.makedirs("~/bar") will make directory # expand paths, if not os.makedirs("~/bar") will make directory
# in the current directory instead of the actual home # in the current directory instead of the actual home
#  see https://github.com/huggingface/transformers/issues/10628 #  see https://github.com/huggingface/transformers/issues/10628
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment