Unverified Commit df536438 authored by Stas Bekman's avatar Stas Bekman Committed by GitHub
Browse files

[code quality] fix confused flake8 (#7309)

* fix confused flake

We run `black  --target-version py35 ...` but flake8 doesn't know that, so currently with py38 flake8 fails suggesting that black should have reformatted 63 files. Indeed if I run:

```
black --line-length 119 --target-version py38 examples templates tests src utils
```
it indeed reformats 63 files.

The only solution I found is to create a black config file as explained at https://github.com/psf/black#configuration-format, which is what this PR adds.

Now flake8 knows that py35 is the standard and no longer gets confused regardless of the user's python version.

* adjust the other files that will now rely on black's config file
parent 78387cc6
...@@ -244,7 +244,7 @@ jobs: ...@@ -244,7 +244,7 @@ jobs:
key: v0.3-code_quality-{{ checksum "setup.py" }} key: v0.3-code_quality-{{ checksum "setup.py" }}
paths: paths:
- '~/.cache/pip' - '~/.cache/pip'
- run: black --check --line-length 119 --target-version py35 examples templates tests src utils - run: black --check examples templates tests src utils
- run: isort --check-only examples templates tests src utils - run: isort --check-only examples templates tests src utils
- run: flake8 examples templates tests src utils - run: flake8 examples templates tests src utils
- run: python utils/check_copies.py - run: python utils/check_copies.py
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
# Check that source code meets quality standards # Check that source code meets quality standards
quality: quality:
black --check --line-length 119 --target-version py35 examples templates tests src utils black --check examples templates tests src utils
isort --check-only examples templates tests src utils isort --check-only examples templates tests src utils
flake8 examples templates tests src utils flake8 examples templates tests src utils
python utils/check_copies.py python utils/check_copies.py
...@@ -12,7 +12,7 @@ quality: ...@@ -12,7 +12,7 @@ quality:
# Format source code automatically # Format source code automatically
style: style:
black --line-length 119 --target-version py35 examples templates tests src utils black examples templates tests src utils
isort examples templates tests src utils isort examples templates tests src utils
# Make marked copies of snippets of codes conform to the original # Make marked copies of snippets of codes conform to the original
......
[tool.black]
line-length = 119
target-version = ['py35']
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment