5. Once you are satisfied, go to the webpage of your fork on GitHub. Click on “Pull request”. Make sure to add the
5. Once you are satisfied, go to the webpage of your fork on GitHub. Click on “Pull request”. Make sure to add the
GitHub handle of some members of the Hugging Face team as reviewers, so that the Hugging Face team gets notified for
GitHub handle of some members of the Hugging Face team as reviewers, so that the Hugging Face team gets notified for
...
@@ -759,7 +759,7 @@ In case you are using Windows, you should replace `RUN_SLOW=1` with `SET RUN_SLO
...
@@ -759,7 +759,7 @@ In case you are using Windows, you should replace `RUN_SLOW=1` with `SET RUN_SLO
</Tip>
</Tip>
Second, all features that are special to *brand_new_bert* should be tested additionally in a separate test under
Second, all features that are special to *brand_new_bert* should be tested additionally in a separate test under
`BrandNewBertModelTester`/``BrandNewBertModelTest`. This part is often forgotten but is extremely useful in two
`BrandNewBertModelTester`/`BrandNewBertModelTest`. This part is often forgotten but is extremely useful in two
ways:
ways:
- It helps to transfer the knowledge you have acquired during the model addition to the community by showing how the
- It helps to transfer the knowledge you have acquired during the model addition to the community by showing how the
...
@@ -776,7 +776,7 @@ It is very important to find/extract the original tokenizer file and to manage t
...
@@ -776,7 +776,7 @@ It is very important to find/extract the original tokenizer file and to manage t
Transformers' implementation of the tokenizer.
Transformers' implementation of the tokenizer.
To ensure that the tokenizer works correctly, it is recommended to first create a script in the original repository
To ensure that the tokenizer works correctly, it is recommended to first create a script in the original repository
that inputs a string and returns the `input_ids``. It could look similar to this (in pseudo-code):
that inputs a string and returns the `input_ids`. It could look similar to this (in pseudo-code):
```python
```python
input_str="This is a long example input string containing special characters .$?-, numbers 2872 234 12 and words."
input_str="This is a long example input string containing special characters .$?-, numbers 2872 234 12 and words."
...
@@ -827,7 +827,7 @@ the community to add some *Tips* to show how the model should be used. Don't hes
...
@@ -827,7 +827,7 @@ the community to add some *Tips* to show how the model should be used. Don't hes
regarding the docstrings.
regarding the docstrings.
Next, make sure that the docstring added to `src/transformers/models/brand_new_bert/modeling_brand_new_bert.py` is
Next, make sure that the docstring added to `src/transformers/models/brand_new_bert/modeling_brand_new_bert.py` is
correct and included all necessary inputs and outputs. We have a detailed guide about writing documentation and our docstring format [here](writing-documentation). It is always to good to remind oneself that documentation should
correct and included all necessary inputs and outputs. We have a detailed guide about writing documentation and our docstring format [here](writing-documentation). It is always good to remind oneself that documentation should
be treated at least as carefully as the code in 🤗 Transformers since the documentation is usually the first contact
be treated at least as carefully as the code in 🤗 Transformers since the documentation is usually the first contact