Unverified Commit af8d1dc3 authored by Yih-Dar's avatar Yih-Dar Committed by GitHub
Browse files

Avoid many failing tests in doctesting (#27262)



* fix

* update

* update

* fix

---------
Co-authored-by: default avatarydshieh <ydshieh@users.noreply.github.com>
parent 8f1a43cd
...@@ -54,7 +54,7 @@ def clean_doctest_list(doctest_file: str, overwrite: bool = False): ...@@ -54,7 +54,7 @@ def clean_doctest_list(doctest_file: str, overwrite: bool = False):
all_paths = [] all_paths = []
with open(doctest_file, "r", encoding="utf-8") as f: with open(doctest_file, "r", encoding="utf-8") as f:
for line in f: for line in f:
line = line.strip() line = line.strip().split(" ")[0]
path = os.path.join(REPO_PATH, line) path = os.path.join(REPO_PATH, line)
if not (os.path.isfile(path) or os.path.isdir(path)): if not (os.path.isfile(path) or os.path.isdir(path)):
non_existent_paths.append(line) non_existent_paths.append(line)
......
This diff is collapsed.
...@@ -387,7 +387,7 @@ def get_all_doctest_files() -> List[str]: ...@@ -387,7 +387,7 @@ def get_all_doctest_files() -> List[str]:
# These are files not doctested yet. # These are files not doctested yet.
with open("utils/not_doctested.txt") as fp: with open("utils/not_doctested.txt") as fp:
not_doctested = set(fp.read().strip().split("\n")) not_doctested = {x.split(" ")[0] for x in fp.read().strip().split("\n")}
# So far we don't have 100% coverage for doctest. This line will be removed once we achieve 100%. # So far we don't have 100% coverage for doctest. This line will be removed once we achieve 100%.
test_files_to_run = [x for x in test_files_to_run if x not in not_doctested] test_files_to_run = [x for x in test_files_to_run if x not in not_doctested]
...@@ -415,7 +415,9 @@ def get_new_doctest_files(repo, base_commit, branching_commit) -> List[str]: ...@@ -415,7 +415,9 @@ def get_new_doctest_files(repo, base_commit, branching_commit) -> List[str]:
with open(folder / "utils/not_doctested.txt", "r", encoding="utf-8") as f: with open(folder / "utils/not_doctested.txt", "r", encoding="utf-8") as f:
new_content = f.read() new_content = f.read()
# Compute the removed lines and return them # Compute the removed lines and return them
removed_content = set(old_content.split("\n")) - set(new_content.split("\n")) removed_content = {x.split(" ")[0] for x in old_content.split("\n")} - {
x.split(" ")[0] for x in new_content.split("\n")
}
return sorted(removed_content) return sorted(removed_content)
return [] return []
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment