"docs/vscode:/vscode.git/clone" did not exist on "5b49376202863d3798d2ff8a8ba61590542a1141"
Unverified Commit 8c4a1149 authored by amyeroberts's avatar amyeroberts Committed by GitHub
Browse files

Revert to and safely handle flag in owlvit config (#18750)

parent da5bb292
......@@ -131,7 +131,7 @@ class ImageFeatureExtractionMixin:
return image.convert("RGB")
def rescale_image(self, image: np.ndarray, scale: Union[float, int]) -> np.ndarray:
def rescale(self, image: np.ndarray, scale: Union[float, int]) -> np.ndarray:
"""
Rescale a numpy image by scale amount
"""
......@@ -163,7 +163,7 @@ class ImageFeatureExtractionMixin:
rescale = isinstance(image.flat[0], np.integer) if rescale is None else rescale
if rescale:
image = self.rescale_image(image.astype(np.float32), 1 / 255.0)
image = self.rescale(image.astype(np.float32), 1 / 255.0)
if channel_first and image.ndim == 3:
image = image.transpose(2, 0, 1)
......@@ -214,9 +214,9 @@ class ImageFeatureExtractionMixin:
# type it may need rescaling.
elif rescale:
if isinstance(image, np.ndarray):
image = self.rescale_image(image.astype(np.float32), 1 / 255.0)
image = self.rescale(image.astype(np.float32), 1 / 255.0)
elif is_torch_tensor(image):
image = self.rescale_image(image.float(), 1 / 255.0)
image = self.rescale(image.float(), 1 / 255.0)
if isinstance(image, np.ndarray):
if not isinstance(mean, np.ndarray):
......
......@@ -85,6 +85,13 @@ class OwlViTFeatureExtractor(FeatureExtractionMixin, ImageFeatureExtractionMixin
image_std=None,
**kwargs
):
# Early versions of the OWL-ViT config on the hub had "rescale" as a flag. This clashes with the
# vision feature extractor method `rescale` as it would be set as an attribute during the super().__init__
# call. This is for backwards compatibility.
if "rescale" in kwargs:
rescale_val = kwargs.pop("rescale")
kwargs["do_rescale"] = rescale_val
super().__init__(**kwargs)
self.size = size
self.resample = resample
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment