"...composable_kernel_rocm.git" did not exist on "da8324b6e3f47fe960ed95fc43ee4b6def0edb57"
Unverified Commit 7e1cb00c authored by Stas Bekman's avatar Stas Bekman Committed by GitHub
Browse files

[trainer] improve code readability (#8903)

* [trainer] improve code

This PR:
- removes redundant code 
```
self.model = model if model is not None else None
```
and
```
self.model = model
```
are the same.

* separate attribute assignment from code logic - which simplifies things further.

* whitespace
parent a8c3f9aa
...@@ -241,11 +241,12 @@ class Trainer: ...@@ -241,11 +241,12 @@ class Trainer:
self.hp_name = None self.hp_name = None
if model is None and model_init is not None: if model is None and model_init is not None:
model = self.call_model_init() model = self.call_model_init()
# Model parallel # Model parallel
if not self.args.model_parallel: if model is not None and not self.args.model_parallel:
self.model = model.to(args.device) if model is not None else None model = model.to(args.device)
else:
self.model = model if model is not None else None self.model = model
default_collator = default_data_collator if tokenizer is None else DataCollatorWithPadding(tokenizer) default_collator = default_data_collator if tokenizer is None else DataCollatorWithPadding(tokenizer)
self.data_collator = data_collator if data_collator is not None else default_collator self.data_collator = data_collator if data_collator is not None else default_collator
self.train_dataset = train_dataset self.train_dataset = train_dataset
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment