Logging propagation (#10092)

* Enable propagation by default * Document enable/disable default handler

Logging propagation (#10092)
* Enable propagation by default * Document enable/disable default handler
78f4a0e7 · Lysandre Debut · GitHub · 63fddcf6 · 78f4a0e7 · 78f4a0e7
Unverified Commit 78f4a0e7 authored Feb 09, 2021 by Lysandre Debut Committed by GitHub Feb 09, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

docs/source/main_classes/logging.rst docs/source/main_classes/logging.rst +4 -0

src/transformers/utils/logging.py src/transformers/utils/logging.py +0 -1

No files found.
--- a/docs/source/main_classes/logging.rst
+++ b/docs/source/main_classes/logging.rst
@@ -65,6 +65,10 @@ Other functions

 .. autofunction:: transformers.logging.get_logger

+.. autofunction:: transformers.logging.enable_default_handler
+
+.. autofunction:: transformers.logging.disable_default_handler
+
 .. autofunction:: transformers.logging.enable_explicit_format

 .. autofunction:: transformers.logging.reset_format
--- a/src/transformers/utils/logging.py
+++ b/src/transformers/utils/logging.py
@@ -85,7 +85,6 @@ def _configure_library_root_logger() -> None:
        library_root_logger = _get_library_root_logger()
        library_root_logger.addHandler(_default_handler)
        library_root_logger.setLevel(_get_default_logging_level())
-        library_root_logger.propagate = False


 def _reset_library_root_logger() -> None: