Unverified Commit 6657fb5f authored by Matthias Gerstgrasser's avatar Matthias Gerstgrasser Committed by GitHub
Browse files

Bugfix: WandbCallback uploads initial model checkpoint (#30897)

* fix wandb always uploading initial model

* Update comment.

* Optionally log initial model

* Revert "Optionally log initial model"

This reverts commit 9602cc1fad3feaf218f82a7339a194d3d2fbb946.
parent 6d3d5b10
...@@ -797,7 +797,7 @@ class WandbCallback(TrainerCallback): ...@@ -797,7 +797,7 @@ class WandbCallback(TrainerCallback):
except AttributeError: except AttributeError:
logger.info("Could not log the number of model parameters in Weights & Biases.") logger.info("Could not log the number of model parameters in Weights & Biases.")
# log the initial model and architecture to an artifact # log the initial model architecture to an artifact
with tempfile.TemporaryDirectory() as temp_dir: with tempfile.TemporaryDirectory() as temp_dir:
model_name = ( model_name = (
f"model-{self._wandb.run.id}" f"model-{self._wandb.run.id}"
...@@ -813,7 +813,6 @@ class WandbCallback(TrainerCallback): ...@@ -813,7 +813,6 @@ class WandbCallback(TrainerCallback):
"initial_model": True, "initial_model": True,
}, },
) )
model.save_pretrained(temp_dir)
# add the architecture to a separate text file # add the architecture to a separate text file
save_model_architecture_to_file(model, temp_dir) save_model_architecture_to_file(model, temp_dir)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment