Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
chenpangpang
transformers
Commits
5dd61fb9
"tests/vscode:/vscode.git/clone" did not exist on "d7280b74361695e38e04688b097bf1ab78e18bc3"
Commit
5dd61fb9
authored
Feb 11, 2020
by
sshleifer
Committed by
Lysandre Debut
Feb 11, 2020
Browse files
Add more specific testing advice to Contributing.md
parent
ee5de0ba
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
2 deletions
+5
-2
CONTRIBUTING.md
CONTRIBUTING.md
+5
-2
No files found.
CONTRIBUTING.md
View file @
5dd61fb9
...
@@ -198,8 +198,11 @@ Follow these steps to start contributing:
...
@@ -198,8 +198,11 @@ Follow these steps to start contributing:
3.
To indicate a work in progress please prefix the title with
`[WIP]`
. These
3.
To indicate a work in progress please prefix the title with
`[WIP]`
. These
are useful to avoid duplicated work, and to differentiate it from PRs ready
are useful to avoid duplicated work, and to differentiate it from PRs ready
to be merged;
to be merged;
4.
Make sure pre-existing tests still pass;
4.
Make sure existing tests pass;
5.
Add high-coverage tests. No quality test, no merge;
5.
Add high-coverage tests. No quality test, no merge.
If you are adding a new model, make sure that you use
`ModelTester.all_model_classes`
, which triggers the common tests.
If you are adding new
`@slow`
tests, make sure they pass using
`RUN_SLOW=1 python -m pytest tests/test_my_new_model.py`
.
CircleCI does not run them.
6.
All public methods must have informative docstrings;
6.
All public methods must have informative docstrings;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment