Unverified Commit 4c33a0c4 authored by Ilya's avatar Ilya Committed by GitHub
Browse files

Fix missing metrics with multiple eval datasets (#22536)

parent d7a4f5be
...@@ -2243,12 +2243,14 @@ class Trainer: ...@@ -2243,12 +2243,14 @@ class Trainer:
metrics = None metrics = None
if self.control.should_evaluate: if self.control.should_evaluate:
if isinstance(self.eval_dataset, dict): if isinstance(self.eval_dataset, dict):
metrics = {}
for eval_dataset_name, eval_dataset in self.eval_dataset.items(): for eval_dataset_name, eval_dataset in self.eval_dataset.items():
metrics = self.evaluate( dataset_metrics = self.evaluate(
eval_dataset=eval_dataset, eval_dataset=eval_dataset,
ignore_keys=ignore_keys_for_eval, ignore_keys=ignore_keys_for_eval,
metric_key_prefix=f"eval_{eval_dataset_name}", metric_key_prefix=f"eval_{eval_dataset_name}",
) )
metrics.update(dataset_metrics)
else: else:
metrics = self.evaluate(ignore_keys=ignore_keys_for_eval) metrics = self.evaluate(ignore_keys=ignore_keys_for_eval)
self._report_to_hp_search(trial, self.state.global_step, metrics) self._report_to_hp_search(trial, self.state.global_step, metrics)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment