Unverified Commit 4a27c13f authored by Marc Sun's avatar Marc Sun Committed by GitHub
Browse files

add warning for 8bit optimizers (#25575)

* add warning for 8bit optimizers

* protect import
parent 427adc89
......@@ -20,6 +20,7 @@ import contextlib
import copy
import functools
import glob
import importlib.metadata
import inspect
import math
import os
......@@ -133,6 +134,7 @@ from .utils import (
find_labels,
is_accelerate_available,
is_apex_available,
is_bitsandbytes_available,
is_datasets_available,
is_in_notebook,
is_ipex_available,
......@@ -1085,6 +1087,13 @@ class Trainer:
optimizer_kwargs.update(bnb_kwargs)
except ImportError:
raise ValueError("Trainer tried to instantiate bnb optimizer but bnb is not installed!")
if is_bitsandbytes_available() and version.parse(
importlib.metadata.version("bitsandbytes")
) < version.parse("0.41.1"):
logger.warning(
"You are using 8-bit optimizers with a version of `bitsandbytes` < 0.41.1. "
"It is recommended to update your version as a major bug has been fixed in 8-bit optimizers."
)
elif args.optim == OptimizerNames.ADAMW_ANYPRECISION:
try:
from torchdistx.optimizers import AnyPrecisionAdamW
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment