Skip to content

GitLab

Unverified Commit 0203d651 authored by Stas Bekman's avatar Stas Bekman Committed by GitHub
Browse files

[pl] restore lr logging behavior for glue, ner examples (#6314)

parent be1520d3
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 3 deletions
examples/lightning_base.py
View file @ 0203d651
...@@ -245,7 +245,8 @@ class BaseTransformer(pl.LightningModule): ...@@ -245,7 +245,8 @@ class BaseTransformer(pl.LightningModule):
class LoggingCallback(pl.Callback): class LoggingCallback(pl.Callback):
def on_batch_end(self, trainer, pl_module): def on_batch_end(self, trainer, pl_module):
lrs = {f"lr_group_{i}": param["lr"] for i, param in enumerate(pl_module.trainer.optimizers[0].param_groups)} lr_scheduler = trainer.lr_schedulers[0]["scheduler"]
lrs = {f"lr_group_{i}": lr for i, lr in enumerate(lr_scheduler.get_lr())}
pl_module.logger.log_metrics(lrs) pl_module.logger.log_metrics(lrs)
def on_validation_end(self, trainer: pl.Trainer, pl_module: pl.LightningModule): def on_validation_end(self, trainer: pl.Trainer, pl_module: pl.LightningModule):
......
examples/text-classification/run_pl_glue.py
View file @ 0203d651
...@@ -44,8 +44,8 @@ class GLUETransformer(BaseTransformer): ...@@ -44,8 +44,8 @@ class GLUETransformer(BaseTransformer):
outputs = self(**inputs) outputs = self(**inputs)
loss = outputs[0] loss = outputs[0]
# tensorboard_logs = {"loss": loss, "rate": self.lr_scheduler.get_last_lr()[-1]} lr_scheduler = self.trainer.lr_schedulers[0]["scheduler"]
tensorboard_logs = {"loss": loss} tensorboard_logs = {"loss": loss, "rate": lr_scheduler.get_last_lr()[-1]}
return {"loss": loss, "log": tensorboard_logs} return {"loss": loss, "log": tensorboard_logs}
def prepare_data(self): def prepare_data(self):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment