Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
chenpangpang
open-webui
Commits
33b96291
Commit
33b96291
authored
May 14, 2024
by
Jonathan Rohde
Browse files
fix: prevent loop when fetching shared chat id
parent
2290eefc
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
50 additions
and
1 deletion
+50
-1
cypress/e2e/chat.cy.ts
cypress/e2e/chat.cy.ts
+33
-0
src/lib/components/chat/ShareChatModal.svelte
src/lib/components/chat/ShareChatModal.svelte
+15
-1
src/lib/components/layout/Navbar.svelte
src/lib/components/layout/Navbar.svelte
+1
-0
src/lib/components/layout/Navbar/Menu.svelte
src/lib/components/layout/Navbar/Menu.svelte
+1
-0
No files found.
cypress/e2e/chat.cy.ts
View file @
33b96291
...
...
@@ -42,5 +42,38 @@ describe('Settings', () => {
.
find
(
'
div[aria-label="Generation Info"]
'
,
{
timeout
:
120
_000
})
// Generation Info is created after the stop token is received
.
should
(
'
exist
'
);
});
it
(
'
user can share chat
'
,
()
=>
{
// Click on the model selector
cy
.
get
(
'
button[aria-label="Select a model"]
'
).
click
();
// Select the first model
cy
.
get
(
'
button[aria-label="model-item"]
'
).
first
().
click
();
// Type a message
cy
.
get
(
'
#chat-textarea
'
).
type
(
'
Hi, what can you do? A single sentence only please.
'
,
{
force
:
true
});
// Send the message
cy
.
get
(
'
button[type="submit"]
'
).
click
();
// User's message should be visible
cy
.
get
(
'
.chat-user
'
).
should
(
'
exist
'
);
// Wait for the response
cy
.
get
(
'
.chat-assistant
'
,
{
timeout
:
120
_000
})
// .chat-assistant is created after the first token is received
.
find
(
'
div[aria-label="Generation Info"]
'
,
{
timeout
:
120
_000
})
// Generation Info is created after the stop token is received
.
should
(
'
exist
'
);
// spy on requests
const
spy
=
cy
.
spy
();
cy
.
intercept
(
"
GET
"
,
"
/api/v1/chats/*
"
,
spy
);
// Open context menu
cy
.
get
(
'
#chat-context-menu-button
'
).
click
();
// Click share button
cy
.
get
(
'
#chat-share-button
'
).
click
();
// Check if the share dialog is visible
cy
.
get
(
'
#copy-and-share-chat-button
'
).
should
(
'
exist
'
);
cy
.
wrap
({},
{
timeout
:
5000
})
.
should
(()
=>
{
// Check if the request was made twice (once for to replace chat object and once more due to change event)
expect
(
spy
).
to
.
be
.
callCount
(
2
);
});
});
});
});
src/lib/components/chat/ShareChatModal.svelte
View file @
33b96291
...
...
@@ -57,10 +57,23 @@
export let show = false;
const isDifferentChat = (_chat) => {
if (!chat) {
return true;
}
if (!_chat) {
return false;
}
return chat.id !== _chat.id || chat.share_id !== _chat.share_id;
}
$: if (show) {
(async () => {
if (chatId) {
chat = await getChatById(localStorage.token, chatId);
const _chat = await getChatById(localStorage.token, chatId);
if (isDifferentChat(_chat)) {
chat = _chat;
}
} else {
chat = null;
console.log(chat);
...
...
@@ -137,6 +150,7 @@
<button
class=" self-center flex items-center gap-1 px-3.5 py-2 rounded-xl text-sm font-medium bg-emerald-600 hover:bg-emerald-500 text-white"
type="button"
id="copy-and-share-chat-button"
on:click={async () => {
const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
...
...
src/lib/components/layout/Navbar.svelte
View file @
33b96291
...
...
@@ -82,6 +82,7 @@
>
<button
class="cursor-pointer p-1.5 flex dark:hover:bg-gray-700 rounded-full transition"
id="chat-context-menu-button"
>
<div class=" m-auto self-center">
<svg
...
...
src/lib/components/layout/Navbar/Menu.svelte
View file @
33b96291
...
...
@@ -113,6 +113,7 @@
{#if shareEnabled}
<DropdownMenu.Item
class="flex gap-2 items-center px-3 py-2 text-sm cursor-pointer dark:hover:bg-gray-850 rounded-md"
id="chat-share-button"
on:click={() => {
shareHandler();
}}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment