Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
change
sglang
Commits
fa2f677e
Unverified
Commit
fa2f677e
authored
Apr 21, 2025
by
fzyzcjy
Committed by
GitHub
Apr 20, 2025
Browse files
Fix torch memory saver not enabled in DP scenario (#5560)
parent
463d4b74
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
1 deletion
+7
-1
python/sglang/srt/managers/data_parallel_controller.py
python/sglang/srt/managers/data_parallel_controller.py
+7
-1
No files found.
python/sglang/srt/managers/data_parallel_controller.py
View file @
fa2f677e
...
@@ -30,6 +30,7 @@ from sglang.srt.managers.io_struct import (
...
@@ -30,6 +30,7 @@ from sglang.srt.managers.io_struct import (
)
)
from
sglang.srt.managers.scheduler
import
run_scheduler_process
from
sglang.srt.managers.scheduler
import
run_scheduler_process
from
sglang.srt.server_args
import
PortArgs
,
ServerArgs
from
sglang.srt.server_args
import
PortArgs
,
ServerArgs
from
sglang.srt.torch_memory_saver_adapter
import
TorchMemorySaverAdapter
from
sglang.srt.utils
import
bind_port
,
configure_logger
,
get_zmq_socket
from
sglang.srt.utils
import
bind_port
,
configure_logger
,
get_zmq_socket
from
sglang.utils
import
get_exception_traceback
from
sglang.utils
import
get_exception_traceback
...
@@ -174,6 +175,10 @@ class DataParallelController:
...
@@ -174,6 +175,10 @@ class DataParallelController:
if
not
server_args
.
enable_dp_attention
:
if
not
server_args
.
enable_dp_attention
:
logger
.
info
(
f
"Launch DP
{
dp_rank
}
starting at GPU #
{
base_gpu_id
}
."
)
logger
.
info
(
f
"Launch DP
{
dp_rank
}
starting at GPU #
{
base_gpu_id
}
."
)
memory_saver_adapter
=
TorchMemorySaverAdapter
.
create
(
enable
=
server_args
.
enable_memory_saver
)
# Launch tensor parallel scheduler processes
# Launch tensor parallel scheduler processes
scheduler_pipe_readers
=
[]
scheduler_pipe_readers
=
[]
tp_size_per_node
=
server_args
.
tp_size
//
server_args
.
nnodes
tp_size_per_node
=
server_args
.
tp_size
//
server_args
.
nnodes
...
@@ -208,7 +213,8 @@ class DataParallelController:
...
@@ -208,7 +213,8 @@ class DataParallelController:
target
=
run_scheduler_process
,
target
=
run_scheduler_process
,
args
=
(
server_args
,
rank_port_args
,
gpu_id
,
tp_rank
,
dp_rank
,
writer
),
args
=
(
server_args
,
rank_port_args
,
gpu_id
,
tp_rank
,
dp_rank
,
writer
),
)
)
proc
.
start
()
with
memory_saver_adapter
.
configure_subprocess
():
proc
.
start
()
self
.
scheduler_procs
.
append
(
proc
)
self
.
scheduler_procs
.
append
(
proc
)
scheduler_pipe_readers
.
append
(
reader
)
scheduler_pipe_readers
.
append
(
reader
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment