Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
change
sglang
Commits
5994e6c3
Unverified
Commit
5994e6c3
authored
Oct 26, 2025
by
Liangsheng Yin
Committed by
GitHub
Oct 26, 2025
Browse files
Do not use `MagicMock` to mock `server_args` in tests (#12154)
parent
3e6281d0
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
14 deletions
+14
-14
test/srt/test_server_args.py
test/srt/test_server_args.py
+14
-14
No files found.
test/srt/test_server_args.py
View file @
5994e6c3
import
json
import
json
import
unittest
import
unittest
from
unittest.mock
import
MagicMock
,
patch
from
unittest.mock
import
patch
from
sglang.srt.server_args
import
PortArgs
,
prepare_server_args
from
sglang.srt.server_args
import
PortArgs
,
ServerArgs
,
prepare_server_args
from
sglang.test.test_utils
import
CustomTestCase
from
sglang.test.test_utils
import
CustomTestCase
...
@@ -32,7 +32,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -32,7 +32,7 @@ class TestPortArgs(unittest.TestCase):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
mock_temp_file
.
return_value
.
name
=
"temp_file"
mock_temp_file
.
return_value
.
name
=
"temp_file"
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
server_args
.
enable_dp_attention
=
False
server_args
.
enable_dp_attention
=
False
...
@@ -48,7 +48,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -48,7 +48,7 @@ class TestPortArgs(unittest.TestCase):
def
test_init_new_with_single_node_dp_attention
(
self
,
mock_is_port_available
):
def
test_init_new_with_single_node_dp_attention
(
self
,
mock_is_port_available
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
server_args
.
enable_dp_attention
=
True
server_args
.
enable_dp_attention
=
True
...
@@ -68,7 +68,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -68,7 +68,7 @@ class TestPortArgs(unittest.TestCase):
def
test_init_new_with_dp_rank
(
self
,
mock_is_port_available
):
def
test_init_new_with_dp_rank
(
self
,
mock_is_port_available
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
server_args
.
enable_dp_attention
=
True
server_args
.
enable_dp_attention
=
True
...
@@ -88,7 +88,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -88,7 +88,7 @@ class TestPortArgs(unittest.TestCase):
def
test_init_new_with_ipv4_address
(
self
,
mock_is_port_available
):
def
test_init_new_with_ipv4_address
(
self
,
mock_is_port_available
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -110,7 +110,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -110,7 +110,7 @@ class TestPortArgs(unittest.TestCase):
def
test_init_new_with_malformed_ipv4_address
(
self
,
mock_is_port_available
):
def
test_init_new_with_malformed_ipv4_address
(
self
,
mock_is_port_available
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -131,7 +131,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -131,7 +131,7 @@ class TestPortArgs(unittest.TestCase):
):
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -149,7 +149,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -149,7 +149,7 @@ class TestPortArgs(unittest.TestCase):
):
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -175,7 +175,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -175,7 +175,7 @@ class TestPortArgs(unittest.TestCase):
):
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -194,7 +194,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -194,7 +194,7 @@ class TestPortArgs(unittest.TestCase):
):
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -214,7 +214,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -214,7 +214,7 @@ class TestPortArgs(unittest.TestCase):
):
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -236,7 +236,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -236,7 +236,7 @@ class TestPortArgs(unittest.TestCase):
):
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
@@ -256,7 +256,7 @@ class TestPortArgs(unittest.TestCase):
...
@@ -256,7 +256,7 @@ class TestPortArgs(unittest.TestCase):
):
):
mock_is_port_available
.
return_value
=
True
mock_is_port_available
.
return_value
=
True
server_args
=
MagicMock
(
)
server_args
=
ServerArgs
(
model_path
=
"dummy"
)
server_args
.
port
=
30000
server_args
.
port
=
30000
server_args
.
nccl_port
=
None
server_args
.
nccl_port
=
None
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment