Unverified Commit 22cbc9c0 authored by Simo Lin's avatar Simo Lin Committed by GitHub
Browse files

[bugs] docker file name should be <name>.Dockerfile so it can properly render (#11869)

parent 3865afc5
...@@ -47,7 +47,7 @@ jobs: ...@@ -47,7 +47,7 @@ jobs:
docker build \ docker build \
${PR_REPO:+--build-arg SGLANG_REPO=$PR_REPO} \ ${PR_REPO:+--build-arg SGLANG_REPO=$PR_REPO} \
${PR_HEAD_REF:+--build-arg VER_SGLANG=$PR_HEAD_REF} \ ${PR_HEAD_REF:+--build-arg VER_SGLANG=$PR_HEAD_REF} \
. -f docker/Dockerfile.xeon -t sglang_xeon --no-cache . -f docker/xeon.Dockerfile -t sglang_xeon --no-cache
- name: Run container - name: Run container
run: | run: |
......
...@@ -46,7 +46,7 @@ jobs: ...@@ -46,7 +46,7 @@ jobs:
docker build \ docker build \
${PR_REPO:+--build-arg SG_LANG_REPO=$PR_REPO} \ ${PR_REPO:+--build-arg SG_LANG_REPO=$PR_REPO} \
${PR_HEAD_REF:+--build-arg SG_LANG_BRANCH=$PR_HEAD_REF} \ ${PR_HEAD_REF:+--build-arg SG_LANG_BRANCH=$PR_HEAD_REF} \
--no-cache --progress=plain -f docker/Dockerfile.xpu -t xpu_sglang_main:bmg . --no-cache --progress=plain -f docker/xpu.Dockerfile -t xpu_sglang_main:bmg .
- name: Run container - name: Run container
id: start_container id: start_container
......
...@@ -61,7 +61,7 @@ jobs: ...@@ -61,7 +61,7 @@ jobs:
exit 1 exit 1
fi fi
docker build . -f docker/Dockerfile.rocm --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t rocm/sgl-dev:${tag}-${{ env.DATE }}${tag_suffix} --no-cache docker build . -f docker/rocm.Dockerfile --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t rocm/sgl-dev:${tag}-${{ env.DATE }}${tag_suffix} --no-cache
docker push rocm/sgl-dev:${tag}-${{ env.DATE }}${tag_suffix} docker push rocm/sgl-dev:${tag}-${{ env.DATE }}${tag_suffix}
cache: cache:
......
...@@ -52,5 +52,5 @@ jobs: ...@@ -52,5 +52,5 @@ jobs:
exit 1 exit 1
fi fi
docker build . -f docker/Dockerfile.rocm --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t lmsysorg/sglang:${tag}${tag_suffix} --no-cache docker build . -f docker/rocm.Dockerfile --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t lmsysorg/sglang:${tag}${tag_suffix} --no-cache
docker push lmsysorg/sglang:${tag}${tag_suffix} docker push lmsysorg/sglang:${tag}${tag_suffix}
...@@ -5,7 +5,7 @@ on: ...@@ -5,7 +5,7 @@ on:
- main - main
paths: paths:
- ".github/workflows/release-docker-npu-nightly.yml" - ".github/workflows/release-docker-npu-nightly.yml"
- "docker/Dockerfile.npu" - "docker/npu.Dockerfile"
workflow_dispatch: workflow_dispatch:
schedule: schedule:
- cron: "0 0 * * *" - cron: "0 0 * * *"
...@@ -65,7 +65,7 @@ jobs: ...@@ -65,7 +65,7 @@ jobs:
uses: docker/build-push-action@v6 uses: docker/build-push-action@v6
with: with:
context: docker context: docker
file: docker/Dockerfile.npu file: docker/npu.Dockerfile
# TODO: need add x86 platforms support when memfabric is ready # TODO: need add x86 platforms support when memfabric is ready
platforms: linux/arm64 platforms: linux/arm64
labels: ${{ steps.meta.outputs.labels }} labels: ${{ steps.meta.outputs.labels }}
......
...@@ -9,7 +9,7 @@ on: ...@@ -9,7 +9,7 @@ on:
- main - main
paths: paths:
- ".github/workflows/release-docker-npu.yml" - ".github/workflows/release-docker-npu.yml"
- "docker/Dockerfile.npu" - "docker/npu.Dockerfile"
jobs: jobs:
build: build:
...@@ -61,7 +61,7 @@ jobs: ...@@ -61,7 +61,7 @@ jobs:
uses: docker/build-push-action@v6 uses: docker/build-push-action@v6
with: with:
context: docker context: docker
file: docker/Dockerfile.npu file: docker/npu.Dockerfile
# TODO: need add x86 platforms support when memfabric is ready # TODO: need add x86 platforms support when memfabric is ready
platforms: linux/arm64 platforms: linux/arm64
labels: ${{ steps.meta.outputs.labels }} labels: ${{ steps.meta.outputs.labels }}
......
...@@ -26,5 +26,5 @@ jobs: ...@@ -26,5 +26,5 @@ jobs:
version=$(cat sgl-router/py_src/sglang_router/version.py | cut -d'"' -f2) version=$(cat sgl-router/py_src/sglang_router/version.py | cut -d'"' -f2)
tag=v${version} tag=v${version}
docker build . -f docker/Dockerfile.router -t lmsysorg/sglang-router:${tag} --no-cache docker build . -f docker/router.Dockerfile -t lmsysorg/sglang-router:${tag} --no-cache
docker push lmsysorg/sglang-router:${tag} docker push lmsysorg/sglang-router:${tag}
...@@ -31,5 +31,5 @@ jobs: ...@@ -31,5 +31,5 @@ jobs:
version=$(cat python/sglang/version.py | cut -d'"' -f2) version=$(cat python/sglang/version.py | cut -d'"' -f2)
tag=v${version}-xeon tag=v${version}-xeon
docker build . -f docker/Dockerfile.xeon -t lmsysorg/sglang:${tag} --no-cache docker build . -f docker/xeon.Dockerfile -t lmsysorg/sglang:${tag} --no-cache
docker push lmsysorg/sglang:${tag} docker push lmsysorg/sglang:${tag}
# Usage (to build SGLang ROCm docker image): # Usage (to build SGLang ROCm docker image):
# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942 -t v0.5.4-rocm630-mi30x -f Dockerfile.rocm . # docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942 -t v0.5.4-rocm630-mi30x -f rocm.Dockerfile .
# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942-rocm700 -t v0.5.4-rocm700-mi30x -f Dockerfile.rocm . # docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942-rocm700 -t v0.5.4-rocm700-mi30x -f rocm.Dockerfile .
# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx950 -t v0.5.4-rocm700-mi35x -f Dockerfile.rocm . # docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx950 -t v0.5.4-rocm700-mi35x -f rocm.Dockerfile .
# Default base images # Default base images
......
# If the device is Battlemage, we need to set UBUNTU_VERSION to 24.10 # If the device is Battlemage, we need to set UBUNTU_VERSION to 24.10
# Usage: docker build --build-arg UBUNTU_VERSION=24.04 --build-arg PYTHON_VERSION=3.10 -t sglang:xpu_kernel -f Dockerfile.xpu --no-cache . # Usage: docker build --build-arg UBUNTU_VERSION=24.04 --build-arg PYTHON_VERSION=3.10 -t sglang:xpu_kernel -f xpu.Dockerfile --no-cache .
# Use Intel deep learning essentials base image with Ubuntu 24.04 # Use Intel deep learning essentials base image with Ubuntu 24.04
FROM intel/deep-learning-essentials:2025.1.3-0-devel-ubuntu24.04 FROM intel/deep-learning-essentials:2025.1.3-0-devel-ubuntu24.04
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment