Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
change
sglang
Commits
0f6ac5e2
Unverified
Commit
0f6ac5e2
authored
Sep 06, 2025
by
Adam Yanxiao Zhao
Committed by
GitHub
Sep 05, 2025
Browse files
[Bug Fix] Fix Glm4vVisionBlock norm (#9884)
parent
29850900
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
python/sglang/srt/models/glm4v.py
python/sglang/srt/models/glm4v.py
+1
-2
python/sglang/srt/models/qwen2_5_vl.py
python/sglang/srt/models/qwen2_5_vl.py
+3
-2
No files found.
python/sglang/srt/models/glm4v.py
View file @
0f6ac5e2
...
...
@@ -93,9 +93,8 @@ class Glm4vVisionBlock(Qwen2_5_VisionBlock):
quant_config
=
quant_config
,
prefix
=
prefix
,
num_dummy_heads
=
config
.
num_dummy_heads
,
rms_norm_eps
=
config
.
rms_norm_eps
,
)
self
.
norm1
=
Glm4vRMSNorm
(
config
.
hidden_size
,
eps
=
config
.
rms_norm_eps
)
self
.
norm2
=
Glm4vRMSNorm
(
config
.
hidden_size
,
eps
=
config
.
rms_norm_eps
)
self
.
mlp
=
Glm4vVisionMLP
(
config
.
hidden_size
,
...
...
python/sglang/srt/models/qwen2_5_vl.py
View file @
0f6ac5e2
...
...
@@ -113,12 +113,13 @@ class Qwen2_5_VisionBlock(nn.Module):
quant_config
:
Optional
[
QuantizationConfig
]
=
None
,
prefix
:
str
=
""
,
num_dummy_heads
:
int
=
0
,
rms_norm_eps
:
float
=
1e-6
,
)
->
None
:
super
().
__init__
()
if
norm_layer
is
None
:
norm_layer
=
partial
(
nn
.
LayerNorm
,
eps
=
1e-6
)
self
.
norm1
=
RMSNorm
(
dim
,
eps
=
1e-6
)
self
.
norm2
=
RMSNorm
(
dim
,
eps
=
1e-6
)
self
.
norm1
=
RMSNorm
(
dim
,
eps
=
rms_norm_eps
)
self
.
norm2
=
RMSNorm
(
dim
,
eps
=
rms_norm_eps
)
if
attn_implementation
is
None
:
softmax_in_single_precision
=
False
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment