cache_aware.rs 19.5 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
/*
    Cache-Aware Load Balancing Router

    This router combines two strategies to optimize both cache utilization and request distribution:

    1. Cache-Aware Routing (Approximate Tree)
    2. Load Balancing (Shortest Queue with Balance Thresholds)

    The router dynamically switches between these strategies based on load conditions:
    - Uses load balancing when the system is imbalanced
    - Uses cache-aware routing when the system is balanced

    A system is considered imbalanced if both conditions are met:
    1. (max - min) > abs_threshold
    2. max > rel_threshold * min

    Strategy Details:

    1. Cache-Aware Routing (Approximate Tree)
    -------------------------------------------
    This strategy maintains an approximate radix tree for each worker based on request history,
    eliminating the need for direct cache state queries. The tree stores raw text characters
    instead of token IDs to avoid tokenization overhead.

    Process:
    a. For each request, find the worker with the highest prefix match
    b. If match rate > cache_threshold:
    Route to the worker with highest match (likely has relevant data cached)
    c. If match rate ≤ cache_threshold:
    Route to the worker with smallest tree size (most available cache capacity)
    d. Background maintenance:
    Periodically evict least recently used leaf nodes to prevent memory overflow

    2. Load Balancing (Shortest Queue)
    -------------------------------------------
    This strategy tracks pending request counts per worker and routes new requests
    to the least busy worker when the system is detected to be imbalanced.

    Configuration Parameters:
    ------------------------
    1. cache_threshold: (float, 0.0 to 1.0)
    Minimum prefix match ratio to use highest-match routing.
    Below this threshold, routes to worker with most available cache space.

    2. balance_abs_threshold: (integer)
    Absolute difference threshold for load imbalance detection.
    System is potentially imbalanced if (max_load - min_load) > abs_threshold

    3. balance_rel_threshold: (float)
    Relative ratio threshold for load imbalance detection.
    System is potentially imbalanced if max_load > min_load * rel_threshold
    Used in conjunction with abs_threshold to determine final imbalance state.

    4. eviction_interval_secs: (integer)
    Interval between LRU eviction cycles for the approximate trees.

    5. max_tree_size: (integer)
    Maximum nodes per tree. When exceeded, LRU leaf nodes are evicted
    during the next eviction cycle.
*/

use super::{get_healthy_worker_indices, CacheAwareConfig, LoadBalancingPolicy};
use crate::core::Worker;
64
use crate::metrics::RouterMetrics;
65
use crate::tree::Tree;
66
use std::collections::HashMap;
67
68
69
use std::sync::{Arc, Mutex};
use std::thread;
use std::time::Duration;
70
use tracing::debug;
71
72
73
74
75

/// Cache-aware routing policy
///
/// Routes requests based on cache affinity when load is balanced,
/// switches to shortest-queue routing when load is imbalanced.
76
/// Maintains separate trees per model for multi-model support.
77
78
79
#[derive(Debug)]
pub struct CacheAwarePolicy {
    config: CacheAwareConfig,
80
    trees: Arc<Mutex<HashMap<String, Tree>>>, // model_id -> Tree
81
82
83
84
85
86
87
88
89
    eviction_handle: Option<thread::JoinHandle<()>>,
}

impl CacheAwarePolicy {
    pub fn new() -> Self {
        Self::with_config(CacheAwareConfig::default())
    }

    pub fn with_config(config: CacheAwareConfig) -> Self {
90
        let trees = Arc::new(Mutex::new(HashMap::<String, Tree>::new()));
91
92
93

        // Start background eviction thread if configured
        let eviction_handle = if config.eviction_interval_secs > 0 {
94
            let trees_clone = Arc::clone(&trees);
95
96
97
98
99
100
            let max_tree_size = config.max_tree_size;
            let interval = config.eviction_interval_secs;

            Some(thread::spawn(move || loop {
                thread::sleep(Duration::from_secs(interval));

101
102
103
104
105
106
107
108
109
                if let Ok(mut trees_guard) = trees_clone.lock() {
                    // Evict for all model trees
                    for (model_id, tree) in trees_guard.iter_mut() {
                        tree.evict_tenant_by_size(max_tree_size);
                        debug!(
                            "Cache eviction completed for model {}, max_size: {}",
                            model_id, max_tree_size
                        );
                    }
110
111
112
113
114
115
116
117
                }
            }))
        } else {
            None
        };

        Self {
            config,
118
            trees,
119
120
121
122
            eviction_handle,
        }
    }

123
    /// Initialize the tree with worker URLs (used only during initial setup)
124
125
126
127
    pub fn init_workers(&self, workers: &[Arc<dyn Worker>]) {
        if let Ok(mut trees) = self.trees.lock() {
            // Group workers by model
            let mut model_workers: HashMap<String, Vec<&Arc<dyn Worker>>> = HashMap::new();
128
            for worker in workers {
129
130
131
                // Use "default" for unknown/empty model_ids for backward compatibility
                let model_id = worker.model_id();
                let tree_key = if model_id.is_empty() || model_id == "unknown" {
132
                    "default"
133
                } else {
134
                    model_id
135
                };
136
137
138
139
                model_workers
                    .entry(tree_key.to_string())
                    .or_default()
                    .push(worker);
140
141
142
143
144
145
146
147
            }

            // Initialize tree for each model
            for (tree_key, model_workers) in model_workers {
                let tree = trees.entry(tree_key).or_insert_with(Tree::new);
                for worker in model_workers {
                    tree.insert("", worker.url());
                }
148
149
150
151
            }
        }
    }

152
    /// Add a single worker to the tree (incremental update)
153
154
155
156
157
158
    pub fn add_worker(&self, worker: &dyn Worker) {
        if let Ok(mut trees) = self.trees.lock() {
            // For backward compatibility: if model_id is "unknown" or empty,
            // use a default tree. This preserves existing behavior for single-model routers.
            let model_id = worker.model_id();
            let tree_key = if model_id.is_empty() || model_id == "unknown" {
159
                "default"
160
            } else {
161
                model_id
162
            };
163
            let tree = trees.entry(tree_key.to_string()).or_insert_with(Tree::new);
164
165
166
167
168
169
170
171
            tree.insert("", worker.url());
        }
    }

    /// Add a worker by URL and model (for backward compatibility)
    pub fn add_worker_by_url(&self, url: &str, model_id: &str) {
        if let Ok(mut trees) = self.trees.lock() {
            let tree = trees.entry(model_id.to_string()).or_insert_with(Tree::new);
172
173
174
175
            tree.insert("", url);
        }
    }

176
    /// Remove a worker from the tree
177
178
179
180
181
    pub fn remove_worker(&self, worker: &dyn Worker) {
        if let Ok(mut trees) = self.trees.lock() {
            // Use same logic as add_worker for consistency
            let model_id = worker.model_id();
            let tree_key = if model_id.is_empty() || model_id == "unknown" {
182
                "default"
183
            } else {
184
                model_id
185
            };
186
            if let Some(tree) = trees.get_mut(tree_key) {
187
188
189
190
191
192
193
194
195
196
197
198
                tree.remove_tenant(worker.url());
            }
        }
    }

    /// Remove a worker by URL (removes from all model trees for backward compatibility)
    pub fn remove_worker_by_url(&self, url: &str) {
        if let Ok(mut trees) = self.trees.lock() {
            // Remove from all trees since we don't know which model it belongs to
            for (_model_id, tree) in trees.iter_mut() {
                tree.remove_tenant(url);
            }
199
200
201
202
203
        }
    }

    /// Run cache eviction to prevent unbounded growth
    pub fn evict_cache(&self, max_size: usize) {
204
205
206
207
208
209
210
211
        if let Ok(mut trees) = self.trees.lock() {
            for (model_id, tree) in trees.iter_mut() {
                tree.evict_tenant_by_size(max_size);
                debug!(
                    "Cache eviction for model {}, max_size: {}",
                    model_id, max_size
                );
            }
212
213
214
215
216
217
218
        }
    }
}

impl LoadBalancingPolicy for CacheAwarePolicy {
    fn select_worker(
        &self,
219
        workers: &[Arc<dyn Worker>],
220
221
222
223
224
225
226
227
        request_text: Option<&str>,
    ) -> Option<usize> {
        let healthy_indices = get_healthy_worker_indices(workers);

        if healthy_indices.is_empty() {
            return None;
        }

228
229
230
231
232
233
234
235
        // Determine the model for this set of workers (router pre-filters by model)
        // All workers should be from the same model
        let first_model = workers[healthy_indices[0]].model_id();
        let model_id = if first_model.is_empty() || first_model == "unknown" {
            "default"
        } else {
            first_model
        };
236

237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
        // Get current load statistics
        let loads: Vec<usize> = workers.iter().map(|w| w.load()).collect();
        let max_load = *loads.iter().max().unwrap_or(&0);
        let min_load = *loads.iter().min().unwrap_or(&0);

        // Check if load is imbalanced
        let is_imbalanced = max_load.saturating_sub(min_load) > self.config.balance_abs_threshold
            && (max_load as f32) > (min_load as f32 * self.config.balance_rel_threshold);

        if is_imbalanced {
            // Log load balancing trigger
            let worker_loads: Vec<(String, usize)> = workers
                .iter()
                .map(|w| (w.url().to_string(), w.load()))
                .collect();

253
254
            debug!(
                "Load balancing triggered | max: {} | min: {} | workers: {:?}",
255
256
257
                max_load, min_load, worker_loads
            );

258
259
            RouterMetrics::record_load_balancing_event();
            RouterMetrics::set_load_range(max_load, min_load);
260
261
262
263
264
265
266

            // Use shortest queue when imbalanced
            let min_load_idx = healthy_indices
                .iter()
                .min_by_key(|&&idx| workers[idx].load())
                .copied()?;

267
268
            // Even in imbalanced mode, update the tree to maintain cache state
            if let Some(text) = request_text {
269
                if let Ok(mut trees) = self.trees.lock() {
270
271
272
                    // Avoid allocation if tree already exists
                    let tree = if let Some(tree) = trees.get_mut(model_id) {
                        tree
273
                    } else {
274
275
276
277
278
279
280
                        // Create new tree and initialize with all workers
                        let new_tree = Tree::new();
                        // Initialize with all healthy workers like OLD version does
                        for &idx in &healthy_indices {
                            new_tree.insert("", workers[idx].url());
                        }
                        trees.entry(model_id.to_string()).or_insert(new_tree)
281
                    };
282
283
284
285
                    tree.insert(text, workers[min_load_idx].url());
                }
            }

286
287
            // Increment processed counter
            workers[min_load_idx].increment_processed();
288
            RouterMetrics::record_processed_request(workers[min_load_idx].url());
289
            RouterMetrics::record_policy_decision(self.name(), workers[min_load_idx].url());
290
291
292
293
294
295
296

            return Some(min_load_idx);
        }

        // Use cache-aware routing when balanced
        let text = request_text.unwrap_or("");

297
        if let Ok(mut trees) = self.trees.lock() {
298
299
300
301
302
303
304
305
306
            // Avoid allocation if tree already exists
            let tree = if let Some(tree) = trees.get_mut(model_id) {
                tree
            } else {
                // Create new tree and initialize with all workers
                let new_tree = Tree::new();
                // Initialize with all healthy workers like OLD version does
                for &idx in &healthy_indices {
                    new_tree.insert("", workers[idx].url());
307
                }
308
309
310
311
312
313
314
315
                trees.entry(model_id.to_string()).or_insert(new_tree)
            };
            let (matched_text, matched_worker) = tree.prefix_match(text);
            let match_rate = if text.is_empty() {
                0.0
            } else {
                matched_text.chars().count() as f32 / text.chars().count() as f32
            };
316

317
            let selected_url = if match_rate > self.config.cache_threshold {
318
                RouterMetrics::record_cache_hit();
319
                matched_worker.to_string()
320
            } else {
321
                RouterMetrics::record_cache_miss();
322
323
                tree.get_smallest_tenant()
            };
324

325
326
327
328
329
330
            // Find the index of the selected worker
            if let Some(selected_idx) = workers.iter().position(|w| w.url() == selected_url) {
                // Only proceed if the worker is healthy - use direct check like OLD version
                if workers[selected_idx].is_healthy() {
                    // Update the tree with this request
                    tree.insert(text, &selected_url);
331

332
333
334
                    // Increment processed counter
                    workers[selected_idx].increment_processed();
                    RouterMetrics::record_processed_request(&selected_url);
335

336
                    return Some(selected_idx);
337
338
                }
            } else {
339
340
341
342
                // Selected worker no longer exists, remove it from tree
                tree.remove_tenant(&selected_url);
                debug!("Removed stale worker {} from cache tree", selected_url);
            }
343

344
345
            // Fallback to first healthy worker
            return healthy_indices.first().copied();
346
347
348
349
350
351
352
353
354
355
        }

        // Fallback to first healthy worker if tree operations fail
        healthy_indices.first().copied()
    }

    fn name(&self) -> &'static str {
        "cache_aware"
    }

356
357
358
359
    fn needs_request_text(&self) -> bool {
        true // Cache-aware policy needs request text for cache affinity
    }

360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
    fn on_request_complete(&self, worker_url: &str, success: bool) {
        // Could track success rates per worker for more intelligent routing
        if !success {
            // Optionally reduce affinity for failed requests
            tracing::debug!(
                "Request to {} completed with success={}",
                worker_url,
                success
            );
        }
    }

    fn as_any(&self) -> &dyn std::any::Any {
        self
    }

    fn select_worker_pair(
        &self,
378
379
        prefill_workers: &[Arc<dyn Worker>],
        decode_workers: &[Arc<dyn Worker>],
380
381
        request_text: Option<&str>,
    ) -> Option<(usize, usize)> {
382
383
384
385
386
        // DEPRECATED: This method is no longer used when separate policies are configured.
        // The PD router now uses separate policies for prefill and decode selection.
        // This implementation remains for backward compatibility when a single policy is used.

        // In PD mode with single policy:
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
        // - Prefill: Use cache-aware routing for better cache utilization
        // - Decode: Use least-load routing for better load distribution

        // Select prefill worker using cache-aware logic
        let prefill_idx = self.select_worker(prefill_workers, request_text)?;

        // Select decode worker using least-load logic
        let healthy_decode = get_healthy_worker_indices(decode_workers);
        if healthy_decode.is_empty() {
            return None;
        }

        let decode_idx = healthy_decode
            .iter()
            .min_by_key(|&&idx| decode_workers[idx].load())
            .copied()?;

        Some((prefill_idx, decode_idx))
    }
}

impl Default for CacheAwarePolicy {
    fn default() -> Self {
        Self::new()
    }
}

impl Drop for CacheAwarePolicy {
    fn drop(&mut self) {
        // Note: We can't properly stop the eviction thread since it's in an infinite loop
        // In a production system, we'd use a channel or atomic flag to signal shutdown
        if let Some(handle) = self.eviction_handle.take() {
            // The thread will continue running until the program exits
            // This is acceptable for now since the router typically runs for the lifetime of the program
            drop(handle);
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
429
    use crate::core::{BasicWorkerBuilder, WorkerType};
430
431
432
433
434
435
436
437
438

    #[test]
    fn test_cache_aware_with_balanced_load() {
        // Create policy without eviction thread for testing
        let config = CacheAwareConfig {
            eviction_interval_secs: 0, // Disable eviction thread
            ..Default::default()
        };
        let policy = CacheAwarePolicy::with_config(config);
439
        let workers: Vec<Arc<dyn Worker>> = vec![
440
441
442
            Arc::new(
                BasicWorkerBuilder::new("http://w1:8000")
                    .worker_type(WorkerType::Regular)
443
                    .api_key("test_api_key")
444
445
446
447
448
                    .build(),
            ),
            Arc::new(
                BasicWorkerBuilder::new("http://w2:8000")
                    .worker_type(WorkerType::Regular)
449
                    .api_key("test_api_key")
450
451
                    .build(),
            ),
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
        ];

        // Initialize the policy with workers
        policy.init_workers(&workers);

        // First request should be distributed
        let idx1 = policy.select_worker(&workers, Some("hello world")).unwrap();

        // Same request should go to same worker (cache hit)
        let idx2 = policy.select_worker(&workers, Some("hello world")).unwrap();
        assert_eq!(idx1, idx2);

        // Similar request should also go to same worker
        let idx3 = policy.select_worker(&workers, Some("hello")).unwrap();
        assert_eq!(idx1, idx3);
    }

    #[test]
    fn test_cache_aware_with_imbalanced_load() {
        let policy = CacheAwarePolicy::with_config(CacheAwareConfig {
            cache_threshold: 0.5,
            balance_abs_threshold: 5,
            balance_rel_threshold: 2.0,
            eviction_interval_secs: 0, // Disable eviction thread
            max_tree_size: 10000,
        });

479
480
481
482
483
484
        let worker1 = BasicWorkerBuilder::new("http://w1:8000")
            .worker_type(WorkerType::Regular)
            .build();
        let worker2 = BasicWorkerBuilder::new("http://w2:8000")
            .worker_type(WorkerType::Regular)
            .build();
485
486
487
488
489
490
491

        // Create significant load imbalance
        for _ in 0..20 {
            worker1.increment_load();
        }
        // worker2 has load 0

492
        let workers: Vec<Arc<dyn Worker>> = vec![Arc::new(worker1), Arc::new(worker2)];
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
        policy.init_workers(&workers);

        // Should select worker2 (lower load) despite cache affinity
        for _ in 0..5 {
            let idx = policy.select_worker(&workers, Some("test")).unwrap();
            assert_eq!(idx, 1); // Should always pick worker2
        }
    }

    #[test]
    fn test_cache_aware_worker_removal() {
        let config = CacheAwareConfig {
            eviction_interval_secs: 0, // Disable eviction thread
            ..Default::default()
        };
        let policy = CacheAwarePolicy::with_config(config);
509
        let workers: Vec<Arc<dyn Worker>> = vec![
510
511
512
513
514
515
516
517
518
519
            Arc::new(
                BasicWorkerBuilder::new("http://w1:8000")
                    .worker_type(WorkerType::Regular)
                    .build(),
            ),
            Arc::new(
                BasicWorkerBuilder::new("http://w2:8000")
                    .worker_type(WorkerType::Regular)
                    .build(),
            ),
520
521
522
523
524
525
526
527
528
        ];

        policy.init_workers(&workers);

        // Route some requests
        policy.select_worker(&workers, Some("test1"));
        policy.select_worker(&workers, Some("test2"));

        // Remove a worker
529
        policy.remove_worker_by_url("http://w1:8000");
530
531
532
533
534
535
536
        workers[0].set_healthy(false);

        // All requests should now go to worker2
        let idx = policy.select_worker(&workers, Some("test1")).unwrap();
        assert_eq!(idx, 1);
    }
}