router.rs 45.7 KB
Newer Older
1
2
use crate::pd_router::PDRouter;
use crate::pd_types::PDSelectionPolicy;
3
use crate::tree::Tree;
4
use ::metrics::{counter, gauge, histogram};
5
6
use actix_web::http::header::{HeaderValue, CONTENT_TYPE};
use actix_web::{HttpRequest, HttpResponse};
Byron Hsu's avatar
Byron Hsu committed
7
use futures_util::{StreamExt, TryStreamExt};
8
use std::collections::HashMap;
9
use std::fmt::Debug;
10
use std::sync::atomic::AtomicUsize;
11
use std::sync::{Arc, Mutex, RwLock};
12
13
use std::thread;
use std::time::Duration;
14
use std::time::Instant;
15
use tokio;
16
use tracing::{debug, error, info, warn};
17

18
pub fn copy_request_headers(req: &HttpRequest) -> Vec<(String, String)> {
19
20
21
22
23
24
25
26
27
28
29
    req.headers()
        .iter()
        .filter_map(|(name, value)| {
            value
                .to_str()
                .ok()
                .map(|v| (name.to_string(), v.to_string()))
        })
        .collect()
}

30
#[derive(Debug)]
31
32
pub enum Router {
    RoundRobin {
33
        worker_urls: Arc<RwLock<Vec<String>>>,
34
        current_index: AtomicUsize,
35
        timeout_secs: u64,
36
        interval_secs: u64,
37
38
    },
    Random {
39
        worker_urls: Arc<RwLock<Vec<String>>>,
40
        timeout_secs: u64,
41
        interval_secs: u64,
42
    },
43
44
45
    PrefillDecode {
        pd_router: Arc<PDRouter>,
    },
46
47
    CacheAware {
        /*
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
            Cache-Aware Load Balancing Router

            This router combines two strategies to optimize both cache utilization and request distribution:

            1. Cache-Aware Routing (Approximate Tree)
            2. Load Balancing (Shortest Queue with Balance Thresholds)

            The router dynamically switches between these strategies based on load conditions:
            - Uses load balancing when the system is imbalanced
            - Uses cache-aware routing when the system is balanced

            A system is considered imbalanced if both conditions are met:
            1. (max - min) > abs_threshold
            2. max > rel_threshold * min

            Strategy Details:

            1. Cache-Aware Routing (Approximate Tree)
            -------------------------------------------
            This strategy maintains an approximate radix tree for each worker based on request history,
            eliminating the need for direct cache state queries. The tree stores raw text characters
            instead of token IDs to avoid tokenization overhead.

            Process:
            a. For each request, find the worker with the highest prefix match
            b. If match rate > cache_threshold:
            Route to the worker with highest match (likely has relevant data cached)
            c. If match rate ≤ cache_threshold:
            Route to the worker with smallest tree size (most available cache capacity)
            d. Background maintenance:
            Periodically evict least recently used leaf nodes to prevent memory overflow

            2. Load Balancing (Shortest Queue)
            -------------------------------------------
            This strategy tracks pending request counts per worker and routes new requests
            to the least busy worker when the system is detected to be imbalanced.

            Configuration Parameters:
            ------------------------
            1. cache_threshold: (float, 0.0 to 1.0)
            Minimum prefix match ratio to use highest-match routing.
            Below this threshold, routes to worker with most available cache space.

            2. balance_abs_threshold: (integer)
            Absolute difference threshold for load imbalance detection.
            System is potentially imbalanced if (max_load - min_load) > abs_threshold

            3. balance_rel_threshold: (float)
            Relative ratio threshold for load imbalance detection.
            System is potentially imbalanced if max_load > min_load * rel_threshold
            Used in conjunction with abs_threshold to determine final imbalance state.

            4. eviction_interval_secs: (integer)
            Interval between LRU eviction cycles for the approximate trees.

            5. max_tree_size: (integer)
            Maximum nodes per tree. When exceeded, LRU leaf nodes are evicted
            during the next eviction cycle.
106
        */
107
        worker_urls: Arc<RwLock<Vec<String>>>,
108
109
110
        tree: Arc<Mutex<Tree>>,
        running_queue: Arc<Mutex<HashMap<String, usize>>>,
        processed_queue: Arc<Mutex<HashMap<String, usize>>>,
111
        cache_threshold: f32,
112
113
        balance_abs_threshold: usize,
        balance_rel_threshold: f32,
114
        timeout_secs: u64,
115
        interval_secs: u64,
116
        _eviction_thread: Option<thread::JoinHandle<()>>,
117
118
119
    },
}

120
#[derive(Debug, Clone)]
121
pub enum PolicyConfig {
122
123
    RandomConfig {
        timeout_secs: u64,
124
        interval_secs: u64,
125
126
127
    },
    RoundRobinConfig {
        timeout_secs: u64,
128
        interval_secs: u64,
129
    },
130
    CacheAwareConfig {
131
        cache_threshold: f32,
132
133
        balance_abs_threshold: usize,
        balance_rel_threshold: f32,
134
135
        eviction_interval_secs: u64,
        max_tree_size: usize,
136
        timeout_secs: u64,
137
        interval_secs: u64,
138
    },
139
140
141
142
143
144
145
    PrefillDecodeConfig {
        selection_policy: PDSelectionPolicy,
        prefill_urls: Vec<(String, Option<u16>)>, // (url, bootstrap_port)
        decode_urls: Vec<String>,
        timeout_secs: u64,
        interval_secs: u64,
    },
146
147
}

148
impl Router {
149
    pub fn new(worker_urls: Vec<String>, policy_config: PolicyConfig) -> Result<Self, String> {
150
151
152
        // Update active workers gauge
        gauge!("sgl_router_active_workers").set(worker_urls.len() as f64);

153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
        // Get timeout and interval from policy config
        let (timeout_secs, interval_secs) = match &policy_config {
            PolicyConfig::RandomConfig {
                timeout_secs,
                interval_secs,
            } => (*timeout_secs, *interval_secs),
            PolicyConfig::RoundRobinConfig {
                timeout_secs,
                interval_secs,
            } => (*timeout_secs, *interval_secs),
            PolicyConfig::CacheAwareConfig {
                timeout_secs,
                interval_secs,
                ..
            } => (*timeout_secs, *interval_secs),
168
169
170
171
172
            PolicyConfig::PrefillDecodeConfig {
                timeout_secs,
                interval_secs,
                ..
            } => (*timeout_secs, *interval_secs),
173
174
        };

175
176
177
178
179
180
181
182
183
184
185
        // For PrefillDecode, we need to handle workers differently
        match &policy_config {
            PolicyConfig::PrefillDecodeConfig { .. } => {
                // PD mode doesn't use the worker_urls parameter
                // We'll validate PD workers separately
            }
            _ => {
                // Wait until all workers are healthy for regular modes
                Self::wait_for_healthy_workers(&worker_urls, timeout_secs, interval_secs)?;
            }
        }
186
187
188

        // Create router based on policy...
        Ok(match policy_config {
189
190
191
192
            PolicyConfig::RandomConfig {
                timeout_secs,
                interval_secs,
            } => Router::Random {
193
                worker_urls: Arc::new(RwLock::new(worker_urls)),
194
                timeout_secs,
195
                interval_secs,
196
            },
197
198
199
200
            PolicyConfig::RoundRobinConfig {
                timeout_secs,
                interval_secs,
            } => Router::RoundRobin {
201
                worker_urls: Arc::new(RwLock::new(worker_urls)),
202
                current_index: std::sync::atomic::AtomicUsize::new(0),
203
                timeout_secs,
204
                interval_secs,
205
            },
206
            PolicyConfig::CacheAwareConfig {
207
                cache_threshold,
208
209
                balance_abs_threshold,
                balance_rel_threshold,
210
211
                eviction_interval_secs,
                max_tree_size,
212
                timeout_secs,
213
                interval_secs,
214
            } => {
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
                let mut running_queue = HashMap::new();
                for url in &worker_urls {
                    running_queue.insert(url.clone(), 0);
                }

                let mut processed_queue = HashMap::new();
                for url in &worker_urls {
                    processed_queue.insert(url.clone(), 0);
                }

                let tree = Arc::new(Mutex::new(Tree::new()));
                let running_queue = Arc::new(Mutex::new(running_queue));
                let processed_queue = Arc::new(Mutex::new(processed_queue));

                // Create background eviction thread
                let tree_clone = Arc::clone(&tree);
                let processed_queue_clone = Arc::clone(&processed_queue);
232
                let running_queue_clone = Arc::clone(&running_queue);
233
234
235
236
237
238
239
                let eviction_thread = thread::spawn(move || {
                    loop {
                        // Sleep for the specified interval
                        thread::sleep(Duration::from_secs(eviction_interval_secs));

                        let locked_tree_clone = tree_clone.lock().unwrap();
                        // Run eviction
240
                        locked_tree_clone.evict_tenant_by_size(max_tree_size);
241
242
243

                        // Print the process queue
                        let locked_processed_queue = processed_queue_clone.lock().unwrap();
244
                        info!("Processed Queue: {:?}", locked_processed_queue);
245
246
247

                        // Print the running queue
                        let locked_running_queue = running_queue_clone.lock().unwrap();
248
                        info!("Running Queue: {:?}", locked_running_queue);
249
250
                    }
                });
251
252

                for url in &worker_urls {
253
                    tree.lock().unwrap().insert("", url);
254
255
                }

256
                Router::CacheAware {
257
                    worker_urls: Arc::new(RwLock::new(worker_urls)),
258
259
260
                    tree,
                    running_queue,
                    processed_queue,
261
                    cache_threshold,
262
263
                    balance_abs_threshold,
                    balance_rel_threshold,
264
                    timeout_secs,
265
                    interval_secs,
266
                    _eviction_thread: Some(eviction_thread),
267
268
                }
            }
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
            PolicyConfig::PrefillDecodeConfig {
                selection_policy,
                prefill_urls,
                decode_urls,
                timeout_secs,
                interval_secs,
            } => {
                // Create PDRouter instance
                let pd_router = PDRouter::new(
                    prefill_urls,
                    decode_urls,
                    selection_policy,
                    timeout_secs,
                    interval_secs,
                )?;

                Router::PrefillDecode {
                    pd_router: Arc::new(pd_router),
                }
            }
289
        })
290
291
    }

292
293
294
295
296
297
    /// Get a reference to the worker URLs shared across threads
    pub fn get_worker_urls(&self) -> Arc<RwLock<Vec<String>>> {
        match self {
            Router::RoundRobin { worker_urls, .. } => Arc::clone(worker_urls),
            Router::Random { worker_urls, .. } => Arc::clone(worker_urls),
            Router::CacheAware { worker_urls, .. } => Arc::clone(worker_urls),
298
299
300
301
            Router::PrefillDecode { .. } => {
                // For PD mode, return empty list since we manage workers differently
                Arc::new(RwLock::new(Vec::new()))
            }
302
303
304
        }
    }

305
    pub fn wait_for_healthy_workers(
306
307
308
309
310
        worker_urls: &[String],
        timeout_secs: u64,
        interval_secs: u64,
    ) -> Result<(), String> {
        let start_time = std::time::Instant::now();
311
312
313
314
        let sync_client = reqwest::blocking::Client::builder()
            .timeout(Duration::from_secs(timeout_secs))
            .build()
            .map_err(|e| format!("Failed to create HTTP client: {}", e))?;
315
316
317

        loop {
            if start_time.elapsed() > Duration::from_secs(timeout_secs) {
318
                error!(
319
320
                    "Timeout {}s waiting for workers {:?} to become healthy. Please set --router-worker-startup-timeout-secs (sglang_router.launch_server) or --worker-startup-timeout-secs (sglang_worker.router) to a larger value",
                    timeout_secs, worker_urls
321
                );
322
                return Err(format!(
323
324
                    "Timeout {}s waiting for workers {:?} to become healthy. Please set --router-worker-startup-timeout-secs (sglang_router.launch_server) or --worker-startup-timeout-secs (sglang_worker.router) to a larger value",
                    timeout_secs, worker_urls
325
326
327
328
329
330
331
332
333
334
                ));
            }

            let mut all_healthy = true;
            let mut unhealthy_workers = Vec::new();

            for url in worker_urls {
                match sync_client.get(&format!("{}/health", url)).send() {
                    Ok(res) => {
                        if !res.status().is_success() {
Byron Hsu's avatar
Byron Hsu committed
335
336
                            let msg = format!(
                                "Worker heatlh check is pending with status {}",
337
338
                                res.status()
                            );
Byron Hsu's avatar
Byron Hsu committed
339
                            info!("{}", msg);
340
                            all_healthy = false;
Byron Hsu's avatar
Byron Hsu committed
341
                            unhealthy_workers.push((url, msg));
342
343
                        }
                    }
Byron Hsu's avatar
Byron Hsu committed
344
345
346
                    Err(_) => {
                        let msg = format!("Worker is not ready yet");
                        info!("{}", msg);
347
                        all_healthy = false;
Byron Hsu's avatar
Byron Hsu committed
348
                        unhealthy_workers.push((url, msg));
349
350
351
352
353
354
355
356
                    }
                }
            }

            if all_healthy {
                info!("All workers are healthy");
                return Ok(());
            } else {
Byron Hsu's avatar
Byron Hsu committed
357
                info!("Initializing workers:");
358
359
360
361
362
363
364
365
                for (url, reason) in &unhealthy_workers {
                    info!("  {} - {}", url, reason);
                }
                thread::sleep(Duration::from_secs(interval_secs));
            }
        }
    }

366
367
368
    fn select_first_worker(&self) -> Result<String, String> {
        match self {
            Router::RoundRobin { worker_urls, .. }
369
            | Router::Random { worker_urls, .. }
370
371
372
373
374
375
376
            | Router::CacheAware { worker_urls, .. } => {
                if worker_urls.read().unwrap().is_empty() {
                    Err("No workers are available".to_string())
                } else {
                    Ok(worker_urls.read().unwrap()[0].clone())
                }
            }
377
378
379
380
            Router::PrefillDecode { .. } => {
                // For PD mode, we don't need this method as routing is handled by PDRouter
                Err("PrefillDecode mode doesn't use select_first_worker".to_string())
            }
381
382
383
        }
    }

384
    pub async fn send_request(
385
386
        &self,
        client: &reqwest::Client,
387
        worker_url: &str,
388
        route: &str,
389
        req: &HttpRequest,
390
    ) -> HttpResponse {
391
        let start = Instant::now();
392
393
394
395
396
        let mut request_builder = client.get(format!("{}{}", worker_url, route));

        // Copy all headers from original request except for /health because it does not need authorization
        if route != "/health" {
            for (name, value) in copy_request_headers(req) {
397
398
399
400
401
                // Skip Content-Type and Content-Length as .json() sets them
                if name.to_lowercase() != "content-type" && name.to_lowercase() != "content-length"
                {
                    request_builder = request_builder.header(name, value);
                }
402
403
404
            }
        }

405
        let response = match request_builder.send().await {
406
407
408
409
410
411
412
413
414
415
416
417
418
419
            Ok(res) => {
                let status = actix_web::http::StatusCode::from_u16(res.status().as_u16())
                    .unwrap_or(actix_web::http::StatusCode::INTERNAL_SERVER_ERROR);

                match res.bytes().await {
                    Ok(body) => HttpResponse::build(status).body(body.to_vec()),
                    Err(e) => HttpResponse::InternalServerError()
                        .body(format!("Failed to read response body: {}", e)),
                }
            }
            Err(e) => HttpResponse::InternalServerError().body(format!(
                "Failed to send request to worker {}: {}",
                worker_url, e
            )),
420
421
422
423
424
425
426
427
428
429
430
431
432
        };

        // Record request metrics
        if route != "/health" {
            let duration = start.elapsed();
            counter!("sgl_router_requests_total", "route" => route.to_string()).increment(1);
            histogram!("sgl_router_request_duration_seconds", "route" => route.to_string())
                .record(duration.as_secs_f64());

            if !response.status().is_success() {
                counter!("sgl_router_request_errors_total", "route" => route.to_string())
                    .increment(1);
            }
433
        }
434
        response
435
436
    }

437
438
439
440
441
442
    pub async fn route_to_first(
        &self,
        client: &reqwest::Client,
        route: &str,
        req: &HttpRequest,
    ) -> HttpResponse {
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
        const MAX_REQUEST_RETRIES: u32 = 3;
        const MAX_TOTAL_RETRIES: u32 = 6;
        let mut total_retries = 0;

        while total_retries < MAX_TOTAL_RETRIES {
            match self.select_first_worker() {
                Ok(worker_url) => {
                    let mut request_retries = 0;

                    // Try the same worker multiple times
                    while request_retries < MAX_REQUEST_RETRIES {
                        if total_retries >= 1 {
                            info!("Retrying request after {} failed attempts", total_retries);
                        }

458
                        let response = self.send_request(client, &worker_url, route, req).await;
459
460
461

                        if response.status().is_success() {
                            return response;
462
463
464
465
466
467
468
                        } else {
                            // if the worker is healthy, it means the request is bad, so return the error response
                            let health_response =
                                self.send_request(client, &worker_url, "/health", req).await;
                            if health_response.status().is_success() {
                                return response;
                            }
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
                        }

                        warn!(
                            "Request to {} failed (attempt {}/{})",
                            worker_url,
                            request_retries + 1,
                            MAX_REQUEST_RETRIES
                        );

                        request_retries += 1;
                        total_retries += 1;

                        if request_retries == MAX_REQUEST_RETRIES {
                            warn!("Removing failed worker: {}", worker_url);
                            self.remove_worker(&worker_url);
                            break;
                        }
                    }
                }
                Err(e) => return HttpResponse::InternalServerError().body(e),
            }
490
        }
491
492

        HttpResponse::InternalServerError().body("All retry attempts failed")
493
494
    }

495
496
497
498
499
500
501
502
503
504
505
506
507
    pub async fn route_to_all(
        &self,
        client: &reqwest::Client,
        route: &str,
        req: &HttpRequest,
    ) -> HttpResponse {
        // Get all worker URLs based on router type
        let worker_urls = match self {
            Router::PrefillDecode { .. } => {
                // For PD mode, route_to_all is not supported directly
                // It should be handled by PDRouter if needed
                return HttpResponse::NotImplemented()
                    .body("route_to_all not implemented for PrefillDecode mode");
508
            }
509
            _ => self.get_worker_urls().read().unwrap().clone(),
510
        };
511

512
513
514
515
516
517
518
519
        // Send requests to all workers concurrently
        let mut tasks = Vec::new();
        for worker_url in &worker_urls {
            let mut request_builder = client.post(format!("{}{}", worker_url, route));

            // Copy headers from original request
            for (name, value) in copy_request_headers(req) {
                request_builder = request_builder.header(name, value);
520
            }
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550

            tasks.push(request_builder.send());
        }

        // Wait for all responses
        let results = futures_util::future::join_all(tasks).await;

        // Check if all succeeded
        let all_success = results.iter().all(|r| {
            r.as_ref()
                .map(|res| res.status().is_success())
                .unwrap_or(false)
        });

        if all_success {
            HttpResponse::Ok().body("Operation completed on all servers")
        } else {
            HttpResponse::InternalServerError().body("Operation failed on one or more servers")
        }
    }

    pub async fn get_all_loads(
        &self,
        client: &reqwest::Client,
        _req: &HttpRequest,
    ) -> HttpResponse {
        // For PD mode, delegate to PDRouter
        match self {
            Router::PrefillDecode { pd_router } => {
                return pd_router.get_loads(client).await;
551
552
            }
            _ => {
553
                // For non-PD routers, handle normally
554
555
            }
        }
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586

        let urls = self.get_worker_urls().read().unwrap().clone();
        let prefill_urls: Vec<String> = Vec::new();
        let decode_urls = urls;

        // Collect loads from all servers
        let mut prefill_loads = Vec::new();
        let mut decode_loads = Vec::new();

        // Get prefill loads
        for url in &prefill_urls {
            let load = self.get_worker_load(client, url).await.unwrap_or(-1);
            prefill_loads.push(serde_json::json!({
                "engine": format!("(Prefill@{})", url),
                "load": load as i64
            }));
        }

        // Get decode loads
        for url in &decode_urls {
            let load = self.get_worker_load(client, url).await.unwrap_or(-1);
            decode_loads.push(serde_json::json!({
                "engine": format!("(Decode@{})", url),
                "load": load as i64
            }));
        }

        HttpResponse::Ok().json(serde_json::json!({
            "prefill": prefill_loads,
            "decode": decode_loads
        }))
587
588
    }

589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
    // New method to route typed requests directly
    pub async fn route_typed_request<
        T: crate::openai_api_types::GenerationRequest + serde::Serialize + Clone,
    >(
        &self,
        client: &reqwest::Client,
        req: &HttpRequest,
        typed_req: &T,
        route: &str,
    ) -> HttpResponse {
        match self {
            Router::PrefillDecode { .. } => HttpResponse::InternalServerError()
                .body("PD routing should use specialized typed handlers"),
            _ => {
                // Handle retries like the original implementation
                let start = Instant::now();
                const MAX_REQUEST_RETRIES: u32 = 3;
                const MAX_TOTAL_RETRIES: u32 = 6;
                let mut total_retries = 0;

                while total_retries < MAX_TOTAL_RETRIES {
                    // Extract routing text directly from typed request
                    let text = typed_req.extract_text_for_routing();
                    let is_stream = typed_req.is_stream();

                    // Select worker based on text
                    let worker_url = self.select_generate_worker_from_text(&text);
                    let mut request_retries = 0;

                    // Try the same worker multiple times
                    while request_retries < MAX_REQUEST_RETRIES {
                        if total_retries >= 1 {
                            info!("Retrying request after {} failed attempts", total_retries);
                            counter!("sgl_router_retries_total", "route" => route.to_string())
                                .increment(1);
                        }

                        // Send typed request directly
                        let response = self
                            .send_typed_request(
                                client,
                                req,
                                typed_req,
                                route,
                                &worker_url,
                                is_stream,
                            )
                            .await;

                        if response.status().is_success() {
                            let duration = start.elapsed();
                            histogram!("sgl_router_generate_duration_seconds", "route" => route.to_string())
                                .record(duration.as_secs_f64());
                            return response;
                        } else {
                            // if the worker is healthy, it means the request is bad, so return the error response
                            let health_response =
                                self.send_request(client, &worker_url, "/health", req).await;
                            if health_response.status().is_success() {
                                counter!("sgl_router_request_errors_total", "route" => route.to_string())
                                    .increment(1);
                                return response;
                            }
                        }

                        warn!(
                            "Generate request to {} failed (attempt {}/{})",
                            worker_url,
                            request_retries + 1,
                            MAX_REQUEST_RETRIES
                        );

                        request_retries += 1;
                        total_retries += 1;
663

664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
                        if request_retries == MAX_REQUEST_RETRIES {
                            warn!("Removing failed worker: {}", worker_url);
                            self.remove_worker(&worker_url);
                            break;
                        }
                    }
                }

                counter!("sgl_router_request_errors_total", "route" => route.to_string())
                    .increment(1);
                HttpResponse::InternalServerError().body("All retry attempts failed")
            }
        }
    }

    // Helper method to select worker from text
    fn select_generate_worker_from_text(&self, text: &str) -> String {
        match self {
682
683
684
            Router::RoundRobin {
                worker_urls,
                current_index,
685
                ..
686
            } => {
687
                let idx = current_index
688
689
690
                    .fetch_update(
                        std::sync::atomic::Ordering::SeqCst,
                        std::sync::atomic::Ordering::SeqCst,
691
                        |x| Some((x + 1) % worker_urls.read().unwrap().len()),
692
                    )
693
                    .unwrap();
694
                worker_urls.read().unwrap()[idx].clone()
695
            }
696

697
            Router::Random { worker_urls, .. } => worker_urls.read().unwrap()
698
699
                [rand::random::<usize>() % worker_urls.read().unwrap().len()]
            .clone(),
700

701
            Router::CacheAware {
702
                worker_urls,
703
704
705
                tree,
                running_queue,
                processed_queue,
706
                cache_threshold,
707
708
                balance_abs_threshold,
                balance_rel_threshold,
709
710
                ..
            } => {
Byron Hsu's avatar
Byron Hsu committed
711
                let tree = tree.lock().unwrap();
712
                let mut running_queue = running_queue.lock().unwrap();
713

714
715
716
717
718
719
720
721
722
723
724
725
                // Get current load statistics
                let max_load = *running_queue.values().max().unwrap_or(&0);
                let min_load = *running_queue.values().min().unwrap_or(&0);

                // Load is considered imbalanced if:
                // 1. (max - min) > abs_threshold AND
                // 2. max > rel_threshold * min
                let is_imbalanced = max_load.saturating_sub(min_load) > *balance_abs_threshold
                    && (max_load as f32) > (min_load as f32 * balance_rel_threshold);

                let selected_url = if is_imbalanced {
                    // Log load balancing trigger and current queue state
726
                    info!(
727
728
729
730
731
732
                        "Load balancing triggered due to workload imbalance:\n\
                        Max load: {}, Min load: {}\n\
                        Current running queue: {:?}",
                        max_load, min_load, running_queue
                    );

733
734
735
736
                    counter!("sgl_router_load_balancing_events_total").increment(1);
                    gauge!("sgl_router_max_load").set(max_load as f64);
                    gauge!("sgl_router_min_load").set(min_load as f64);

737
738
739
740
741
                    // Use shortest queue routing when load is imbalanced
                    running_queue
                        .iter()
                        .min_by_key(|(_url, &count)| count)
                        .map(|(url, _)| url.clone())
742
                        .unwrap_or_else(|| worker_urls.read().unwrap()[0].clone())
743
744
                } else {
                    // Use cache-aware routing when load is balanced
745
746
747
                    let (matched_text, matched_worker) = tree.prefix_match(&text);
                    let matched_rate =
                        matched_text.chars().count() as f32 / text.chars().count() as f32;
748

749
                    if matched_rate > *cache_threshold {
750
                        counter!("sgl_router_cache_hits_total").increment(1);
751
752
                        matched_worker.to_string()
                    } else {
753
                        counter!("sgl_router_cache_misses_total").increment(1);
754
                        tree.get_smallest_tenant()
755
                    }
756
                };
757

758
759
                // Update queues and tree
                *running_queue.get_mut(&selected_url).unwrap() += 1;
760

761
762
763
764
765
                *processed_queue
                    .lock()
                    .unwrap()
                    .get_mut(&selected_url)
                    .unwrap() += 1;
766
767
768
769
770

                gauge!("sgl_router_running_requests", "worker" => selected_url.to_string())
                    .set(*running_queue.get(&selected_url).unwrap() as f64);
                counter!("sgl_router_processed_requests_total", "worker" => selected_url.to_string()).increment(1);

771
772
773
                tree.insert(&text, &selected_url);

                selected_url
774
            }
775
776
777
778
779
            Router::PrefillDecode { .. } => {
                // For PD mode, we don't use this method
                return "PD_MODE_ERROR".to_string();
            }
        }
780
781
    }

782
783
    // Send typed request directly without conversion
    async fn send_typed_request<T: serde::Serialize>(
784
785
        &self,
        client: &reqwest::Client,
786
        req: &HttpRequest,
787
        typed_req: &T,
788
789
        route: &str,
        worker_url: &str,
790
        is_stream: bool,
791
    ) -> HttpResponse {
792
793
794
795
796
797
        let start = Instant::now();

        // Debug: Log what we're sending
        if let Ok(json_str) = serde_json::to_string_pretty(typed_req) {
            debug!("Sending request to {}: {}", route, json_str);
        }
798

799
        let mut request_builder = client
800
            .post(format!("{}{}", worker_url, route))
801
            .json(typed_req); // Use json() directly with typed request
802
803
804

        // Copy all headers from original request
        for (name, value) in copy_request_headers(req) {
805
806
807
808
            // Skip Content-Type and Content-Length as .json() sets them
            if name.to_lowercase() != "content-type" && name.to_lowercase() != "content-length" {
                request_builder = request_builder.header(&name, &value);
            }
809
810
811
        }

        let res = match request_builder.send().await {
812
            Ok(res) => res,
813
814
815
816
            Err(e) => {
                error!("Failed to send request to {}: {}", worker_url, e);
                return HttpResponse::InternalServerError().body(format!("Request failed: {}", e));
            }
817
        };
818

819
820
        let status = actix_web::http::StatusCode::from_u16(res.status().as_u16())
            .unwrap_or(actix_web::http::StatusCode::INTERNAL_SERVER_ERROR);
821

822
        if !is_stream {
823
824
            // For non-streaming requests, get response first
            let response = match res.bytes().await {
825
                Ok(body) => HttpResponse::build(status).body(body.to_vec()),
826
827
828
829
                Err(e) => {
                    let error_msg = format!("Failed to get response body: {}", e);
                    HttpResponse::InternalServerError().body(error_msg)
                }
830
831
832
833
834
            };

            // Then decrement running queue counter if using CacheAware
            if let Router::CacheAware { running_queue, .. } = self {
                if let Ok(mut queue) = running_queue.lock() {
835
                    if let Some(count) = queue.get_mut(worker_url) {
836
837
838
                        *count = count.saturating_sub(1);
                    }
                }
839
            }
840

841
842
843
844
845
846
            // Record metrics
            let duration = start.elapsed();
            histogram!("sgl_router_generate_duration_seconds", "route" => route.to_string())
                .record(duration.as_secs_f64());
            counter!("sgl_router_requests_total", "route" => route.to_string()).increment(1);

847
848
849
            response
        } else if let Router::CacheAware { running_queue, .. } = self {
            let running_queue = Arc::clone(running_queue);
850
            let worker_url = worker_url.to_string();
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868

            HttpResponse::build(status)
                .insert_header((CONTENT_TYPE, HeaderValue::from_static("text/event-stream")))
                .streaming(
                    res.bytes_stream()
                        .map_err(|_| {
                            actix_web::error::ErrorInternalServerError("Failed to read stream")
                        })
                        .inspect(move |bytes| {
                            let bytes = bytes.as_ref().unwrap();
                            if bytes
                                .as_ref()
                                .windows(12)
                                .any(|window| window == b"data: [DONE]")
                            {
                                let mut locked_queue = running_queue.lock().unwrap();
                                let count = locked_queue.get_mut(&worker_url).unwrap();
                                *count = count.saturating_sub(1);
869
                                debug!("Streaming is done!!")
870
871
872
                            }
                        }),
                )
873
874
875
876
        } else {
            HttpResponse::build(status)
                .insert_header((CONTENT_TYPE, HeaderValue::from_static("text/event-stream")))
                .streaming(res.bytes_stream().map_err(|_| {
877
                    actix_web::error::ErrorInternalServerError("Failed to read stream")
878
                }))
879
880
        }
    }
881

882
    pub async fn add_worker(&self, worker_url: &str) -> Result<String, String> {
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
        let (timeout_secs, interval_secs) = match self {
            Router::Random {
                timeout_secs,
                interval_secs,
                ..
            } => (*timeout_secs, *interval_secs),
            Router::RoundRobin {
                timeout_secs,
                interval_secs,
                ..
            } => (*timeout_secs, *interval_secs),
            Router::CacheAware {
                timeout_secs,
                interval_secs,
                ..
            } => (*timeout_secs, *interval_secs),
899
900
901
902
            Router::PrefillDecode { .. } => {
                // For PD mode, we don't support adding workers via this method
                return Err("Adding workers to PrefillDecode router not supported via add_worker. Use dedicated PD management methods.".to_string());
            }
903
        };
904
905

        let start_time = std::time::Instant::now();
906
907
908
909
        let client = reqwest::Client::builder()
            .timeout(Duration::from_secs(timeout_secs))
            .build()
            .map_err(|e| format!("Failed to create HTTP client: {}", e))?;
910
911
912

        loop {
            if start_time.elapsed() > Duration::from_secs(timeout_secs) {
913
                error!(
914
                    "Timeout {}s waiting for worker {} to become healthy. Please set --router-worker-startup-timeout-secs (sglang_router.launch_server) or --worker-startup-timeout-secs (sglang_worker.router) to a larger value",
915
916
                    timeout_secs, worker_url
                );
917
                return Err(format!(
918
                    "Timeout {}s waiting for worker {} to become healthy. Please set --router-worker-startup-timeout-secs (sglang_router.launch_server) or --worker-startup-timeout-secs (sglang_worker.router) to a larger value",
919
920
921
922
923
924
925
926
927
                    timeout_secs, worker_url
                ));
            }

            match client.get(&format!("{}/health", worker_url)).send().await {
                Ok(res) => {
                    if res.status().is_success() {
                        match self {
                            Router::RoundRobin { worker_urls, .. }
928
                            | Router::Random { worker_urls, .. }
929
930
931
                            | Router::CacheAware { worker_urls, .. } => {
                                info!("Worker {} health check passed", worker_url);
                                let mut urls = worker_urls.write().unwrap();
932
                                if urls.contains(&worker_url.to_string()) {
933
                                    return Err(format!("Worker {} already exists", worker_url));
934
935
                                }
                                info!("Added worker: {}", worker_url);
936
                                urls.push(worker_url.to_string());
937
                                gauge!("sgl_router_active_workers").set(urls.len() as f64);
938
                            }
939
940
941
                            Router::PrefillDecode { .. } => {
                                return Err("Adding workers to PrefillDecode router not supported via add_worker. Use dedicated PD management methods.".to_string());
                            }
942
                        }
943
944
945
946
947
948
949
950
951
952

                        // If cache aware, initialize the queues for the new worker
                        if let Router::CacheAware {
                            running_queue,
                            processed_queue,
                            tree,
                            ..
                        } = self
                        {
                            // Add worker to running queue with initial count of 0
953
954
955
956
                            running_queue
                                .lock()
                                .unwrap()
                                .insert(worker_url.to_string(), 0);
957
958
959
960
961

                            // Add worker to processed queue with initial count of 0
                            processed_queue
                                .lock()
                                .unwrap()
962
                                .insert(worker_url.to_string(), 0);
963
964

                            // Add worker to tree
965
                            tree.lock().unwrap().insert("", worker_url);
966
967
968
                        }

                        return Ok(format!("Successfully added worker: {}", worker_url));
969
970
                    } else {
                        info!(
971
972
973
                            "Worker {} health check is pending with status: {}.",
                            worker_url,
                            res.status()
974
975
976
977
978
979
980
981
982
983
984
985
                        );
                        // if the url does not have http or https prefix, warn users
                        if !worker_url.starts_with("http://") && !worker_url.starts_with("https://")
                        {
                            warn!("The worker url {} does not have http or https prefix. Please add the prefix to the url.", worker_url);
                        }

                        tokio::time::sleep(Duration::from_secs(interval_secs)).await;
                        continue;
                    }
                }
                Err(e) => {
986
987
988
989
                    info!(
                        "Worker {} health check is pending with error: {}",
                        worker_url, e
                    );
990
991
992
993
994
995
996
997
998

                    // if the url does not have http or https prefix, warn users
                    if !worker_url.starts_with("http://") && !worker_url.starts_with("https://") {
                        warn!("The worker url {} does not have http or https prefix. Please add the prefix to the url.", worker_url);
                    }

                    tokio::time::sleep(Duration::from_secs(interval_secs)).await;
                    continue;
                }
999
1000
1001
            }
        }
    }
1002

1003
    pub fn remove_worker(&self, worker_url: &str) {
1004
1005
        match self {
            Router::RoundRobin { worker_urls, .. }
1006
            | Router::Random { worker_urls, .. }
1007
1008
            | Router::CacheAware { worker_urls, .. } => {
                let mut urls = worker_urls.write().unwrap();
1009
1010
1011
                if let Some(index) = urls.iter().position(|url| url == &worker_url) {
                    urls.remove(index);
                    info!("Removed worker: {}", worker_url);
1012
                    gauge!("sgl_router_active_workers").set(urls.len() as f64);
1013
1014
1015
1016
                } else {
                    warn!("Worker {} not found, skipping removal", worker_url);
                    return;
                }
1017
            }
1018
1019
1020
1021
            Router::PrefillDecode { .. } => {
                warn!("Removing workers from PrefillDecode router not supported via remove_worker. Use dedicated PD management methods.");
                return;
            }
1022
1023
1024
        }

        // if cache aware, remove the worker from the tree
1025
1026
1027
1028
1029
1030
1031
        if let Router::CacheAware {
            tree,
            running_queue,
            processed_queue,
            ..
        } = self
        {
1032
            tree.lock().unwrap().remove_tenant(&worker_url);
1033
1034
1035
1036
1037
1038
1039
1040
            running_queue
                .lock()
                .unwrap()
                .remove(&worker_url.to_string());
            processed_queue
                .lock()
                .unwrap()
                .remove(&worker_url.to_string());
1041
1042
1043
1044
            info!(
                "Removed worker from tree and cleaned up queues: {}",
                worker_url
            );
1045
1046
        }
    }
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175

    async fn get_worker_load(&self, client: &reqwest::Client, worker_url: &str) -> Option<isize> {
        match client.get(&format!("{}/get_load", worker_url)).send().await {
            Ok(res) if res.status().is_success() => match res.bytes().await {
                Ok(bytes) => match serde_json::from_slice::<serde_json::Value>(&bytes) {
                    Ok(data) => data
                        .get("load")
                        .and_then(|v| v.as_i64())
                        .map(|v| v as isize),
                    Err(e) => {
                        debug!("Failed to parse load response from {}: {}", worker_url, e);
                        None
                    }
                },
                Err(e) => {
                    debug!("Failed to read load response from {}: {}", worker_url, e);
                    None
                }
            },
            Ok(res) => {
                debug!(
                    "Worker {} returned non-success status: {}",
                    worker_url,
                    res.status()
                );
                None
            }
            Err(e) => {
                debug!("Failed to get load from {}: {}", worker_url, e);
                None
            }
        }
    }

    // PD-specific wrapper methods that delegate to PDRouter
    pub async fn route_pd_health_generate(
        &self,
        _client: &reqwest::Client,
        _req: &HttpRequest,
    ) -> HttpResponse {
        match self {
            Router::PrefillDecode { pd_router } => {
                pd_router.health_generate(&pd_router.http_client).await
            }
            _ => HttpResponse::InternalServerError().body("Not in PrefillDecode mode"),
        }
    }

    pub async fn route_pd_generate_typed(
        &self,
        _client: &reqwest::Client,
        req: &HttpRequest,
        typed_req: crate::pd_types::GenerateReqInput,
        route: &str,
    ) -> HttpResponse {
        match self {
            Router::PrefillDecode { pd_router } => {
                pd_router
                    .route_generate(&pd_router.http_client, req, typed_req, route)
                    .await
            }
            _ => HttpResponse::InternalServerError().body("Not in PrefillDecode mode"),
        }
    }

    pub async fn route_pd_chat_typed(
        &self,
        _client: &reqwest::Client,
        req: &HttpRequest,
        typed_req: crate::pd_types::ChatReqInput,
        route: &str,
    ) -> HttpResponse {
        match self {
            Router::PrefillDecode { pd_router } => {
                pd_router
                    .route_chat(&pd_router.http_client, req, typed_req, route)
                    .await
            }
            _ => HttpResponse::InternalServerError().body("Not in PrefillDecode mode"),
        }
    }

    pub async fn get_pd_server_info(
        &self,
        _client: &reqwest::Client,
        _req: &HttpRequest,
    ) -> HttpResponse {
        match self {
            Router::PrefillDecode { pd_router } => {
                pd_router.get_server_info(&pd_router.http_client).await
            }
            _ => HttpResponse::InternalServerError().body("Not in PrefillDecode mode"),
        }
    }

    pub async fn get_pd_models(
        &self,
        _client: &reqwest::Client,
        req: &HttpRequest,
    ) -> HttpResponse {
        match self {
            Router::PrefillDecode { pd_router } => {
                pd_router.get_models(&pd_router.http_client, req).await
            }
            _ => HttpResponse::InternalServerError().body("Not in PrefillDecode mode"),
        }
    }

    pub async fn route_pd_flush_cache(&self, _client: &reqwest::Client) -> HttpResponse {
        match self {
            Router::PrefillDecode { pd_router } => {
                pd_router.flush_cache(&pd_router.http_client).await
            }
            _ => HttpResponse::InternalServerError().body("Not in PrefillDecode mode"),
        }
    }

    pub async fn get_pd_model_info(
        &self,
        _client: &reqwest::Client,
        req: &HttpRequest,
    ) -> HttpResponse {
        match self {
            Router::PrefillDecode { pd_router } => {
                pd_router.get_model_info(&pd_router.http_client, req).await
            }
            _ => HttpResponse::InternalServerError().body("Not in PrefillDecode mode"),
        }
    }
1176
}