Unverified Commit f9dadfbe authored by Woosuk Kwon's avatar Woosuk Kwon Committed by GitHub
Browse files

[V1] Fix detokenizer ports (#10224)


Signed-off-by: default avatarWoosuk Kwon <woosuk.kwon@berkeley.edu>
parent 25144cee
...@@ -48,11 +48,13 @@ class Detokenizer: ...@@ -48,11 +48,13 @@ class Detokenizer:
# For example, it does not terminate properly. We need to improve this. # For example, it does not terminate properly. We need to improve this.
self.push_port = get_open_port() self.push_port = get_open_port()
self.pull_port = get_open_port() self.pull_port = get_open_port()
# NOTE: The push port of the engine process should be the same as the
# pull port of the detokenizer process. Vice versa.
self.detokenizer = DetokenizerProc(tokenizer_name=tokenizer_name, self.detokenizer = DetokenizerProc(tokenizer_name=tokenizer_name,
tokenizer_mode=tokenizer_mode, tokenizer_mode=tokenizer_mode,
trust_remote_code=trust_remote_code, trust_remote_code=trust_remote_code,
push_port=self.push_port, push_port=self.pull_port,
pull_port=self.pull_port) pull_port=self.push_port)
self.detokenizer.start() self.detokenizer.start()
self.zmq_context = zmq.Context() self.zmq_context = zmq.Context()
...@@ -95,8 +97,8 @@ class DetokenizerProc(multiprocessing.Process): ...@@ -95,8 +97,8 @@ class DetokenizerProc(multiprocessing.Process):
self.tokenizer_name = tokenizer_name self.tokenizer_name = tokenizer_name
self.tokenizer_mode = tokenizer_mode self.tokenizer_mode = tokenizer_mode
self.trust_remote_code = trust_remote_code self.trust_remote_code = trust_remote_code
# NOTE: The pull_port of the detokenizer should be the same as the # NOTE: The pull_port of the detokenizer process should be the same as
# push_port of the engine. Vice versa. # the push_port of the engine process. Vice versa.
self.pull_port = pull_port self.pull_port = pull_port
self.push_port = push_port self.push_port = push_port
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment