Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
f7290232
Unverified
Commit
f7290232
authored
Aug 19, 2025
by
Zhewen Li
Committed by
GitHub
Aug 20, 2025
Browse files
[CI/Build] Also check DP in benchmarks throughput script (#23038)
Co-authored-by:
Simon Mo
<
simon.mo@hey.com
>
parent
1a3079a1
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
2 deletions
+10
-2
benchmarks/benchmark_throughput.py
benchmarks/benchmark_throughput.py
+2
-2
vllm/benchmarks/throughput.py
vllm/benchmarks/throughput.py
+8
-0
No files found.
benchmarks/benchmark_throughput.py
View file @
f7290232
...
@@ -597,8 +597,8 @@ def validate_args(args):
...
@@ -597,8 +597,8 @@ def validate_args(args):
# https://github.com/vllm-project/vllm/issues/16222
# https://github.com/vllm-project/vllm/issues/16222
if
args
.
data_parallel_size
>
1
:
if
args
.
data_parallel_size
>
1
:
raise
ValueError
(
raise
ValueError
(
"Data parallel is not supported in offline benchmark,
\
"Data parallel is not supported in offline benchmark,
"
please use benchmark serving instead"
"
please use benchmark serving instead"
)
)
...
...
vllm/benchmarks/throughput.py
View file @
f7290232
...
@@ -435,6 +435,14 @@ def validate_args(args):
...
@@ -435,6 +435,14 @@ def validate_args(args):
raise
ValueError
(
raise
ValueError
(
"Tokenizer must be the same as the model for MII backend."
)
"Tokenizer must be the same as the model for MII backend."
)
# --data-parallel is not supported currently.
# https://github.com/vllm-project/vllm/issues/16222
if
args
.
data_parallel_size
>
1
:
raise
ValueError
(
"Data parallel is not supported in offline benchmark, "
"please use benchmark serving instead"
)
def
add_cli_args
(
parser
:
argparse
.
ArgumentParser
):
def
add_cli_args
(
parser
:
argparse
.
ArgumentParser
):
parser
.
add_argument
(
"--backend"
,
parser
.
add_argument
(
"--backend"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment