Unverified Commit f7290232 authored by Zhewen Li's avatar Zhewen Li Committed by GitHub
Browse files

[CI/Build] Also check DP in benchmarks throughput script (#23038)


Co-authored-by: default avatarSimon Mo <simon.mo@hey.com>
parent 1a3079a1
...@@ -597,8 +597,8 @@ def validate_args(args): ...@@ -597,8 +597,8 @@ def validate_args(args):
# https://github.com/vllm-project/vllm/issues/16222 # https://github.com/vllm-project/vllm/issues/16222
if args.data_parallel_size > 1: if args.data_parallel_size > 1:
raise ValueError( raise ValueError(
"Data parallel is not supported in offline benchmark, \ "Data parallel is not supported in offline benchmark, "
please use benchmark serving instead" "please use benchmark serving instead"
) )
......
...@@ -434,6 +434,14 @@ def validate_args(args): ...@@ -434,6 +434,14 @@ def validate_args(args):
if args.backend == "mii" and args.tokenizer != args.model: if args.backend == "mii" and args.tokenizer != args.model:
raise ValueError( raise ValueError(
"Tokenizer must be the same as the model for MII backend.") "Tokenizer must be the same as the model for MII backend.")
# --data-parallel is not supported currently.
# https://github.com/vllm-project/vllm/issues/16222
if args.data_parallel_size > 1:
raise ValueError(
"Data parallel is not supported in offline benchmark, "
"please use benchmark serving instead"
)
def add_cli_args(parser: argparse.ArgumentParser): def add_cli_args(parser: argparse.ArgumentParser):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment